Add validation constraints to views.settings

./vendor/bin/drush config:inspect --filter-keys=views.settings --detail --list-constraints ➜ 🤖 Analyzing… Legend for Data: ✅❓ → Correct primitive type, detailed validation impossible. ✅✅ → Correct primitive type, passed all validation constraints. --------------------------------------------------- --------- ------------- ------ -------------------------------------------- Key Status Validatable Data Validation constraints --------------------------------------------------- --------- ------------- ------ -------------------------------------------- views.settings Correct 31% ✅❓ ValidKeys: '<infer>' LangcodeRequiredIfTranslatableValues: null views.settings: Correct Validatable ✅✅ ValidKeys: '<infer>' LangcodeRequiredIfTranslatableValues: null views.settings:_core Correct Validatable ✅✅ ValidKeys: - default_config_hash views.settings:_core.default_config_hash Correct Validatable ✅✅ NotNull: { } Regex: '/^[a-zA-Z0-9\-_]+$/' Length: 43 ↣ PrimitiveType: { } views.settings:display_extenders Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.address Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.article Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.aside Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.blockquote Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.code Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.del Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.details Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.div Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.em Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.figure Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.footer Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.h1 Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.h2 Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.h3 Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.h4 Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.h5 Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.h6 Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.header Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.ins Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.kbd Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.p Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.pre Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.q Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.s Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.samp Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.section Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.span Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.strong Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:field_rewrite_elements.var Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:sql_signature Correct Validatable ✅✅ ↣ PrimitiveType: { } views.settings:ui Correct Validatable ✅✅ ValidKeys: '<infer>' views.settings:ui.always_live_preview Correct Validatable ✅✅ ↣ PrimitiveType: { } views.settings:ui.exposed_filter_any_label Correct NOT ✅❓ ⚠️ @todo Add validation constraints here views.settings:ui.show Correct Validatable ✅✅ ValidKeys: '<infer>' views.settings:ui.show.additional_queries Correct Validatable ✅✅ ↣ PrimitiveType: { } views.settings:ui.show.advanced_column Correct Validatable ✅✅ ↣ PrimitiveType: { } views.settings:ui.show.default_display Correct Validatable ✅✅ ↣ PrimitiveType: { } views.settings:ui.show.display_embed Correct Validatable ✅✅ ↣ PrimitiveType: { } views.settings:ui.show.performance_statistics Correct Validatable ✅✅ ↣ PrimitiveType: { } views.settings:ui.show.preview_information Correct Validatable ✅✅ ↣ PrimitiveType: { } views.settings:ui.show.sql_query Correct Validatable ✅✅ ValidKeys: '<infer>' views.settings:ui.show.sql_query.enabled Correct Validatable ✅✅ ↣ PrimitiveType: { } views.settings:ui.show.sql_query.where Correct NOT ✅❓ ⚠️ @todo Add validation constraints here --------------------------------------------------- --------- ------------- ------ --------------------------------------------

Comments & Activities

Issue created by @narendraR
First commit to issue fork.
Merge request !7953Draft: fix: validate views.settings.display_extenders → (Open) created by mikelutz
Pipeline finished with Failed
11 months ago
Total: 1082s
#166928
Pipeline finished with Failed
11 months ago
Total: 702s
#167455
Pipeline finished with Failed
11 months ago
Total: 738s
#167485
Comment 11 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
YAY! Welcome, @mikelutz! 😄🥳 Unfortunately GitLab seems to just have gone down!?! 😱 I'm getting 503s!
Status changed to Needs work 11 months ago3:34pm 8 May 2024
Comment 11 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Excellent start! Thanks for helping out making all of Drupal core's config validatable! I left some pointers in my review on the merge request 😊
Pipeline finished with Failed
11 months ago
Total: 664s
#167654
Pipeline finished with Failed
11 months ago
Total: 604s
#167696
Comment 11 months ago →
🇺🇸United States mikelutz Michigan, USA
The test failure is on the display_extenders section. It's a sequence of enabled display_extender plugins, but it's inserted directly from the form values of a mulit-checkbox element. So enabled plugins look like "plugin_id: plugin_id" and disabled plugins look like "plugin_id: '0'". As it is now, validation would mean the value is either an existing display_extender plugin OR the string "0". So the question is do we write that, maybe as an extra option to PluginExists, or a one-off for this situation for views that can be used with the Choice constraint? Or do we start array_filtering the values from the form before storing them, and add an update hook to clean up existing configs first?
Comment 9 months ago →
🇬🇧United Kingdom scott_euser
scott_euser → changed the visibility of the branch 3440962-add-validation-constraints to hidden.
Status changed to Postponed 9 months ago7:46pm 8 July 2024
Comment 9 months ago →
🇬🇧United Kingdom scott_euser
Okay I created 🐛 Views display extenders should only save enabled extenders Needs review to prove that display_extenders issue + sort it with the array_filter. We are already filtering them on load in Drupal\views\Views::getEnabledDisplayExtenders() so it seems logical to filter them out on save. To avoid a more complicated update, I think it does not hurt to keep the array filter in the ::getEnabledDisplayExtenders().

So I think this is postponed until 🐛 Views display extenders should only save enabled extenders Needs review gets merged right?
Comment 5 months ago →
🇳🇿New Zealand quietone
Comment 17 days ago →
🇳🇱Netherlands bbrala Netherlands
Seems blocked on 🐛 views.settings config object should not be used to cache list of available plugins Active since that one is the one still open, the blocked listed earlier was closed as duplicate of 🐛 views.settings config object should not be used to cache list of available plugins Active

Add validation constraints to views.settings

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!7953Add validation constraints to views.settings
Open

Comments & Activities

Add validation constraints to views.settings

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!7953Add validation constraints to views.settingsOpen

Comments & Activities

!7953Add validation constraints to views.settings
Open