- Issue created by @scott_euser
- Status changed to Needs review
6 months ago 7:43pm 8 July 2024 - π¬π§United Kingdom scott_euser
Added the array_filter + test coverage to ensure they get filtered. If you run the test on its own without the change, it fails, showing that the issue exists.
- π¬π§United Kingdom scott_euser
This issue blocks π Add validation constraints to views.settings Postponed I believe. So once this gets sorted, that one get go back to NR.
- π¬π§United Kingdom scott_euser
The 'Test-only changes' confirms this successful fails without the array_filter code change. Ready for review.
- π³π±Netherlands Lendude Amsterdam
So now the filtering happens in two spots right? It still happens in Drupal\views\Views::getEnabledDisplayExtenders()
I would think we would want an update hook here that cleans the existing config and then we can remove the filtering in Drupal\views\Views::getEnabledDisplayExtenders() right? Scope wise it makes more sense to me to do that here than in π Add validation constraints to views.settings Postponed but Β―\_(γ)_/Β―
- π³πΏNew Zealand quietone
Fixes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- Status changed to Needs work
5 months ago 11:45pm 17 July 2024 - πΊπΈUnited States smustgrave
Don't have an answer for #7 but can MR be updated to 11.x vs 11.0.x please.
- Merge request !8824#3460063 - Views display extenders should only save enabled extenders β (Open) created by scott_euser
- π¬π§United Kingdom scott_euser
scott_euser β changed the visibility of the branch 3460063-views-display-extenders-filter to hidden.
- Status changed to Needs review
5 months ago 4:49pm 18 July 2024 - π¬π§United Kingdom scott_euser
- Updated to 11.x
- Added updated hook + addressed feedback from #7
Thanks!
- Status changed to RTBC
5 months ago 2:32pm 22 July 2024 - πΊπΈUnited States smustgrave
Added 1 super nitpicky void return directly.
Does appear #7 has been addressed and pipeline is green
Code wise use of array_filter makes sense and doesn't seem to cause any issue.
- π¬π§United Kingdom longwave UK
Note that π views.settings config object should not be used to cache list of available plugins Active proposes removing this config entirely, is effort better spent over there?
- Status changed to Closed: duplicate
4 months ago 2:04am 18 August 2024 - π¬π§United Kingdom catch
Agreed with #14, normally hesitant to mark an RTBC issue duplicate of one that's needs work, but given this includes an upgrade path and that issue will also need one, better to have one update to maintain than two.