- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Actually, #2164373 is getting impractically broad. Let's keep this for coordinating for config entity types.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This blocks #2300677 — see #2300677-258: [PP-2] POST/PATCH config entities via REST for config entity types that support validation → .
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Great news!
Per #3324984-35: Create test that reports % of config entity types (and config schema types) that is validatable → ,
system.menu.*
andshortcut.set.*
are done!They look like this:
system.menu.*: type: config_entity label: 'Menu' mapping: id: type: machine_name label: 'ID' # Menu IDs are specifically limited to 32 characters, and allow dashes but not # underscores. # @see \Drupal\menu_ui\MenuForm::form() constraints: Regex: pattern: '/^[a-z0-9-]+$/' message: "The %value machine name is not valid." Length: max: 32 label: type: required_label label: 'Label' description: type: label label: 'Menu description' locked: type: boolean label: ''
and:
shortcut.set.*: type: config_entity label: 'Shortcut settings' mapping: id: type: machine_name label: 'ID' # Shortcut set IDs are specifically limited to 23 characters, and allow # dashes but not underscores. # @see \Drupal\shortcut\ShortcutSetForm::form() constraints: Regex: pattern: '/^[a-z0-9-]+$/' message: "The %value machine name is not valid." Length: max: 23 label: type: required_label label: 'Label'
They are very simple config entity types for sure, but … hey, we've got to start somewhere! 😊
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
RDF is removed. Test-only config entity types do not necessarily need this IMHO. Let's tighten the scope to config entity types that are actually used in this meta.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Forgot that
BlockContentType
also landed! - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I got 📌 Add config validation for workflow entities. Active started too — now 100% of the issues listed in the issue summary have an in-progress MR, some RTBC, some nearly, some with still a long way to go.
Progress! 😊
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 Allow vocabularies to be validated via the API, not just during form submissions RTBC landed! 🚢
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
✨ [PP-1] Mark parts of CKEditor 5 and Editor config schema as fully validatable Postponed landed!
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 Make Block config entities fully validatable Fixed is moving forward — probably one of the most important config entity types to make validatable because most sites have a fairly large number of these.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
The list has gotten shorter thanks to 📌 Remove Tour module Postponed 🤓
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Cleaned up, and now with detailed statistics:
Total: 7/28=25%
Standard: 7/23=30%(just like the sibling issue 🌱 [meta] Add constraints to all simple configuration Active )
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
3 more config entity types are now fully validatable! 🚀
- 🇺🇸United States phenaproxima Massachusetts
📌 Make Block config entities fully validatable Fixed is in!
- 🇺🇸United States phenaproxima Massachusetts
📌 Add validation constraints to language.content_settings.*.* Needs work landed!
- 🇳🇱Netherlands bbrala Netherlands
When working on ✨ [PP-2] POST/PATCH config entities via REST for config entity types that support validation Needs work i did notice after actually enabling tests for all validatable config entities, that although
system.action.*
is validated, the plugins aren't. So when testing, usinguser_unblock_user_action
it errors on that fact.Not sure if would have marked action as validatable when the configuration you might be able to put in there (from core) is not.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Well, system.action.* is fully validatable, but you are right that the plugins aren't.
Depending on the metric you use, all the config in core is at around 42% validatability. https://project.pages.drupalcode.org/config_inspector/So, if we would have to keep all the plugins in mind as well, I think we would probably have to remove even more of the checkmarks from this list. I don't think we have open issues for all the plugins, but I guess we can create those issues to make the plugin validatable again.
- 🇳🇱Netherlands bbrala Netherlands