Allow vocabularies to be validated via the API, not just during form submissions

I think tests will now pass. But we'll still need an update path test + actual update path logic.

There's nothing to update in VocabularyForm — there's zero validation in \Drupal\taxonomy\VocabularyForm::validateForm(). Besides, ✨ [PP-2] Introduce ConfigEntityForm to standardize use of validation constraints for config entities Active will introduce the necessary infrastructure to make that simple and consistent.

RE ::validateForm() being empty — @effulgentsia's #14 is relevant here:

A bit more info:

• VocabularyForm::form() invokes protectBundleIdElement(), and that is also validated at the API level via ConfigEntityBundleBase::preSave().
• VocabularyForm::form() sets the #maxlength of 'name' to 255, but I don't think anything validates that at the API level. I bet we have a similar lack of length validation for many configuration values throughout all of Drupal, but I don't know to what extent that's really a problem.

The first bullet was covered by 📌 Add new `ImmutableProperties` constraint Fixed and solved this generically, for all config entity types 👍

The second bullet talks about the maximum length for the human-readable label for the vocabulary. That uses type: label which gained validation constraints in 📌 Add validation constraint to `type: label`: disallow multiple lines Fixed and was refined in 📌 Add validation constraint to `type: label` + `type: text`: disallow control characters Fixed . There is no technical limit to config entity labels at this time.

But there are things that need to be validated, as this issue's MR and VocabularyValidationTest's inherited test coverage shows.

So: consider @xjm's question in #11 addressed.

Green! Marking for update path.

Update path test added; should fail. CR created: https://www.drupal.org/node/3421927 → .

Update path test failed — just pushed the missing update path to make tests green 🥳

Left some small comments.

exciting to see this after soo many years!

I studied the MR and it seems mostly great, I found only one small remark (see above)

Thanks for the reviews, both of you!

Feedback appears to be addressed.

Should drop a comment on 📌 Deprecate vocabulary weight property Needs work to make sure that todo gets removed.

@smustgrave: done: #3008064-30: Deprecate vocabulary weight property → 👍

One comment on the MR.

I'm not convinced we should do 📌 Deprecate vocabulary weight property Needs work and now this has landed that issue should be responsible for deprecations, so think we could just remove the @todo here.

#47: 👍 closed that issue and re-activated its sibling to get it back on track: #1821274-20: Add back ability to sort on vocabulary weight and name → .

Given that the feedback was trivial to address, self-re-RTBC'ing

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

🥳

• Published CR: https://www.drupal.org/node/3421927 →
• Updated meta: #2869792-54: [meta] Add constraints to all config entity types →

quietone → closed merge request !6642

Automatically closed - issue fixed for 2 weeks with no activity.