Deprecate vocabulary weight property

Hi everybody!
I have the problem because the same case as @mattjones86 here. Filters order.

Filed CR https://www.drupal.org/node/3347694 →

Will this need a deprecation test?

The last submitted patch, 21: 3008064-21.patch, failed testing. View results →

I still think we can deprecate it

Maybe we need UX team as well

Probably we still need to solve sorting of filters via #1821274: Add back ability to sort on vocabulary weight and name → but second related could be closed - no reason to extend interface

I still think you're going to be unpleasantly surprised how many developers were quietly using this without ever stumbling across this issue or having any input on the discussion.

For me personally (a single isolated developer), this will probably be adding £1000 to the next core upgrade to cover developing a custom solution to replace what was previously a core feature.

Hopefully someone will just re-implement this in contrib quickly.

Stumbled across a related feature request: #3107650: Unable to sort by term weight for contextual filter: term Name →

Note that 📌 Deprecate vocabulary weight property Needs work is marking this fully validatable, and is adding the following changes wrt weight's config schema:

     weight:
+      # @todo Deprecate in https://www.drupal.org/project/drupal/issues/3008064
       type: integer
       label: 'Weight'
+      # A weight can be any integer, positive or negative.
+      constraints:
+        NotNull: []

👆 That amounts to no changes at all: it just means that any integer is accepted. It also means that it should remain trivial for this issue to deprecate weight 👍

#29: that @todo should be converted to a follow-up issue that will remove it if 📌 Allow vocabularies to be validated via the API, not just during form submissions RTBC lands first.

I'm not convinced this is worth removing and lean towards doing #1821274: Add back ability to sort on vocabulary weight and name → instead. The big difference between taxonomy vocabularies and content types is they're much more often exposed or combined into a single list etc.

That means we should mark this and leave a comment on #1821274: Add back ability to sort on vocabulary weight and name → . #2, #8 and others indeed suggest this is actively being used.

Done.