#clean-up

This not being done yet is continuing to cause communication confusion — see #3541034-3: Render component instance form for template → .

@neerajsingh — do you think you could address this feedback? 😇🙏 I'd love to merge this MR!

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

This is going to block 🌱 [META] Content templates Active , and 📌 Move `PropSourceEndpointTest` into new `XbConfigEntityHttpApiTest::testComponent()` Active made it very apparent 😅

Quoting \Drupal\Tests\experience_builder\Functional\ApiUiContentTemplateControllersTest::testSuggestionsClientErrors():

   *           ["node/article/js.xb_test_code_components_with_link_prop", 400, "Code components are not supported yet."]
   *           ["node/article/js.xb_test_code_components_with_no_props", 400, "Code components are not supported yet."]

So, starting point:

diff --git a/src/Controller/ApiUiContentTemplateControllers.php b/src/Controller/ApiUiContentTemplateControllers.php
index 85bcf22f9..3f3909582 100644
--- a/src/Controller/ApiUiContentTemplateControllers.php
+++ b/src/Controller/ApiUiContentTemplateControllers.php
@@ -112,11 +112,6 @@ final class ApiUiContentTemplateControllers extends ApiControllerBase {
       throw new BadRequestHttpException('Only components that define their inputs using JSON Schema and use fields to populate their inputs are currently supported.');
     }
 
-    // @todo Add support for suggestions for code components in https://www.drupal.org/i/3503038
-    if (!$source instanceof SingleDirectoryComponent) {
-      throw new BadRequestHttpException('Code components are not supported yet.');
-    }
-
     if ($this->entityTypeManager->getDefinition($content_entity_type_id, FALSE) === NULL) {
       throw new NotFoundHttpException(sprintf("The `%s` content entity type does not exist.", $content_entity_type_id));
     }

The very last obstacle is supremely silly:

FILE: tests/src/Functional/ApiUiContentTemplateControllersTest.php
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
 20 | ERROR | [x] Doc comment star missing (Drupal.Commenting.DocCommentStar.StarMissing)

… but that all is there and it DOES comply! 🙃

Just removing the comment, don't want this to be held up by that — created supported request upstream: 💬 False `Drupal.Commenting.DocCommentStar.StarMissing` report? Active .

Thanks to @hooroomoo's test of this together with their PoC, I can now land this with confidence 🥳

Out of scope:

1. making these API responses cacheable — if the need ever arises, we'll do that then
2. code component support is out of scope — we have had 📌 [PP-1] Refactor GeneratedFieldExplicitInputUxComponentSourceBase and FieldForComponentSuggester to need only SDC's ComponentMetadata, not SDC plugin instances Postponed for >6 months now to do exactly that
3. fixing a shape matching bug that the test coverage I added unearthed: 🐛 Shape matching of an optional SDC image prop fails to find optional field instances Active .
4. while updating the OpenAPI spec, I noticed that for all 4xx responses, the generated docs say
   

   {
     "errors": [
       {}
     ]
   }
   

   is an example value. Which makes no sense, because it should be something like

   {
     "errors": [
       "The 'bla bla' permission is required."
     ]
   }

   But … this is using the ClientErrorResponse already in HEAD, which clearly is wrong for many (not all, but many) routes 😅 It's somewhat right for validation errors for data sent in various API request bodies, but it's wrong for (most?) other cases.

   Created 🐛 OpenAPI spec's `ClientErrorResponse` etc are incorrect for most API routes Active for this.

NW per MR review. Tests failures are legit + eslint.

Renamed the form 'ComponentInputsForm' to 'ComponentInstanceForm'. Marking this issue as NR.

I won’t have time to finish this MR today — there’s still a bunch of loose ends to clean up, but it works.

@hooroomoo, please test, and confirm that this is what you want/need! 🙏 😇

You'll get something like:

wim leers → credited hooroomoo → .

Perfect, I have everything I need now to finish this up :)