- Issue created by @wim leers
- First commit to issue fork.
- Merge request !1444Issue #3541131 by wim leers, neerajsingh: Rename `ComponentInputsForm` to... → (Merged) created by neerajsingh
- 🇮🇳India neerajsingh IN 🇮🇳
Renamed the form 'ComponentInputsForm' to 'ComponentInstanceForm'. Marking this issue as NR.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
NW per MR review. Tests failures are legit + eslint.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@neerajsingh — do you think you could address this feedback? 😇🙏 I'd love to merge this MR!
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This not being done yet is continuing to cause communication confusion — see #3541034-3: Render component instance form for template → .
- 🇮🇳India neerajsingh IN 🇮🇳
Thank you @penyaskito, @wim-leers for your validation and guidance. I have addressed the feedbacks.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Thanks! 🙏 You did all the hard work — I only had to do some touch-ups 😊
Much appreciated!
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Some of the seemingly unrelated Playwright failures here are also happening on other MRs: https://git.drupalcode.org/project/experience_builder/-/pipelines/578215 — but there seem to be more here. That is brand new test coverage since last night, so asking those who worked on it to check: #3539554-13: Add Playwright tests for XB AI module → 🤞
-
wim leers →
committed 4987d5cd on 1.x authored by
neerajsingh →
Issue #3541131 by wim leers, neerajsingh, penyaskito: DX: Rename `...
-
wim leers →
committed 4987d5cd on 1.x authored by
neerajsingh →
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Thanks for helping making XB more consistent :)
Automatically closed - issue fixed for 2 weeks with no activity.