Contrib.social

Remove support code from InstallerController that is only used by tests

Open on Drupal.org →
Created on 10 February 2025, 3 months ago

Problem/Motivation

\Drupal\project_browser\Controller\InstallerController::require() has some code that is tightly coupled to project_browser_test_mock calling an isSafeProject() method that only exists on that one source.

This is totally pointless - that method is only ever exercised by test code. So what exactly is the purpose of this? Let's remove it until we actually have a real safety check that needs real testing.

📌 Task
Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Merge request !719Take out the trash → (Merged) created by phenaproxima
  • Pipeline finished with Failed
    3 months ago
    Total: 518s
    #420246
  • Comment 3 months ago →
    🇺🇸United States phenaproxima Massachusetts
  • Pipeline finished with Canceled
    3 months ago
    Total: 269s
    #420250
  • Pipeline finished with Success
    3 months ago
    Total: 357s
    #420252
  • Pipeline finished with Success
    3 months ago
    Total: 461s
    #420385
  • Pipeline finished with Success
    3 months ago
    Total: 351s
    #421059
  • First commit to issue fork.
  • Pipeline finished with Failed
    3 months ago
    Total: 328s
    #421081
  • Pipeline finished with Success
    3 months ago
    Total: 352s
    #421086
  • Pipeline finished with Skipped
    3 months ago
    #421092
  • Comment 3 months ago →
    System Message
  • Comment 3 months ago →
    🇺🇸United States chrisfromredfin Portland, Maine

    scissors.gif

  • Comment 2 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    2 months ago
    Total: 1439s
    #434852
  • Pipeline finished with Canceled
    2 months ago
    Total: 65s
    #435731
  • Pipeline finished with Failed
    2 months ago
    Total: 1383s
    #435732
  • Pipeline finished with Failed
    2 months ago
    Total: 1362s
    #435759
  • Pipeline finished with Failed
    2 months ago
    Total: 1173s
    #435788
  • Pipeline finished with Failed
    2 months ago
    Total: 381s
    #435812
  • Pipeline finished with Success
    2 months ago
    Total: 1380s
    #435817
  • Pipeline finished with Skipped
    2 months ago
    #435853
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024