πŸ‡ΊπŸ‡¦Ukraine @BR0kEN

Dnipro
Account created on 24 January 2014, about 11 years ago
#

Recent comments

πŸ‡ΊπŸ‡¦Ukraine BR0kEN Dnipro
  1. +++ b/core/lib/Drupal/Core/Logger/LoggerChannel.php
    @@ -79,6 +80,11 @@ class LoggerChannel implements LoggerChannelInterface {
       /**
    

    Missing the documentation of the property.

  2. +++ b/core/lib/Drupal/Core/Logger/LoggerChannel.php
    @@ -79,6 +80,11 @@ class LoggerChannel implements LoggerChannelInterface {
    +   * @var array
    

    Better to change to `string[]`.

  3. +++ b/core/lib/Drupal/Core/Logger/LoggerChannel.php
    @@ -79,6 +80,11 @@ class LoggerChannel implements LoggerChannelInterface {
    +  protected $log_filter = [];
    

    Should be `$logFilters` I believe.

  4. +++ b/core/lib/Drupal/Core/Logger/LoggerChannel.php
    @@ -133,7 +148,22 @@ public function log($level, $message, array $context = []) {
    +        if ($setting_channel == $this->channel &&
    

    Put the condition per line.

  5. +++ b/core/lib/Drupal/Core/Logger/LoggerChannel.php
    @@ -133,7 +148,22 @@ public function log($level, $message, array $context = []) {
    +          $suppressed = TRUE;
    

    Shouldn't we have `break` or even `return` here?

Production build 0.71.5 2024