Remove pointless asset library dependencies/overrides on `core/once`

wim leers → credited f.mazeikis → .

Turns out @mglaman's

    // Verify `xb_test_page_xb_page_view` output was ignored, but attachments
    // were allowed.
    self::assertArrayHasKey('xb_test_page', $this->drupalSettings);
    self::assertEquals(['foo' => 'Bar'], $this->drupalSettings['xb_test_page']);
    self::assertStringNotContainsString('xb_test_page_xb_page_view markup', $this->getRawContent());

in \Drupal\Tests\experience_builder\Kernel\Entity\PageViewBuilderTest::testView() was relying on this 😬

@mglaman: can you please refactor that test to not rely on the presence of drupalSettings? 🙏 If need be, add an additional SDC that explicitly depends on drupalSettings to allow the test to continue to use that testing pattern.

I'm slightly confused since the XB controller specifies drupalSettings in its render array. I don't get why removing the library definitions would break the test...

Unless in Kernel test the automatic addition of the library doesn't happen like in a fully bootstrapped system? I'll dig in.

Ugh, I looked too fast:

    self::assertArrayHasKey('xb_test_page', $this->drupalSettings);

This is from the test module hook xb_test_page_xb_page_view:

function xb_test_page_xb_page_view(array &$build): void {
  $build['#attached']['drupalSettings']['xb_test_page'] = [
    'foo' => 'Bar',
  ];

It's to verify \Drupal\experience_builder\Entity\PageViewBuilder::alterBuild. The hook needs to specify the library I guess.

now f.mazeikis can review :) https://git.drupalcode.org/project/experience_builder/-/merge_requests/4... should fix it

Thanks, @mglaman & @f.mazeikis!

Only the phpstan CI job is failing, but it's failing on 0.x in the same way due to upstream changes in Drupal core 11.1.x.

Merged!

Automatically closed - issue fixed for 2 weeks with no activity.