- Issue created by @kim.pepper
- 🇬🇧United Kingdom longwave UK
Personally I think this is the wrong fix and the error is in jsonapi.services.yml; I don't see how the priority of
jsonapi.resource_response_validator.subscriberhas any effect. - Status changed to Active
9 months ago 5:08pm 17 February 2024 - Status changed to Needs work
9 months ago 10:27pm 17 February 2024 - 🇬🇧United Kingdom longwave UK
If this passes then this issue needs rescoping as we can simply enable autoconfiguration in JSON:API. RegisterEventSubscribersPass doesn't look at the
priorityof the tag at all. - Status changed to Needs review
9 months ago 11:22pm 17 February 2024 - Status changed to RTBC
9 months ago 11:13pm 18 February 2024 - 🇺🇸United States smustgrave
Verified all { name: event_subscriber } have been replaced in the jsonapi.services file.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Yeah, I think if the priority isn't actually used,and tests pass without it then we are good. RTBC+1
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I thought this was about
jsonapi.settingsor something 😇 Changed title.Nice simplification/clean-up! 😄
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 6c9abc44c4 to 11.x and 9fa4a048e5 to 10.3.x. Thanks!
-
alexpott →
committed 9fa4a048 on 10.3.x
Issue #3401993 by longwave: Enable services autoconfiguration for JSON:...
-
alexpott →
committed 9fa4a048 on 10.3.x
- Status changed to Fixed
9 months ago 10:41am 3 March 2024 -
alexpott →
committed 6c9abc44 on 11.x
Issue #3401993 by longwave: Enable services autoconfiguration for JSON:...
-
alexpott →
committed 6c9abc44 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.
