Add default autoconfigure to all *.services.yml and remove event_subscriber tags

Seems simple enough and didn't break anything.

This issue could be scoped more widely. There are 90 services manually tagged with event_subscriber in core and we could try to enable autoconfiguration across them all in one go (given core.services.yml is already enabled). Opening an issue for each module will be much more time consuming.

No worries! Added for the rest of the services yamls.

Currently \Drupal\KernelTests\Core\DependencyInjection\AutoconfigurationTest checks if autoconfiguration is enabled then fails if the 'event_subscriber' tag exists on a service definition.

However, `jsonapi.resource_response_validator.subscriber` sets a priority and therefore needs to set the 'event_subscriber' tag explicitly.

I have excluded jsonapi.services.yml for this reason, but we should update the test to ignore the tag when a priority is set in a followup.

Created follow-up 📌 [PP-1] AutoconfigurationTest should allow 'event_subscriber' tags if a priority is set Postponed

I wonder why priority is set in the services.yml, I thought generally that was done in the getSubscribedEvents() method?

#10 @longwave should we address that in the follow-up?

    tags:
      - { name: event_subscriber }

Search for the above snippet and only found 5 instances in the json file, which I see is noted for excluding.

Should this be tagged for needs followup

re: #12 as noted in #8the follow-up has been created here 📌 [PP-1] AutoconfigurationTest should allow 'event_subscriber' tags if a priority is set Postponed

I'm triaging RTBC issues → . I read the IS and the comments and glanced at the MR. I didn't find any unanswered questions or other work to do. I do see that a followup has been made for the case about json and priority.

Leaving at RTBC.

MR needs rebasing.

Rebased

New test failure:

Service 'user_last_access_subscriber' in core/modules/user/user.services.yml should not be tagged with 'event_subscriber'.

My mistake fixed

Committed 9b73314 and pushed to 11.x. Thanks!

longwave → closed merge request !5401

Automatically closed - issue fixed for 2 weeks with no activity.