Enable service autoconfiguration for core event subscribers

It turns out this seems almost trivial to implement; the attached patch allows autoconfiguration and enables it for event subscribers and cache contexts, and then implements it in core.services.yml.

Nice idea but needs to fix cspell Unknown word (autoconfigure)

+++ b/core/core.services.yml
@@ -60,27 +60,21 @@ parameters:
+  _defaults:
+    autoconfigure: true

how that may affect contrib?

_defaults only affects the file it is used in, so this makes no change for contrib or any core module, only core services.

To improve DX further we could decide to enable autoconfiguration by default for all modules, as all it does is automatically tag services that implement a specific interface, but that change would probably need to be made in a major release.

This has uncovered some bugs: a number of cache contexts do not implement CacheContextInterface or CalculatedCacheContextInterface. So, let's just implement this for event subscribers for now.

a number of cache contexts do not implement CacheContextInterface or CalculatedCacheContextInterface

curious why that working, because tagged services has no check for interface?

Yeah, there is no interface check - tagged services are collected and they work because the methods exist, but no type checking is done.

The last submitted patch, 12: 3221128-12.patch, failed testing. View results →

As it applies to only one file is there a way to add test to make sure that that subscribers has no such tag-name?
For example to prevent old patches to apply

Added test coverage, which found a service in core.services.yml that I missed. I think this is OK for now and we could autoconfigure core modules and enable autoconfiguration for other tags in a followup?

Change record: https://www.drupal.org/node/3357408 →

Opened 📌 Enable autoconfiguration for other service tags Active for the follow up.

No longer applies cleanly

Fine to self RTBC after reroll

MR has been rebased.

Moving back to RTBC

Tagging reviewers, those who created follow-ups and the original reporter

Committed to 11.x (nee 10.2.x) and published the change record, nice one!

larowlan → closed merge request !3899

Automatically closed - issue fixed for 2 weeks with no activity.