- Issue created by @wim leers
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This will eventually end up unblocking 📌 [PoC] Introduce a `ContentTypeTemplate` config entity Active , because for that (and for performance reasons) we'll need to do that 3rd bullet point.
- First commit to issue fork.
- Merge request !1002Issue #3523446: Rename `FieldForComponentSuggester` to `StructuredDataSourceSuggester` → (Open) created by JatinGupta40
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Thanks, @jatingupta40! Not passing tests yet, but a great start!
- 🇮🇳India sandip
I think there is still some unrelated changes are there i am working on it.
- 🇮🇳India sandip
@JatinGupta40, you reverted all of my changes and brings back all your previous unrelated changes. Why?
Now again phpcs and phpstan pipeline is failing. - 🇮🇳India sandip
@jatinGupta40, Can you please confirm is there any reason that you reverted my changes?
I fixed all your unrelated changes that was causing phpcs pipeline to fail and also made more changes that are needed for this issue queue.
Can you please kindly share your input here - 🇮🇳India JatinGupta40
@sandip Yes, i am working on it to get your changes back, basically i just rebased and resolved the conflicts yesterday but somehow it removed your changes.
- 🇮🇳India JatinGupta40
@sandip
We dont have to remove the inheritdoc.
And as per phpcs, it is not suggested to add a sentence more than 80 words in a single line.
Phpcs will give this error - the line should not exceed 80 characters. So it will be better to divide it into 2 seperate lines.I have reverted back all your suitable changes, pleasecheck and add if i missed something.
Thanks. - 🇮🇳India sandip
We dont have to remove the inheritdoc.
And as per phpcs, it is not suggested to add a sentence more than 80 words in a single line.
Phpcs will give this error - the line should not exceed 80 characters. So it will be better to divide it into 2 seperate lines.Yes this is correct but i think those are not related to this issue. But yes we can keep it here it depends on the maintainer.
Here some unit tests are still failing if you want you can work on them. - 🇮🇳India sandip
@wim leers, there are some unit tests are still failing. I am not getting how to move forward. Can you see the MR once.