Account created on 30 August 2021, almost 4 years ago
  • Associate Engineer - Full Stack at QED42 
#

Merge Requests

More

Recent comments

🇮🇳India JatinGupta40

Hello @julio_rekwa,
It seems the branch you're using might not be aligned with the expected naming convention. Ideally, it should be something like:
git checkout 3526541-error-cannot-use However, your MR branch appears to be: issue/drupal-3526541:11.x

When I check out this branch (issue/drupal-3526541:11.x), I do see all the changes from the MR, but Git shows the state as:
HEAD detached at drupal-3526541/11.x

This typically indicates that the branch is tracking a remote ref directly without creating a local branch. Let me know if this is intentional or if we should align on a consistent branch naming and checkout approach.

Also, attaching a patch file, please check if it is resolving the pipeline issue.
2025-06-24/3526541-error-cannot-use.patch
Thanks.

🇮🇳India JatinGupta40

As per the suggestion from @marcus_johansson, i have replaced explicit docblock with {@inheritdoc} to avoid duplication, as the method is already documented in the interface.

Thanks.

🇮🇳India JatinGupta40

jatingupta40 made their first commit to this issue’s fork.

🇮🇳India JatinGupta40

Hello
I am assigning it to myself for trying to resolve the test problems thanks

🇮🇳India JatinGupta40

Hello @ptmkenny,
I’ve added dependency injection in this code to resolve pipeline failures.
The pipelines were failing earlier, and this change was necessary to fix the issue.

🇮🇳India JatinGupta40

Thanks @scott_euser for the suggestion! I also believe that suggestion #7 is a better approach — Scaling the contextual overlap proportionally ensures that even when titles are long, the chunking process remains stable and within bounds.
In addition, I’ve added a safeguard:
$contextual_min_overlap = max(1, intval($this->chunkMinOverlap * $max_contextual_content));

Updating the MR.

🇮🇳India JatinGupta40

OK, Thanks @wim-leers. Reinstalling it for now.
Just curious — do we have an estimated timeline for when beta1 will be available?

🇮🇳India JatinGupta40

I have checked and the code looks good, and nothing is breaking.

🇮🇳India JatinGupta40

There are few pipelines erros due to not using of Dependency Injection.
I will resolve them.

🇮🇳India JatinGupta40

jatingupta40 made their first commit to this issue’s fork.

🇮🇳India JatinGupta40

Hello @wmac01

I have opened an MR. This might help you resolving the issue you are facing.

Thanks.

🇮🇳India JatinGupta40

Hello @poker10,
I have updated the code as per the requirement. Now if the user having the email field empty and tries to do 'reset password', the proposed output - If %identifier is a valid account, an email will be sent with instructions to reset your password. is displayed.

User Profile -

Before -

After -

🇮🇳India JatinGupta40

I have tested this issue on the latest 11.x branch.

With the merge request applied, the TypeError no longer occurs when the subject field is disabled on a contact form. The form submits successfully, and the email is sent as expected.


Also, i have rebase the MR.

🇮🇳India JatinGupta40

The patch applied cleanly and it the dropdown is working fine.
Moving it again to In Review.

🇮🇳India JatinGupta40

I have updated the MR with some pipeline fixes, still some Functional Javascript task is failing.
Moving it to Needs Work.

🇮🇳India JatinGupta40

I have updated the code and added the test case and it is working fine, incorporating the necessary improvements.
The new test case has been designed to ensure better validation and coverage. Additionally, I leveraged AI assistance to refine and enhance the implementation. Please review and let me know if any further adjustments or validations are required.

🇮🇳India JatinGupta40

@pdureau I have opened the MR.
Also attaching the updated patch file.

🇮🇳India JatinGupta40

jatingupta40 made their first commit to this issue’s fork.

🇮🇳India JatinGupta40

Hello @cilefen
Here is the error log message -

LogicException: The database connection is not serializable. This probably means you are serializing an object that has an indirect reference to the database connection. Adjust your code so that is not necessary. Alternatively, look at DependencySerializationTrait as a temporary solution. in Drupal\Core\Database\Connection->__sleep() (line 1309 of /var/www/html/core/lib/Drupal/Core/Database/Connection.php).
🇮🇳India JatinGupta40

The MR #11 has been applied successfully and is working as expected.

After enabling all three modules — Workspace UI, Workspace, and Navigation — the site is functioning smoothly without any errors.

Attached video for reference.

🇮🇳India JatinGupta40

Totally agreed with @poker10.
There seems to be something that workspaces_ui module is passing a NULL or maybe missing to pass to navigation module that expects value for #icon.
Because when i uninstalled the navigation module. There is no error and site working fine.
Looking forward around the cause of the issue.

🇮🇳India JatinGupta40

This issue seems to be clone of https://www.drupal.org/project/custom_body_class/issues/3524819 🐛 Trying to access array offset on value of type null Active

🇮🇳India JatinGupta40

Hello,

I have tested the latest merge request, and it is working as expected.
Also, there are no console errors when enabling the "Hide or show the toolbar with shortcut (Alt + P)" button and it is working as expected for me too.

However, during testing, I observed that while the sticky toolbar functionality is working, the transition does not appear smooth. It may benefit from some refinement to improve the user experience. While scrolling upwards the toolbar sticky has some delay.

Attaching the video for reference.

🇮🇳India JatinGupta40

@mihaskep I have rebased the MR and resolved all the conflicts.

🇮🇳India JatinGupta40

I have checked this issue and the patch at #2 applied successfully and it is working absolute fine.
Created MR for the same.

Thanks.

🇮🇳India JatinGupta40

Tagging @wimleers and @penyaskito as it is tested by the community and is ready to merge.
Thanks.

🇮🇳India JatinGupta40

I have tested the MR, and the use of Dependency Injection looks good and the site seems to be working fine.
Thanks.

🇮🇳India JatinGupta40

Thanks @heyyo for the descriptive steps.
I have checked the scenario as per #5, and now i can reproduce the issue.

🇮🇳India JatinGupta40

Hello @heyyo

I attempted to replicate the issue, but as per the description everything seems to be working as expected.

Here are the steps I followed:
1. I manually disabled one of the components via /admin/appearance/component.
2. The component correctly appeared under the Disabled Components tab at /admin/appearance/component/status.
3. I cleared the cache both via Drush and through the UI at /admin/config/development/performance. The component remained disabled as expected.

However, I did notice an inconsistency:
When I disabled the component, it was correctly listed under the Disabled Components tab, but it was not removed from the Enabled Components tab. As a result, the component appeared in both tabs simultaneously, which could be misleading.

This seems to indicate a UI or rendering issue where the list of enabled components is not being updated properly after a change.

Please can you help me with more details on it.

Thanks.

🇮🇳India JatinGupta40

@sandip
We dont have to remove the inheritdoc.
And as per phpcs, it is not suggested to add a sentence more than 80 words in a single line.
Phpcs will give this error - the line should not exceed 80 characters. So it will be better to divide it into 2 seperate lines.

I have reverted back all your suitable changes, pleasecheck and add if i missed something.
Thanks.

🇮🇳India JatinGupta40

@sandip Yes, i am working on it to get your changes back, basically i just rebased and resolved the conflicts yesterday but somehow it removed your changes.

🇮🇳India JatinGupta40

Thanks @penyaskito for clarifying this so well.
Closing this ticket as it is a duplicate of - https://www.drupal.org/project/experience_builder/issues/3503087 🐛 SDC prop of `type: string` with empty string listed in its `enum` results in broken input UX Active

🇮🇳India JatinGupta40

Hello,

I have tested the MR #25 and it is working absolutely fine.
Before -

After -

Network Tab -

🇮🇳India JatinGupta40

@dydave I tried applying the patch but it didn't worked out.
I tried on Drupal v10.4.8.

🇮🇳India JatinGupta40

@penyaskito I have updated the issue summary with the Before and After changes. Please have a look.
Thanks.

🇮🇳India JatinGupta40

I also got the same error after I updated the module.
After applying this MR, the issue resolved for me.
Its a good to go MR.

Thanks.

🇮🇳India JatinGupta40

@bbrala Yes, you are right and you reproduced it correctly, that if we import it as a string, it ends up as interger, ie - 0.
But i believe it would be better if we give an error message while importing, something like - String passed, expects integer value.

🇮🇳India JatinGupta40

Hello @bbrala
Your MR looks good.
But, I have one query. Currently, in Views configuration file, if the `offset` or `items_per_page` values are provided as strings (even though they should be integers), the configuration import (cim) works fine without any errors. However, when I open the view in the UI, these values appear as 0.

Ideally, the system should throw an error during the config import itself, indicating that `offset` or `items_per_page` must be integers.

So, moving this issue to Needs Work.

Thanks.

🇮🇳India JatinGupta40

Hello @joville
Can you please share few more details like a screenshot of the issue or anything else because i am not able to reproduce this issue on my end.
Thanks.

🇮🇳India JatinGupta40

Hello @paulmckibben, as per your suggestions, i have updated the MR.
It is good to merge now.

Thanks.

🇮🇳India JatinGupta40

jatingupta40 made their first commit to this issue’s fork.

🇮🇳India JatinGupta40

Hello,
Even though I have added the video, it shows the required error.
For v4.0.0-alpha5 this issue is not coming to me but I upgraded it to v4.0.0-alpha6 and got this same error.

🇮🇳India JatinGupta40

In my case, when i upgraded my Drupal core version from 10.3 to 10.4.4 this error arises.
I tried to use the #23 patch and it worked for me.

🇮🇳India JatinGupta40

Today when i upgraded the module to 3.0.2, i got this same error.
I tried with the #2 MR, and can confirm that this MR is working fine and can be merged.

Moving it to Need Review state.

Thanks.

🇮🇳India JatinGupta40

I also upgraded the module to 1.26 version.
I tried to apply patch #7, and it didn't work.

While tested as of now, the array is in the json format instead of being PHP serialized string.
Will try to resolve and create a patch for it.

Thanks.

🇮🇳India JatinGupta40

Hello @traviscarden
I tried doing the rebase, and it is saying - `Current branch 3504819-component-names-are is up to date.`

It is good to go.

Thanks.

🇮🇳India JatinGupta40

Hello,

I attempted to reproduce this issue on my local Drupal installations, specifically versions 10.2.3 and 11.0.0.

I agree with the analysis in comment #13 that the image appears to be broken. However, I did not observe the specific issue where the image completely disappears.

Additionally, when I tried copying and pasting the image alone, it successfully got added to CKEditor 5.
I will try to look further into the issue.

Thanks

🇮🇳India JatinGupta40

#3091424: Created and rebase the MR with respect to 8.x-1.x.
Moving to Needs Review.

Production build 0.71.5 2024