๐Ÿ‡ฎ๐Ÿ‡ณIndia @JatinGupta40

Account created on 30 August 2021, over 3 years ago
  • Associate Engineer - Full Stack at QED42ย 
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

@bbrala Yes, you are right and you reproduced it correctly, that if we import it as a string, it ends up as interger, ie - 0.
But i believe it would be better if we give an error message while importing, something like - String passed, expects integer value.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Hello @bbrala
Your MR looks good.
But, I have one query. Currently, in Views configuration file, if the `offset` or `items_per_page` values are provided as strings (even though they should be integers), the configuration import (cim) works fine without any errors. However, when I open the view in the UI, these values appear as 0.

Ideally, the system should throw an error during the config import itself, indicating that `offset` or `items_per_page` must be integers.

So, moving this issue to Needs Work.

Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Hello @joville
Can you please share few more details like a screenshot of the issue or anything else because i am not able to reproduce this issue on my end.
Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

jatingupta40 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Hello @paulmckibben, as per your suggestions, i have updated the MR.
It is good to merge now.

Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

jatingupta40 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Hello,
Even though I have added the video, it shows the required error.
For v4.0.0-alpha5 this issue is not coming to me but I upgraded it to v4.0.0-alpha6 and got this same error.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

In my case, when i upgraded my Drupal core version from 10.3 to 10.4.4 this error arises.
I tried to use the #23 patch and it worked for me.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Today when i upgraded the module to 3.0.2, i got this same error.
I tried with the #2 MR, and can confirm that this MR is working fine and can be merged.

Moving it to Need Review state.

Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

I also upgraded the module to 1.26 version.
I tried to apply patch #7, and it didn't work.

While tested as of now, the array is in the json format instead of being PHP serialized string.
Will try to resolve and create a patch for it.

Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Hello @traviscarden
I tried doing the rebase, and it is saying - `Current branch 3504819-component-names-are is up to date.`

It is good to go.

Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Hello,

I attempted to reproduce this issue on my local Drupal installations, specifically versions 10.2.3 and 11.0.0.

I agree with the analysis in comment #13 that the image appears to be broken. However, I did not observe the specific issue where the image completely disappears.

Additionally, when I tried copying and pasting the image alone, it successfully got added to CKEditor 5.
I will try to look further into the issue.

Thanks

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

#3091424: Created and rebase the MR with respect to 8.x-1.x.
Moving to Needs Review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

jatingupta40 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Hello @cilefen

Using the steps mentioned in #18, I tested multiple Drupal versions to determine if the issue persists. I found that the error occurs specifically in Drupal v10.4.1 and v11.1.1.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Hello @benjifisher
I got this same issue on Drupal v10.4.1 also.

Please find the details -
OS - Ubuntu Linux
Browser - Chrome
DDEV Version - v1.24.3

Commands for installation -
- composer create-project drupal/recommended-project:11.1.1 "drupal-11.1.1"
- cd drupal-11.1.1
- Configure DDEV -
- ddev config
- project_name
- web
- drupal11
- ddev start

I have explored this issue, and my findings are that the batch processes are not getting completed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Issue #3508933: The list of components incorrectly displaying the name value is fixed.

Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

jatingupta40 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

We also experienced the same issue on our site, the #9 patch resolved the issue.
Everything else also seems to be working fine and this issue can be closed.
Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Thank you for the review and for providing the suggestions.
I have made the suggested changes. Please review. @finnsky @m4olivei

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Sure @m4olivei. Appreciate your suggestion, Will work on that.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Hello @m4olivei I have made the changes regarding the suggestion you provided. Can you please again have a look at it? Thanks

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Thank @m4olivei for the suggestions you have provided. Will definitely work on it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

Thank you for noticing this issue @ckrina. I will work on it and update the code.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

JatinGupta40 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JatinGupta40

I have reviewed #6, and it is working fine as per the proposed solution so I am moving it to RTBC.
Thanks.

Production build 0.71.5 2024