📌 | AddToAny Share Buttons | \Drupal calls should be avoided in classes, use dependency injection instead
🇮🇳India JatinGupta40
I will review this MR.
🇮🇳India JatinGupta40
Thank you for the review and for providing the suggestions.
I have made the suggested changes. Please review. @finnsky @m4olivei
🇮🇳India JatinGupta40
Sure @m4olivei. Appreciate your suggestion, Will work on that.
🇮🇳India JatinGupta40
Hello @m4olivei I have made the changes regarding the suggestion you provided. Can you please again have a look at it? Thanks
🇮🇳India JatinGupta40
Thank @m4olivei for the suggestions you have provided. Will definitely work on it.
🇮🇳India JatinGupta40
🇮🇳India JatinGupta40
Thank you for noticing this issue @ckrina. I will work on it and update the code.
🇮🇳India JatinGupta40
🇮🇳India JatinGupta40
🇮🇳India JatinGupta40
JatinGupta40 → made their first commit to this issue’s fork.
🇮🇳India JatinGupta40
🇮🇳India JatinGupta40
I have reviewed #6, and it is working fine as per the proposed solution so I am moving it to RTBC.
Thanks.
🇮🇳India JatinGupta40
🐛 | A/B Test UI | Warning: Trying to access array offset on value of type bool in Drupal\abtestui\Form\ABTestForm->buildForm() (line 195
🇮🇳India JatinGupta40
I will review this patch(#3).