Component names are double escaped

That's for this Views block: core/modules/user/config/optional/views.view.who_s_online.yml.

I'm curious if this is specific to \Drupal\experience_builder\Plugin\ExperienceBuilder\ComponentSource\BlockComponent or whether this can be reproduced for SDCs too.

This issue does not affect for SDC components.

This part of the code is causing the issue

experience_builder_block_alter() {
//
      $component = Component::create([
       //
        'label' => (string) new TranslatableMarkup('@label block', ['@label' => $definition['admin_label']]),
       //
      ]);
}

(string) new TranslatableMarkup('@label block', ['@label' => $definition['admin_label']]) returns the incorrect label for blocks

Drupal\Component\Render\FormattableMarkup::placeholderFormat always escapes the special characters in the string if the placeholder passed is '@'. This happens every time, and then the render API properly renders the special characters. But not sure why it's not happening in this case (Maybe because the rendering happens in the decoupled UI, but the label in the component listing /admin/structure/component is also double escaped). Should we use html_entity_decode here?

I did some investigation here and found that this is actually coming from the Component.php file in the normalizeForClientSide() method.

It seems to be printed from the block label itself with the encoded apostrophe so I have added the html_entity_decode here.

So this needs to undo what \Drupal\Component\Utility\Html::escape() did, interesting! 😅

This is 99% correct AFAICT, but this would make it 100%: https://git.drupalcode.org/project/experience_builder/-/merge_requests/6... — asking @longwave to confirm.

@akhil babu is correct, it is wrong in the config entity

drush cget experience_builder.component.block.views_block.who_s_online-who_s_online_block
uuid: 57867d30-4a30-4b86-af25-12cb6fa03497
langcode: en
status: true
dependencies: {  }
label: 'Who's online block' 👈️👈️👈️
id: block.views_block.who_s_online-who_s_online_block
source: block
category: 'Lists (Views)'
settings:
  plugin_id: 'views_block:who_s_online-who_s_online_block'
  default_settings:
    id: 'views_block:who_s_online-who_s_online_block'
    label: "Who's online"
    label_display: ''
    provider: views
    views_label: ''
    items_per_page: none

Closed 🐛 Block names in component list are encoded Active as a duplicate of this.

Per #10, the root cause is in experience_builder_block_alter(), where the Component config entity for eligible blocks is created.

Credited you, @akhil babu — great find! 👏

Related: 📌 Handle update and delete of Block component config entities Active and 📌 Capture all reasons why particular SDC is incompatible Active .

Doesn't need to be @longwave who does this!

f.mazeikis → made their first commit to this issue’s fork.

Merged in 0.x, resolved conflicts, implemented Wim's suggestion.

😅

👆 Rebased onto 0.x.

Hello @traviscarden
I tried doing the rebase, and it is saying - `Current branch 3504819-component-names-are is up to date.`

It is good to go.

Thanks.

@jatingupta40 Well … yes, because @traviscarden already did do that.

This still has unaddressed feedback: @larowlan's #10.

Made some changes in efforts to address https://www.drupal.org/project/experience_builder/issues/3504819#comment-15992301

I think it's totally reasonable to remove the block suffix now that ✨ Display "Dynamic Components" in top bar popover Active moved blocks to :

Updated Cypress tests, no PHP tested were affected.

Automatically closed - issue fixed for 2 weeks with no activity.