- Issue created by @rkoller
- First commit to issue fork.
- ๐ณ๐ฑNetherlands Rhezios
The error is caused by rendering disabled links which are set as build item by \Drupal\navigation\Menu\NavigationMenuLinkTree::build(). By switching from menu tree to $build['items'] we ensure that only items inside the build array are altered
Patch #5 contains a re-roll against Drupal 11.1
- ๐ฎ๐ณIndia libbna New Delhi, India
Is the work still is progress? Because I applied the patch and checked, I am still getting the error.
- ๐ธ๐ฐSlovakia poker10
According to my testing from ๐ InvalidComponentException when Workspaces UI and Navigation modules are enabled Active , the error only appears if Workspaces UI is enabled. It is not sufficient to enable just Navigation and Workspaces to trigger the error. So I am updating the title and adjusting the priority as it is pretty easy tu run into this.
- ๐ฎ๐ณIndia JatinGupta40
Totally agreed with @poker10.
There seems to be something that workspaces_ui module is passing a NULL or maybe missing to pass to navigation module that expects value for #icon.
Because when i uninstalled the navigation module. There is no error and site working fine.
Looking forward around the cause of the issue. - ๐ฌ๐งUnited Kingdom catch
This seems critical for navigation module.
- ๐ฌ๐งUnited Kingdom catch
This could use a basic integration test where we install workspaces and workspaces_ui alongside navigation module and hit a page with an admin user or something. If there is actual integration to test we could try to test that too, but that could also be a follow-up.
- First commit to issue fork.
- Merge request !12310Fix Workspaces UI integation in the Navigation module. โ (Closed) created by amateescu
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
nice thank you! I've manually tested the MR12310, and i can confirm that the WSOD is gone when I am installing workspaces and workspaces_ui. also tested step wise uninstalling. everything works fine (only noticed a color contrast issue on the confirmation dialog for switching the workspace - will check existing issues later and in case file an follow up, after it is clearly out of the scope for this issue). i'll leave the issue at needs review since i am not able to review the actual code.
- ๐ฎ๐ณIndia JatinGupta40
The MR #11 has been applied successfully and is working as expected.
After enabling all three modules โ Workspace UI, Workspace, and Navigation โ the site is functioning smoothly without any errors.
Attached video for reference.
- ๐ช๐ธSpain plopesc Valladolid
Code looks very good, tests are green and tested locally with no issues.
Marking as RTBC.
Thank you!
- ๐ฌ๐งUnited Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.2.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.