🇳🇱Netherlands @Rhezios

Tested patch #68 against version 1.0.0-alpha-20 after reroll of Patch #60 with the suggested change and works as expected!

rhezios → created an issue.

Patch #5 contains a reroll of patch #2

rhezios → made their first commit to this issue’s fork.

roderik → credited rhezios → .

I've updated the used fixture to disable the tour and help modules. The test goal is to validate the config update within the Rabbit hole module. Therefore we don't need the extra test dependencies. After that we still unable to run the necessary update hooks (within the test). This is because of the removed core hooks which are required to be able to update.

I created an additional fixture (Drupal 10.3) to support next (Drupal 11) version. The 9.5 fixtures is used by the previous and current Drupal version tests.

I'm not sure if both versions are required to solve the problem.

rhezios → made their first commit to this issue’s fork.

I've updated MR8, the commits contains changes for:

• Drop Drupal 8/9 support
• Unset anonymous and authenticated (and limit the lines changed)
• Add return type to OverrideUserMailRequiredValidator::validate() to match the parent (error mentioned in #11)

rhezios → made their first commit to this issue’s fork.

Tested with Drupal 11.0.7. Uploading files in the CKEditor resulted in an error due the deprecation of file_validation methods.
file_validate and related functions are deprecated and replaced with file.validator service and Constraint plugins →

I've updated MR11 to replace the deprecated file_validation methods.

rhezios → made their first commit to this issue’s fork.

timohuisman → credited rhezios → .

This patch contains a snapshot of MR 459

rhezios → made their first commit to this issue’s fork.

I've updated the MR to wrap the change in a setting.

rhezios → made their first commit to this issue’s fork.

This patch contains a snapshot of the current MR

rhezios → made their first commit to this issue’s fork.

Hi,

Hello. I looked at the patch and it has "'system/files" hardcoded as the base path for private files. I made a MR that should cover the private scheme as well as the public scheme.

The reason for the hardcoded string is the route for private files. Private files are served by the route "system.private_file_download" and not the path of the file itself. PrivateStream::basePath() returns "Settings::get('file_private_path')" which is not accessible over the web server.

* A local file system path where private files will be stored. This directory
* must be absolute, outside of the Drupal installation directory and not
* accessible over the web.

Rhezios → created an issue.

Rhezios → created an issue.

We are loading SAML IDP settings conditionally which may result in an invalid IDP settings. The patch adds a flag to prevent unnecessary execution of the user_presave hook and can be used as intermediate solution.