- Issue created by @Rhezios
- 🇦🇹Austria agoradesign
makes sense.. thank you! I hope that I can find time to test the patch soon.. at least the patch reads correct
Thank you for this patch. This is helpful for free orders. I have tested this and it does not work because free orders (in my case) does not have any payment state. This patch seems to work only if
+ ->condition('co.total_price__number', 0) + ->condition('cp.state', 'completed')
Thank you for the clarification. I could not apply this patch since this patch is only for version 2.x-dev. Is it possible to change this version to the latest version 2.0.1?
- 🇦🇹Austria agoradesign
Why did you use a leftJoin() @Rhezios? Leaving join() makes more sense imho
-
agoradesign →
committed 7f37ff09 on 2.x authored by
Rhezios →
Issue #3384760 by Rhezios: Free orders are considered fully paid and...
-
agoradesign →
committed 7f37ff09 on 2.x authored by
Rhezios →
- 🇦🇹Austria agoradesign
@nchin - I've committed the patch from #2
So you can try the latest dev release without patching.
Although the change is tiny and looks 100% logical and correct, I haven't actually tested the change. So I think, I'll wait with a tagged release