- Issue created by @acbramley
- Status changed to Needs review
8 months ago 5:12am 3 September 2024 - 🇦🇺Australia acbramley
After a lot of faffing about trying to get previous major to work I realised that I'm dropping D9 support here anyway so it's going to fail... This is ready for a review.
- 🇺🇸United States smustgrave
If a new branch was started could drop the deprecated modules.
- 🇦🇺Australia acbramley
@smustgrave yeah I think that's a good idea, or perhaps just 2.1.x, since we're also dropping core versions here. That'd also mean we could ditch the upgrade path tests which are failing on next major
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
@acbramley: thanks for working on it _/\_ - I was about to open it and found it in this minute 1+
- First commit to issue fork.
- 🇺🇸United States japerry KVUO
Theres no reason to drop D9.5 support yet, and I don't think we need to make a new major yet either. Also, the 2.x version is still in Alpha, so we -could- remove the sub modules that are deprecated, but I'm inclined to wait a major so people can upgrade to 2.x without causing a WSOD.
Tour was added as part of the migration fixture, which is failing in Drupal 11 tests. I don't see any place where tour is being actually used in the fixture, so I removed it.
Will wait for tests to pass, and if so will commit!
- Status changed to Needs work
7 months ago 1:13am 19 September 2024 - 🇺🇸United States japerry KVUO
Bleh, it looks like the update fixture needs to be rebuilt. It also is missing a few of the old sub-module test cases, which is probably why users are finding failures when upgrading with the sub modules being enabled.
- 🇬🇧United Kingdom darren.fisher
Can I help test this at all? If so what needs work here? Would be great to get D11 compatibility on 2.x!
- First commit to issue fork.
- 🇪🇸Spain rodrigoaguilera Barcelona
I attempted to fix the tests by adding the tour module that became a contrib module but there is more failures.
I guess the Drupal 9 fixture is trying to upgrade directly to Drupal 11 and that creates situations like the help_topics module to be uninstalled (current test failure).So probably adding the tour module was not a step in the right direction.
I feel the proper solution is to create a fixture that starts from Drupal 10, therefore dropping support for the upgrade path from Drupal 9.
People coming from rabbit hole v1 on Drupal 9 need to upgrade first to Drupal 10. - First commit to issue fork.
- 🇳🇱Netherlands Rhezios
I've updated the used fixture to disable the tour and help modules. The test goal is to validate the config update within the Rabbit hole module. Therefore we don't need the extra test dependencies. After that we still unable to run the necessary update hooks (within the test). This is because of the removed core hooks which are required to be able to update.
I created an additional fixture (Drupal 10.3) to support next (Drupal 11) version. The 9.5 fixtures is used by the previous and current Drupal version tests.
I'm not sure if both versions are required to solve the problem.
- First commit to issue fork.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Tests are happy about the latest pull request. I think this can go in.
-
japerry →
committed 10ef886d on 2.0.x authored by
acbramley →
Issue #3471713: Drupal 11 support for 2.x
-
japerry →
committed 10ef886d on 2.0.x authored by
acbramley →
- 🇦🇺Australia acbramley
https://www.drupal.org/project/rabbit_hole/releases/2.0.0-beta1 → is D11 compatible, thanks @japerry!
Automatically closed - issue fixed for 2 weeks with no activity.