🇬🇧United Kingdom @darren.fisher

Amazing!! Thank you! I wondered if I was missing something!!

Works for me after a cache rebuild and assigning new permission to user who doesn't have the 'administer site configuration' permission! Please test and let me know if it works for you?

darren.fisher → created an issue.

This is really good progress! Thank you so much for your effort on this. Any word on getting this merged?

I'm not seeing Drupal 11 support on any of the branches?
https://git.drupalcode.org/project/media_thumbnails_video/-/blob/2.x/med...
https://git.drupalcode.org/project/media_thumbnails_video/-/blob/2.0.x/m...
https://git.drupalcode.org/project/media_thumbnails_video/-/blob/2.0/med...

Any updates on getting this merged?

I'm not seeing this as fixed on a stable release or indeed even on the dev branch? Can this be reopened?

Same here. Will look into whether this can be resolved easily.

MR now applies against 11.1 but tests still failing! Tearing my hair out with this one!

Looks good to me too!!

Can we get a tagged release for D11, please? This module is one which is preventing me from upgrading a few sites to Drupal 11.

+1 for a stable release please? Can't upgrade to D11 because of this!

Any news on this? I'm trying to write a recipe for Drupal 11 that includes verf and I can't due to no upstream D11 release! I am using this module already on a Drupal 11 website via drupal-composer-lenient and the patch here and it's been absolutely fine with no issues whatsoever.

Is there going to be a 3.0.x tagged release for tablefield?

Can this be checked, merged, and released? This is one of the last modules blocking us from updating a couple of sites to D11!

Okay!! All done. All tests passing. Feel free to review!

Just spotted another addition I should make to this!!

Is this getting a tagged release soon? Confirming the fix on both Drupal 10.3 and Drupal 11.0

Thank you. I will investigate.

Pipeline passed!!

I've just seen the pipeline issues. I've made another commit that should fix it.

Branch and MR created. Test it out and let me know if this looks like a decent solution?

darren.fisher → created an issue.

Thank you. I keep meaning to come back to update this issue!! Many more Drupal articles to come as well!

darren.fisher → created an issue.

Marking fixed now as module is operating well in out D11 projects.

Will this be getting a tagged release for D11 compatibility?

This looks good to go. Tested in D11 and everything seems to be functioning as expected.

Any chance we can get this merged and into a tagged release?

This looks like a straightforward change. Tested on D11 using the MR and all looks good to me.

Is this going to get a tagged release?

Can this one be merged? Looks like a straightforward update to the info.yml and composer.json.

Merged master into branch so that MR is mergeable and patch can still be applied to 11.x.

Merged change. Setting back to active so update bot can carry on suggesting if needed!

Looks like there are related issues (I've tagged them) that will postpone this. Tested my MR against D11 but I can't even install due to dependency issues.

Pushed this along a bit. Going to test on our D11 install now.

darren.fisher → made their first commit to this issue’s fork.

Currently, I don't have any other modules. This is my first. If I create any more I'll update this issue.

darren.fisher → created an issue.

Fair enough. Thanks for giving it a review anyway.

Branch and merge request created.
https://git.drupalcode.org/project/twig_tweak/-/merge_requests/58

To test as a patch you can use:
https://git.drupalcode.org/project/twig_tweak/-/merge_requests/58.patch

Feedback welcome!

darren.fisher → created an issue.

Well done. Thank you Dan! Merged. Tagged. Released. Alongside some unit tests!

Unless I'm missing something this CSS can be removed. Branch created. MR created. Setting to needs review.

darren.fisher → created an issue.

Opened a MR that fixes this. The query selector in the JS was targeting an H4 which isn't there. I'm guessing at some point you changed H4s in the sidebar to buttons but didn't update the JS? Please review the MR and check that it's working. It is for me locally!

Opened a MR with the changes. Will require a review.

darren.fisher → created an issue.

darren.fisher → created an issue.

Please review this change and let me know if you think there might be an issue with it or perhaps a better alternative?

darren.fisher → created an issue.

I created a branch and removed the dependency. Merge request created also. If you want a quick patch to test:
https://git.drupalcode.org/project/sdc_component_library/-/merge_request...

Please can you review and determine if this creates any unwanted side effects. As the module is already stated as supporting > 10.3 || > 11.0 I think this should be fine?

darren.fisher → created an issue.

This looks ok to me.

Tested MR14 and all looks good to me!

I've tested the MR against D11 and everything looks good. Marking RTBC.

+1 for an official release. Thanks for working on this!

Removing 'Needs issue summary update' tag. Not really dived in to writing core tests before. If I find time I will try but in the meantime if anyone else wants to get stuck in please do!!

This has just caught me out during an upgrade. Is there not a plan to include the aliases with version 2?

There are a bunch of PHPUnit tests failing but I think they are unrelated to this specific change. Perhaps someone with better knowledge than me can take a look and check?

I've opened a MR for this if anyone cares to review:

https://git.drupalcode.org/project/drupal/-/merge_requests/9779

Use the MR as a patch:
https://git.drupalcode.org/project/drupal/-/merge_requests/9779.patch

I've just tested MR11 against 2.0.x-dev and can confirm this looks good. Marking as RBTC.

Just tested the latest MR as well and can confirm all working as expected for our use case!

This is great news. Thank you so much for your work on this.

I've manually tested the MR as a patch:
https://git.drupalcode.org/project/tfa/-/merge_requests/91.patch

I encountered no errors or issues for our use case using both the standard login route and the 'Tfa User login' block.

This is really helpful. Thanks. I don't know how I missed the giant green button that says "Get push access". I think I was looking in GitLab itself!! I really appreciate the pointers and now I know!

Patch #7 works for me too. Can this be merged?

Looks like the MR is out of date with upstream changes. Can the branch be rebased? Is this something I can help with? I don't seem to have commit access to the branch. Not quite sure how this works in terms of committing to someone else's branch? Happy to jump in and work on this! Also looks like the pipeline failed which needs looking in to.

Thank you for your work on this. Really appreciate it and this moves us another step forward to being able to migrate!

This looks like it is getting close. Thank you for all your hard work so far. Do you need any help with testing or any remaining tasks on this?

Would be massive for this to get a stable D11 release.

We're making a policy to move all our clients over to using this module and are looking at starting D11 site migrations in the next couple of months!

I've just tested this in Drupal 11 with the patch in #2 and all works as expected. Marking as RTBC. Hope that's ok?

Can I help test this at all? If so what needs work here? Would be great to get D11 compatibility on 2.x!

Patch in #4 works for me too and equally this is preventing an upgrade to D11 where we'd prefer this to be in a stable release. Marking RTBC. Hope that's ok?

Thank you!!

Will this be getting a stable release?

This looks pretty straightforward. Can this be merged so we can start looking at migrating sites using this module to D11?

This looks like a pretty straightforward patch. Can this be merged now Drupal 11 is out?

This looks good to me!

This looks good to me. Can this be merged so we can start preparing to migrate our sites to D11.

This looks good to me. Can this be merged so we can start preparing to migrate our sites to D11.

Will this be getting rolled into the stable release at some point?

This patch looks good to me. Can this be merged so we can look at upgrading to Drupal 11? Thanks in advance.

Thank you!!!

Just tested and looks to be working just fine!! Thank you so much again for you work on this!

Amazing. Thank you!

Hi. Thanks for all your hard work on this! Is this getting a stable release anytime soon now that Drupal 11 is out?

Is there a timeline for getting this merged? Drupal 11 is out now and we're auditing our readiness to upgrade and have a lot of websites using this module. Many thanks!

Sorry to comment again! Any update on this? Drupal 11 is out now and we're auditing our readiness to upgrade and have a lot of websites using this module.

Sorry to comment again! Any update on this? Drupal 11 is out now and we're auditing our readiness to upgrade and have a lot of websites using this module.