darren.fisher → created an issue.
Added the lorem ipsum service to this. Something I've realised is that the lorem ipsum service assumes you want sentences and add full stops to the end of each generation so I will open a separate issue to deal with this and later implement it here.
This is looking really good. I've updated the README in this branch to document this new functionality and changed the default values in MenuDataExtension.php to match what is in the README.
Next steps:
- I'm going to look at using the lorem ipsum service to generate the menu titles.
- We'll want some tests similar to the other twig functions that cover the functionality provided by this new twig function.
darren.fisher → made their first commit to this issue’s fork.
It seems this may be unrelated to the previous issue. I will roll this patch in to a merge request so it's easier to review and test in the gitlab pipelines.
Is this related to https://www.drupal.org/project/twig_tweak/issues/3427835 ✨ Add possibility to placeholder menu renders Active ?
Also the PHPStan errors are weird. They all state:
No error to ignore is reported on line XX
Here's the full error output:
------ --------------------------------------------
Line src/Command/SignatureFormatter.php
------ --------------------------------------------
47 No error to ignore is reported on line 47.
------ --------------------------------------------
------ --------------------------------------------
Line src/UriExtractor.php
------ --------------------------------------------
49 No error to ignore is reported on line 49.
83 No error to ignore is reported on line 83.
------ --------------------------------------------
------ ---------------------------------------------
Line src/UrlExtractor.php
------ ---------------------------------------------
72 No error to ignore is reported on line 72.
112 No error to ignore is reported on line 112.
------ ---------------------------------------------
------ ---------------------------------------------
Line src/View/BlockViewBuilder.php
------ ---------------------------------------------
148 No error to ignore is reported on line 148.
------ ---------------------------------------------
[ERROR] Found 6 errors
When I inspect the first one I see:
// @todo Fix this.
// @phpstan-ignore-next-line
I'm not sure why these are here? I'm sure there is some reason but it appears the PHPStan would not error on the following line anyway so maybe these can be removed? Again seems like this is probably a separate issue?
Just fixed the phpcs errors introduced by these changes. The PHPUnit failures I'm unsure of the correct approach.
Line 32 of tests/src/Kernel/Command/DebugLoadersTest.php contains the following assertion:
self::assertStringContainsString('/twig_tweak/templates/', $display);
The test is asserting that the output must contain the string:
"/twig_tweak/templates/"
But the actual output is:
"modules/custom/twig_tweak-3427835/templates/"
I'm not sure if this needs some sort of partial string check update using regex as the -3427835 relates specifically to this issue branch which means phpunit will always fail on any branch. This feels like a separate issue altogether.
What do you think?
darren.fisher → made their first commit to this issue’s fork.
Thank you @guiu.rocafort.ferrer. Any update on the release?
The maintainer for this module has been unresponsive for some time and the module is currently in limbo. I would like to be considered as a maintainer so I can ensure this module stays up to date and has a regular release schedule! Thank you for your consideration.
Bumping this. Tomorrow this issue will be escalated to the Drupal.org project ownership issue queue.
Thanks for this. Merged and fixed! Will add tests for this new functionality on the 1.0.x branch so I can test thoroughly locally and then will tag a new release!
darren.fisher → made their first commit to this issue’s fork.
I think I've cracked it. Tests now pass. I must stress though I'm pretty new to the inner workings of this module so please can this be thoroughly reviewed and tested before being merged? The logic has had to be altered a fair bit from the patch for 1.x due to large changes in the module between branches!
New MR to resolve this issue in 2.x. Please test thoroughly!!
https://git.drupalcode.org/project/nodeaccess/-/merge_requests/18
There are PHPUnit errors. I will try and get to these shortly!
Also I believe all work is now taking place on the 2.0.x branch and as it is still an issue let's start there and if needed cherry pick the change to the 1.x branch although 1.x is no longer listed as a recommended version on Drupal.org.
I'm going to roll this in to a merge request so we can test it more thoroughly.
I'm not sure if this lies within the remit of the nodeaccess module? Can you provide some more information about your request and I can investigate if this issue belongs in another queue or does indeed fall under the remit of the nodeaccess module? Thank you.
Is this the same issue as:
https://www.drupal.org/project/nodeaccess/issues/3511078
🐛
Updating from 1.x to 2.0.1@alpha purges settings and grant field data
Active
If so we should also mark one of these as closed (duplicate).
Is this the same issue as:
https://www.drupal.org/project/nodeaccess/issues/3509391
💬
Upgrade to version 2 deletes existing permissions
Active
If so we should also mark one of these as closed (duplicate).
nodeaccess.settings.yml 1.x
grants:
view: 1
edit: 1
delete: 1
priority: 0
preserve: 1
nodeaccess.settings.yml 2.x
allowed_grant_operations:
grant_view: true
grant_update: true
grant_delete: true
bundles_roles_grants: {}
grants_tab_availability: {}
map_rid_gid: {}
roles_settings: {}
There is an update hook provided in nodeaccess.install:
https://git.drupalcode.org/project/nodeaccess/-/blob/2.0.x/nodeaccess.in...
/**
* Migrates nodeaccess.settings.
*/
function nodeaccess_update_9002(&$sandbox) {
$config = \Drupal::configFactory()->getEditable('nodeaccess.settings');
// From grants to allowed_grant_operations.
$old_grants = $config->get('grants');
$config
->set('allowed_grant_operations', [
'grant_view' => (boolean) $old_grants['view'],
'grant_update' => (boolean) $old_grants['edit'],
'grant_delete' => (boolean) $old_grants['delete'],
])
->clear('grants');
// From allowed_types to grants_tab_availability.
$old_allowed_types = $config->get('allowed_types') ?? [];
$grants_tab_availability = [];
foreach ($old_allowed_types as $bundle => $value) {
$grants_tab_availability[$bundle] = (boolean) $value;
}
$config
->set('grants_tab_availability', $grants_tab_availability)
->clear('allowed_types');
// From role_map to map_rid_gid.
$old_role_map = $config->get('role_map');
$config
->set('map_rid_gid', $old_role_map)
->clear('role_map');
// From role_alias to roles_settings.
$old_role_alias = $config->get('role_alias');
$roles_settings = [];
foreach ($old_role_alias as $role_id => $value) {
$roles_settings[$role_id] = [
'display_name' => $value['alias'],
'name' => $value['name'],
'weight' => (int) $value['weight'],
'selected' => (boolean) $value['allow'],
];
}
$config
->set('roles_settings', $roles_settings)
->clear('role_alias');
$bundles = array_keys($old_allowed_types);
$bundles_roles_grants = [];
foreach ($bundles as $bundle) {
$old_bundle_settings = $config->get($bundle);
foreach ($old_bundle_settings as $role_id => $grant) {
$bundles_roles_grants[$bundle][$role_id] = [
'grant_view' => (int) $grant['grant_view'],
'grant_update' => (int) $grant['grant_update'],
'grant_delete' => (int) $grant['grant_delete'],
];
}
$config->clear($bundle);
}
$config
->set('bundles_roles_grants', $bundles_roles_grants)
->clear('priority')
->clear('preserve')
->save();
}
Did you run drush updb / drush updatedb and drush cr / drush cache:rebuild?
Please let me know and I can investigate this further if you're still having issues?
Just coming along to update this issue. 2.0.x is now the default branch and is listed on the project page. This branch has not had a tagged release in over 2 years. Ideally we will tag a new release of this branch soon so that the module is Drupal 11 compatible and includes all the other good fixes that have been merged over the past 2+ years. This will also allow us to test all the open issues in the issue queue against a tagged release which will give us a new jumping off point for cleaning up the issue queue and getting some of these issues resolved once and for all!
I believe this issue to be outdated as Drupal 7 is now officially end of life. Please feel free to correct me if I'm wrong. I'm just trying to have a cleanup of the older issues in this issue queue!
I believe this issue to be outdated as Drupal 7 is now officially end of life. Please feel free to correct me if I'm wrong. I'm just trying to have a cleanup of the older issues in this issue queue!
This change has been committed to the dev branch as part of the Drupal 11 compatibility work: https://git.drupalcode.org/project/nodeaccess/-/merge_requests/16/diffs
Please test the 2.0.x-dev branch and report back if all is working as expected. I think we need as many eyes as possible on the dev branch in order to get a new tagged release!
I am marking this issue as fixed and giving you credit as your code contribution has been included in the dev branch as a fix!
darren.fisher → created an issue.
Fixed! Will tag a new release once merge train is complete!
Closing as fixed. Will tag a new release once https://www.drupal.org/project/twig_placeholders/issues/3516429 📌 Resolve PHPStan (next minor) issues Active is resolved.
Fixed!
darren.fisher → made their first commit to this issue’s fork.
darren.fisher → created an issue.
Closing as fixed. Will tag a new release once https://www.drupal.org/project/twig_placeholders/issues/3516379 🐛 {{ tp_video() }} Rendered HTML appears as escaped text instead of Active is resolved!
Closing as fixed. Will tag a new release once https://www.drupal.org/project/twig_placeholders/issues/3516379 🐛 {{ tp_video() }} Rendered HTML appears as escaped text instead of Active is resolved!
Fixed!
Merged!
darren.fisher → created an issue.
I've updated the CSS in align.module.css to use modern logical properties. Ideally the class names would also change but that will introduce breaking changes for any themes that use the existing classes. Let me know if there's anything else that needs to happen on this?
darren.fisher → made their first commit to this issue’s fork.
As a result of trying to fix some gitlab-ci test failures I've discovered via cspell that there is a misspelling which I'd be reluctant to change:
Cspell turned up:
constact
in contact_storage.module:
$fields['message']->addConstraint('ConstactStorageMaximumSubmissions', []);
in src/Plugin/Validation/Constraint/ConstactStorageMaximumSubmissionsConstraint.php:
class ConstactStorageMaximumSubmissionsConstraint extends Constraint {
in src/Plugin/Validation/Constraint/ConstactStorageMaximumSubmissionsConstraintValidator.php:
class ConstactStorageMaximumSubmissionsConstraintValidator extends ConstraintValidator {
These should surely be ContactStorageMaximumSubmissions, ContactStorageMaximumSubmissionsConstraint, and ContactStorageMaximumSubmissionsConstraintValidator respectively?
I'm pretty sure changing these now could have side effects so I will leave these alone.
Annoyingly I've just spotted there is already a phpcs issue in the queue that likely resolves any phpcs issues I've just cleanup up in here. Apologies. My bad. Should have looked first!
The PHPUnit failure is a bit beyond me and there are still a ton of phpstan issues. Hopefully this helped and didn't muddy the waters!
darren.fisher → made their first commit to this issue’s fork.
Guess we'll close this then.
Tests fail on composer.json requiring https://www.drupal.org/project/papaparse → which does not currently support Drupal 11. See https://www.drupal.org/project/papaparse/issues/3448794 📌 Automated Drupal 11 compatibility fixes for papaparse Needs review .
I've created MR!2 which makes this module D11 compatible and adds gitlab-ci.yml to test future code changes. Any change this could get merged and get a tagged release? It would help to unblock this issue on the csv_field module: https://www.drupal.org/project/csv_field/issues/3514918 📌 Add gitlab-ci Active
darren.fisher → made their first commit to this issue’s fork.
darren.fisher → created an issue.
Here are the pipelines that are passing and failing:
https://git.drupalcode.org/issue/patreon-3514912/-/pipelines/455612
For now I've resolved the cspell issues because those were pretty easy to resolve by adding the UK dictionary and fixing a few spelling errors in comments. I've had a stab at fixing the phpunit errors by adding config schemas but these will need reviewing to ensure I've used the correct types. There are many PHPCS errors and one PHPStan error which will need to be resolved. I will come back tomorrow and look with fresh eyes! PHPUnit tests are still failing due to an incompatible schema for the min and max keys in settings. Not sure if that makes any sense to anyone here? Anyway I'll chip away some more tomorrow if I get time!!
darren.fisher → created an issue.
Hmmm interestingly the issue fork on this very issue says "Create issue fork with new branch from 2.0.x". Not sure how that's working but even so the GitLab default branch still ought to be set to 2.0.x!!
darren.fisher → created an issue.
Hello. I've just become a maintainer on this project but don't have release access. However I believe a new release is coming soon in order to make this module ready for Drupal 11. The last release was 11 February 2023 which is over two years ago and I concur it would be good to make a new tag. Fingers crossed it's coming soon. Just wanted to update you on what I know!!
That makes sense. I will review issue #3355485 as this isn't something I'd considered when it comes to recipes and will be a useful thing to be aware of when removing dependencies from other modules in the future.
Just looking at the pipeline:
https://git.drupalcode.org/issue/easy_email-3216431/-/pipelines/225568
I can see phpcs runner is passing but phpunit is failing (not allowed) and cspell, eslint, phpstan, and stylelint are also failing (allowed).
Should we clean these up in this branch or resolve these once this is merged?
That makes perfect sense. I've run into this issue several times and should have thought about it!!
All done and I've also merged the changes in the dev branch in so the MR should apply without issue!
Thank you for the prompt review!
Created my own issue here:
https://www.drupal.org/project/media_entity_link/issues/3514042
💬
Offering to co-maintain Media Entity Link
Active
darren.fisher → created an issue.
Makes sense. I am also offering. Does this mean I need to create an identical issue to this one and wait another 14 days?
Sorry I think you might have misunderstood me or perhaps I worded this badly!! I was just asking if you have a release planned at all? Didn't mean any offence!!
UPDATE: I have contacted the maintainer and moved the offer to become a co-maintainer issue to the Drupal.org project ownership issue queue:
https://www.drupal.org/project/projectownership/issues/3504411 💬 Offering to co-maintain Media Entity Link Active
Having re-read the How to become project owner, maintainer, or co-maintainer documentation at:
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
I would suggest this is a candidate to be moved to the Drupal.org project ownership issue queue now to prevent any further delay in getting this module a Drupal 11 release.
I have altered the project on this issue to get the ball rolling.
I have also contacted the maintainer on 18th March 2025.
What's the release cycle for this module? It would be nice to have this as a tagged release so I can make sure my recipes run without relying on the dev branch!
It looks like on closer inspection that we don't need javascript at all. I've resolved the resizing with css alone. Whilst I was in there I refactored the preview template and the entire css file to use modern CSS practices including logical properties and CSS custom properties so it will need some thorough testing. I also tried to standardise and clean up the spacing on the preview page. Let me know your thoughts. I'd love to do a bit of a tidy up of some of the other templates as well and set up the gitlab CI/CD runners but that feels like it's probably a separate issue to this one!
Will there be a tagged release? Looking to evaluate this module in D11!
This issue has been open longer than 14 days so I'd encourage @vladimiraus to apply for co-maintainership. If this issue isn't updated in the next 14 days I will apply instead.
Also offering my help co-maintaining in order to get a Drupal 11 release for this module.
Ahh I can see there's a few items to review there!! No worries. Glad to see it's moving in the right direction. Appreciate your review!
darren.fisher → created an issue.
Amazing. Thank you! Really appreciate it. Is there an ETA for a tagged release?
Appreciated. I will do the same. If we don't hear anything how do we go about applying for maintainership?
Are we likely to get a tagged release of this soon? Thanks in advance.
I have found the fix.
I was applying a patch from this issue:
https://www.drupal.org/project/domain_entity/issues/3405907#comment-1534...
🐛
Make module compatible with PHP 8.2
RTBC
This patch was still applying to rc5 so I didn't spot it at first and it was creating a duplicate $sourceMapper.
If anyone else runs into this issue then remove any patches from this issue and you should be good to go!!
darren.fisher → created an issue.
Oh nice. That was quick!! Thank you.
Just a heads up I didn't see it either until I cleared the cache!
I've had a stab at this:
Patch is here if you want to test: https://git.drupalcode.org/project/easy_email/-/merge_requests/40.diff
MR here to see differences in gitlab: https://git.drupalcode.org/project/easy_email/-/merge_requests/40
darren.fisher → made their first commit to this issue’s fork.
darren.fisher → created an issue.
Got all tests to pass. This is the last module we're waiting on to get one of our projects migrated to Drupal 11. Any ETA on review and merge?
Is the module maintainer still active?
All green and good to go I think. Can we get this reviewed ASAP as this is the last module holding up one of site upgrades to Drupal 11!
All green pipeline:
https://git.drupalcode.org/issue/entity_update-3430260/-/pipelines/439664
Patch for those using composer lenient:
https://git.drupalcode.org/project/entity_update/-/merge_requests/12.diff
darren.fisher → made their first commit to this issue’s fork.
Amazing. Thank you!!
It looks like 1.x is still the default branch in gitlab hence all the confusion around multiple branches and merge requests. Are you able to set the default branch to 2.0.x or 2.x? Not sure which one you want to use? See attached screenshot.
That's what I thought. When I branched in the issue it said 1.x was the default branch. I'll close the 1.x MR. If you could look at MR!10 and let me know what you think? I also added tests which are throwing a warning because the install hook in the module should be in an install file but we should probably deal with that in a separate issue. Do you agree or should I fix that here as well?
I've made a bit of a mess of this branch because it seemed to be forked from the 1.x branch and not the 2.x. Fixing now.
That's an interesting point. If that goes in to config then yes that would be sufficient. I'm trying to automate a workflow via recipes so if that ends up in the block config then yes that would work for my use case!
Fair comment. I've removed those as they were OP's request from 5 years ago but I just need the data-region additions for the project I'm working on.