Account created on 30 September 2014, over 9 years ago
  • Digital Designer at PivaleΒ 
#

Merge Requests

Recent comments

πŸ‡¬πŸ‡§United Kingdom darren.fisher

Just dropping in to confirm #28 fixes the issue! Thanks.

πŸ‡¬πŸ‡§United Kingdom darren.fisher

Thanks Osama Nuserat. I'd missed the other files as I was following error messages on my install. I'll be sure to check more thoroughly in the future. I've just tested your patch and it all looks good to me. I've updated the MR so it's easier for stomusic to merge to the dev branch.

πŸ‡¬πŸ‡§United Kingdom darren.fisher

@mali2022 are you able to test the dev branch of selective_better_exposed_filters and my patch above and see if you can install better_exposed_filters 7.0.0-beta1 in conjunction and that everything is working as expected?

πŸ‡¬πŸ‡§United Kingdom darren.fisher

Thanks! This progressed us a bit but it turns out that the DefaultWidget.php needed a few updates as well. Merge request above and patch is here:
https://git.drupalcode.org/project/selective_better_exposed_filters/-/me...

πŸ‡¬πŸ‡§United Kingdom darren.fisher

Is there anything else I can do to progress this? This issue is preventing us upgrading better exposed filters on several sites.

πŸ‡¬πŸ‡§United Kingdom darren.fisher

I think the MR contains the change needed to restore compatibility with the latest version of better_exposed_filters.

πŸ‡¬πŸ‡§United Kingdom darren.fisher

darren.fisher β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom darren.fisher

This issue is in src/UnmanagedFilesService.php on line 173 where:
$public_dir = $this->state->get('file_public_path', 'sites/default/files');
is declared. This would need to be done in a loop for all subdirectories - eg. /sites/*/files

Alternatively there could be an admin screen that allows us to specify which files directories we want to search in that then gets saved as an array variable that can be looped through in this code.

πŸ‡¬πŸ‡§United Kingdom darren.fisher

I've also just attempted to use this on a multi-site (multsite) setup and can confirm that this is still an issue. I will look at the code and see if there's a way to check all subfolders in the /sites directory.

πŸ‡¬πŸ‡§United Kingdom darren.fisher

Reverting to 5.1.12 fixed my issue for now.

πŸ‡¬πŸ‡§United Kingdom darren.fisher

Same here. Steps to reproduce. Having already created a fullcalendar_view display for a view using version 5.1.10 upgraded module to 5.1.13 and saw a console error:

Uncaught TypeError: Cannot read properties of undefined (reading 'calendar_options')
at HTMLDivElement. (fullcalendar_view.js?s29kk4:286:53)
at Function.each (jquery.min.js?v=3.6.3:2:3003)
at E.fn.init.each (jquery.min.js?v=3.6.3:2:1481)
at buildCalendars (fullcalendar_view.js?s29kk4:282:6)
at fullcalendar_view.js?s29kk4:390:7

Tried editing the view and re-saving the format display and settings but the error persists. The patch in #7 fails to apply.

πŸ‡¬πŸ‡§United Kingdom darren.fisher

Can this be merged? We're wanting to use this on a D10 site.

πŸ‡¬πŸ‡§United Kingdom darren.fisher

Patch no longer applies in Drupal 10.1

πŸ‡¬πŸ‡§United Kingdom darren.fisher

Also experiencing this issue with Drupal 10, PHP 8.2. Thumbnails are not generating and trying to visit the refresh UI results in:

The website encountered an unexpected error. Please try again later.

Drupal\Core\Entity\Query\QueryException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck(). in Drupal\Core\Entity\Query\Sql\Query->prepare() (line 141 of core/lib/Drupal/Core/Entity/Query/Sql/Query.php).
Drupal\Core\Entity\Query\Sql\QueryAggregate->prepare() (Line: 25)
Drupal\Core\Entity\Query\Sql\QueryAggregate->execute() (Line: 54)
Drupal\media_thumbnails\Batch\RefreshBatch::count() (Line: 33)
Drupal\media_thumbnails\Form\MediaThumbnailRefreshForm->getDescription() (Line: 45)
Drupal\Core\Form\ConfirmFormBase->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 534)
Drupal\Core\Form\FormBuilder->retrieveForm('media_thumbnails_refresh_form', Object) (Line: 281)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 163)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 686)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
πŸ‡¬πŸ‡§United Kingdom darren.fisher

I was having this issue and the patch in #14 https://www.drupal.org/project/smart_date/issues/3335564#comment-14948369 πŸ› No other token format available or accepted besides the default one Fixed fixes it for me. Thank you!!

πŸ‡¬πŸ‡§United Kingdom darren.fisher

The issue does not occur in module version 5.1.9 so for now you can roll back to that in your composer.json until there is progress on this issue.

πŸ‡¬πŸ‡§United Kingdom darren.fisher

I am also seeing this issue when using the next and previous month arrows.

Production build 0.69.0 2024