Merged master into branch so that MR is mergeable and patch can still be applied to 11.x.
Merged change. Setting back to active so update bot can carry on suggesting if needed!
Looks like there are related issues (I've tagged them) that will postpone this. Tested my MR against D11 but I can't even install due to dependency issues.
Pushed this along a bit. Going to test on our D11 install now.
darren.fisher → made their first commit to this issue’s fork.
Currently, I don't have any other modules. This is my first. If I create any more I'll update this issue.
darren.fisher → created an issue.
Fair enough. Thanks for giving it a review anyway.
Branch and merge request created.
https://git.drupalcode.org/project/twig_tweak/-/merge_requests/58
To test as a patch you can use:
https://git.drupalcode.org/project/twig_tweak/-/merge_requests/58.patch
Feedback welcome!
darren.fisher → created an issue.
Well done. Thank you Dan! Merged. Tagged. Released. Alongside some unit tests!
Unless I'm missing something this CSS can be removed. Branch created. MR created. Setting to needs review.
darren.fisher → created an issue.
Opened a MR that fixes this. The query selector in the JS was targeting an H4 which isn't there. I'm guessing at some point you changed H4s in the sidebar to buttons but didn't update the JS? Please review the MR and check that it's working. It is for me locally!
Opened a MR with the changes. Will require a review.
darren.fisher → created an issue.
darren.fisher → created an issue.
Please review this change and let me know if you think there might be an issue with it or perhaps a better alternative?
darren.fisher → created an issue.
I created a branch and removed the dependency. Merge request created also. If you want a quick patch to test:
https://git.drupalcode.org/project/sdc_component_library/-/merge_request...
Please can you review and determine if this creates any unwanted side effects. As the module is already stated as supporting > 10.3 || > 11.0 I think this should be fine?
darren.fisher → created an issue.
This looks ok to me.
Tested MR14 and all looks good to me!
I've tested the MR against D11 and everything looks good. Marking RTBC.
+1 for an official release. Thanks for working on this!
Removing 'Needs issue summary update' tag. Not really dived in to writing core tests before. If I find time I will try but in the meantime if anyone else wants to get stuck in please do!!
This has just caught me out during an upgrade. Is there not a plan to include the aliases with version 2?
There are a bunch of PHPUnit tests failing but I think they are unrelated to this specific change. Perhaps someone with better knowledge than me can take a look and check?
I've opened a MR for this if anyone cares to review:
https://git.drupalcode.org/project/drupal/-/merge_requests/9779
Use the MR as a patch:
https://git.drupalcode.org/project/drupal/-/merge_requests/9779.patch
I've just tested MR11 against 2.0.x-dev and can confirm this looks good. Marking as RBTC.
Just tested the latest MR as well and can confirm all working as expected for our use case!
This is great news. Thank you so much for your work on this.
I've manually tested the MR as a patch:
https://git.drupalcode.org/project/tfa/-/merge_requests/91.patch
I encountered no errors or issues for our use case using both the standard login route and the 'Tfa User login' block.
This is really helpful. Thanks. I don't know how I missed the giant green button that says "Get push access". I think I was looking in GitLab itself!! I really appreciate the pointers and now I know!
Patch #7 works for me too. Can this be merged?
Looks like the MR is out of date with upstream changes. Can the branch be rebased? Is this something I can help with? I don't seem to have commit access to the branch. Not quite sure how this works in terms of committing to someone else's branch? Happy to jump in and work on this! Also looks like the pipeline failed which needs looking in to.
Thank you for your work on this. Really appreciate it and this moves us another step forward to being able to migrate!
This looks like it is getting close. Thank you for all your hard work so far. Do you need any help with testing or any remaining tasks on this?
Would be massive for this to get a stable D11 release.
We're making a policy to move all our clients over to using this module and are looking at starting D11 site migrations in the next couple of months!
I've just tested this in Drupal 11 with the patch in #2 and all works as expected. Marking as RTBC. Hope that's ok?
Can I help test this at all? If so what needs work here? Would be great to get D11 compatibility on 2.x!
Patch in #4 works for me too and equally this is preventing an upgrade to D11 where we'd prefer this to be in a stable release. Marking RTBC. Hope that's ok?
Thank you!!
Will this be getting a stable release?
This looks pretty straightforward. Can this be merged so we can start looking at migrating sites using this module to D11?
This looks like a pretty straightforward patch. Can this be merged now Drupal 11 is out?
This looks good to me!
This looks good to me. Can this be merged so we can start preparing to migrate our sites to D11.
This looks good to me. Can this be merged so we can start preparing to migrate our sites to D11.
Will this be getting rolled into the stable release at some point?
This patch looks good to me. Can this be merged so we can look at upgrading to Drupal 11? Thanks in advance.
Thank you!!!
Just tested and looks to be working just fine!! Thank you so much again for you work on this!
Amazing. Thank you!
Hi. Thanks for all your hard work on this! Is this getting a stable release anytime soon now that Drupal 11 is out?
Is there a timeline for getting this merged? Drupal 11 is out now and we're auditing our readiness to upgrade and have a lot of websites using this module. Many thanks!
Sorry to comment again! Any update on this? Drupal 11 is out now and we're auditing our readiness to upgrade and have a lot of websites using this module.
Sorry to comment again! Any update on this? Drupal 11 is out now and we're auditing our readiness to upgrade and have a lot of websites using this module.
Hi again. Sorry to double post but Drupal 11 is out now and we're looking at the upgrade path for many sites that use this module. Is there a timeframe for getting this patch into a stable release for the module?
Thank you so much!! This is awesome news!
Thank you for that rapid turnaround!! I'm trying to be organised this time and iteratively upgrade all our sites so there's a more straightforward migration to D11. Doing it all in one big bang is always painful!
Legendary turnaround!! Thank you so much!
Amazing. Thank you!
Thank you! Any update on when this will make it in to the stable release. Really appreciate your time on this.
This looks pretty straight forward. Can this be merged so we can start preparing for D11 support?
+1 for full release! Appreciate all of your hard work on this. All of our sites use this module and we're currently auditing D11 compatibility and this module is a blocker across all of our sites.
Will this be getting a full release anytime soon? We're auditing all of our client's sites in preparation for upgrading to Drupal 11. Thank you for all your hard work!
This looks pretty straight forward. Can this be merged so we can start preparing for D11 support?
Thank you for your hard work. Is this getting a full release anytime soon?
Any idea when this will make it into the stable release?
Are there any updates on this? Can this be merged so we can start preparing for D11 support?
Thanks for your hard work on this. When can we expect a full release for this? We have several sites using contact_storage that we're looking to migrate to Drupal 11 when the full release lands.
When can we expect this to make it into the full release? We are making preparations for several sites using config_pages to migrate to D11.
This looks good to me too! Can this be merged so we can start preparing for D11 support?
This looks pretty straight forward. Can this be merged so we can start preparing for D11 support?
This looks good to me? Any chance this can be merged now that Drupal 11 is in RC?
I can confirm that the patch in #14 no longer applies on 3.5.0 but I'm also no longer seeing the full menu flash issue.
I'd suggest that this issue could be closed if others are reporting the same and another issue could be opened regarding the issues raised in #19 as that feels like a separate problem?
The patch in #45 also works for me.
Found a related issue with a patch to fix this:
https://www.drupal.org/project/drupal/issues/3456176#comment-15661382
🐛
10.3 upgrade now missing status-message theme suggestions
Postponed
Also seeing this issue in a custom theme when big pipe is enabled.
Just dropping in to confirm #28 fixes the issue! Thanks.
Thanks Osama Nuserat. I'd missed the other files as I was following error messages on my install. I'll be sure to check more thoroughly in the future. I've just tested your patch and it all looks good to me. I've updated the MR so it's easier for stomusic to merge to the dev branch.
@mali2022 are you able to test the dev branch of selective_better_exposed_filters and my patch above and see if you can install better_exposed_filters 7.0.0-beta1 in conjunction and that everything is working as expected?
Thanks! This progressed us a bit but it turns out that the DefaultWidget.php needed a few updates as well. Merge request above and patch is here:
https://git.drupalcode.org/project/selective_better_exposed_filters/-/me...
Is there anything else I can do to progress this? This issue is preventing us upgrading better exposed filters on several sites.
I think the MR contains the change needed to restore compatibility with the latest version of better_exposed_filters.
I've just run in to this as well.
darren.fisher → made their first commit to this issue’s fork.
darren.fisher → created an issue.
This issue is in src/UnmanagedFilesService.php on line 173 where:
$public_dir = $this->state->get('file_public_path', 'sites/default/files');
is declared. This would need to be done in a loop for all subdirectories - eg. /sites/*/files
Alternatively there could be an admin screen that allows us to specify which files directories we want to search in that then gets saved as an array variable that can be looped through in this code.
I've also just attempted to use this on a multi-site (multsite) setup and can confirm that this is still an issue. I will look at the code and see if there's a way to check all subfolders in the /sites directory.