- 🇮🇳India kavitha@specbee.com
When trying to apply patch, the following can be observed:
2.patch:369: trailing whitespace.
2.patch:415: trailing whitespace.
contributed Drupal module. Visit
warning: 2 lines add whitespace errors. - Status changed to Needs review
over 1 year ago 1:17pm 12 June 2023 - 🇮🇳India sourabhjain
@kavita you need to go into the MR branch. No need to check patches etc. Its working perfectly for me.
- First commit to issue fork.
- 🇮🇳India Nupur Badola
Patch has some errors.
git.drupalcode.org_project_file_browser_-_merge_requests_2.diff.txt:22: trailing whitespace. git.drupalcode.org_project_file_browser_-_merge_requests_2.diff.txt:59: trailing whitespace. contributed Drupal module. Visit warning: 2 lines add whitespace errors.
- First commit to issue fork.
- 🇧🇪Belgium Frederikvho Belgium
Hi,
I fixed the two white spaces from the previous warnings in comment #18.
Please review and try to apply the latest .diff from the MR. - Status changed to RTBC
over 1 year ago 9:22am 13 July 2023 - 🇮🇳India kavitha@specbee.com
Moving it to RTBC as patch works fine and .txt file is converted to .md as per the attached screenshot
- Status changed to Needs review
over 1 year ago 9:48am 13 July 2023 - 🇩🇰Denmark ressa Copenhagen
@kavitha:
As at least two users have already commented, you need to review the actual content, and check if the formatting is following the guidelines, and if the instructions are correct, etc.
Checking if a patch applies is NOT a review.
In my opinion, it provides no value, is mainly noise, and could be considered spam.
@kavitha Generally, it is best practice to explain what criteria you used to move the issue into RTBC.
What did you test? Were all comments addressed? Did all the links work as expected, coding standards, clear concise sentences, and so on.Thanks.
By @volkswagenchick in https://www.drupal.org/project/default_content/issues/3107493 🐛 obsolete text in README Needs review
@kavitha: Please don't upload screenshots of your terminal showing a directory tree, it just adds noise.
Before an issue can be marked RTBC the changes need to be reviewed, this wasn't done.
Furthermore the documentation team have finally agreed upon a template for using markdown syntax: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
This means that the patch needs further work to make it adhere to the new standard, so I'm setting the status back to "needs work".
By @DamienMcKenna in https://www.drupal.org/project/bridtv/issues/3068818 📌 Update README.md to follow the documentation template Needs work
- 🇳🇴Norway gisle Norway
I am a site moderator here.
I've deleted the comment added by kavitha@specbee.com as spam.
I agree with ressa that posting a screenshot showing that a patch applies and that the name of the file changes from "README.txt" to "README.md" provides zero value. To ne, this looks like an attempt to gain undeserved issue credit. The user is hereby put on notice. If this abuse of the issue queue continues, the account will be blocked.
- 🇩🇰Denmark ressa Copenhagen
Thanks for maintaining the issue queues @gisle, I really appreciate it.
Since the comment with link to the profile is now removed, here is the path:
https://www.drupal.org/u/kavithaspecbeecom →It's surprising to see this behavior from a Specbee → employee, which is both
- Drupal Gold Certified Partner
- Drupal Association Premier Supporting Partner
- Drupalcon 2023 Exhibitor Sponsor
- 🇳🇴Norway gisle Norway
After finding and deleting double digits spam "reviews" by this same individual, I've created #3374414: Disturbing behavior by Specbee employee → .
- 🇩🇰Denmark ressa Copenhagen
Thanks for following up on with a dedicated issue.