🇧🇷Brazil @elber

elber → created an issue.

As @pwolanin has been approved (see comment #9), I'm moving to RTBC.

elber → made their first commit to this issue’s fork.

elber → made their first commit to this issue’s fork.

elber → made their first commit to this issue’s fork.

elber → made their first commit to this issue’s fork.

Hi please can you give me more details about this issue? because I didn't understand what do you want.

The module already has .permissions.yml file and a routing.yml file, it sounds good to me

elber → made their first commit to this issue’s fork.

Hi, I reviewed it.

It follows the Drupal standards and is necessary for the module.
Module is ok
Moving to RTBC

Hi I reviewed the composer.json file, I followed this doc https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-file →

composer.json file follows the Drupal standards.

I also checked whether it is a valid composer using the command composer normalize

I got the output ./composer.json is already normalized

Moving to RTBC.

I will do a review.

hi please revise

elber → made their first commit to this issue’s fork.

Please revise

Hi please revise, Am I correct?

elber → made their first commit to this issue’s fork.

Hi please revise

elber → created an issue.

Hi, I reviewed the MR.

The module is working well now.

Bug is fixed

Moving to RTBC

Thank you!

Hi please revise.

Hi @Bhupendra_Raykhere your code is wrong you added it

administer node by term settings:
  title: 'Administer node by term settings'
  description: 'Access and manage the settings for node by term Module.'
  restrict access: true

on a .services.yml file it should be on a .permissions.yml file

You should reopen this issue and fix it.

The service file "modules/contrib/node_by_term/node_by_term.services.yml" is not valid: it contains invalid keys Array. Services have to be added under "services" and Parameters under "parameters".

Hi @Bhupendra_Raykhere you forgot my credit I worked on this issue and I deserve a credit, please fixe it.

elber → made their first commit to this issue’s fork.

Hi I reviewed the last patch
The module keeps working normally
PHPCS errors has been fixed
Moving to RTBC

Hi, I reviewed the patch.

The patch fixed the issue.

The module keeps working normally

The patch was applied cleanly
Moving to RTBC

Ok I am sorry @DamienMcKenna I put the diff file to become the review easier, diff is not to be applied. Once I'm sorry I should clarify it.

I wiill keep working on the others composer.json files.

Hi Normalized composer.json following this doc instructions

Here are the steps:

composer require --dev ergebnis/composer-normalize

composer normalize --diff

As a result I had this output Successfully normalized ./composer.json. and a diff information(see the attached bellow)

Hi I'm taking a look on it.

I agree with you this change makes sense and theme can be used in drupal 9 and 10 now
No issues to related
moving to rtbc

I reviewed the patch.

Patch is working (applied correctly and fixing error)
Module is working as expected
I'm using drupal 10.1.x version

I will work on it

Hi @tobiasb can I get credit?

Hi @tobiasb I read the documentation about module and your dependencies.

I can assume that this issue and your change makes sense

MR is good moving to RTBC

Please revise

Hi please revise.

elber → created an issue.

Hi I just saw this issue and then I tried to understand how this module works to try help you with a review.

Thank you I appreciate it!

Hi @phjou you forgot your credit to nitin_lama, lucienchalom, gisle and me please can you fix it?

Hi I revised the path.

DI are implemeted correctly in the module

No phpcs errors

Moving to RTBC.

elber → created an issue.

elber → made their first commit to this issue’s fork.

Hi I revised the patch.

it is good to me phpcs errors has been fixed

Patch applied cleanly, module keeps working normally moving to RTBC.

Hi I reviewed the patch.

Pathc is applied cleanly
theme is working as expected
Issue was fixed

Moving to RTBC

Hi I reviewed the changes in the MR.

I followed the steps below:

1. Go to this path : admin/config/content/node-title-validation
2. Configure the module by filling up the required inputs
3. Save the module configurations

Changes in the MR applied cleanly
modue is working as expected ( we can set the config normally)
Moving to RTBC.

elber → made their first commit to this issue’s fork.

rebase completed

Please revise again

please revise

Hi I reviewed the last changes. ( I just fixed the characters limit in one line)

It is good to me, Readme file is clear explaning the module.

Also following drupal standards.

The errors mentioned by Apaderno has been fixed in my opinion.

Moving to RTBC.

Please revise.

Please revise

elber → made their first commit to this issue’s fork.

Hi please revise

ok I'm sorry please can you explain the general idea of this issue?

if you could give a better explanation about what I can improve it is good.

Following the previously comment I think it can be move to RTBC, because it already was revised.

elber → made their first commit to this issue’s fork.

Hi please revise.

elber → made their first commit to this issue’s fork.

Hi sorry just the maintainers should move to fixed and give the credits.

Hi @ddavisboxleitner I reviewed it.

No bugs found
Changes applied correctly.

I'm using drupal 10.1 version and branch 4.x

Module is ok.

Moving to RTBC.

Hi I agree with your idea it makes sense.

Patch is cleanly.

Moving to RTBC.

Hi please revise.

elber → made their first commit to this issue’s fork.

Hi Tanuja Bohra I fixed it, please revise

elber → made their first commit to this issue’s fork.

Hi I reviewed it using drupal 9.5 version.

Testing /app/web/modules/contrib/dfp
.........................                                         25 / 25 (100%)

Time: 00:44.676, Memory: 16.00 MB

OK (25 tests, 154 assertions)

Tests are passing now, moving to RTBC

elber → made their first commit to this issue’s fork.

Hi I reviewed it.

I agree with the solution in MR, this dependency isn't necessary.

Installation is working good now.

Moving to RTBC.

Hi kenyoOwen I added a period, is it good? Please revise

Hi added the permissions please revise.

elber → made their first commit to this issue’s fork.

Hi I just rebased please revise

Hi @e0ipso you forgot my credit can you fix it please?