Dependency injection anti-patterns

Hi please revise, Am I correct?

Hello @elber,
thank you for your timely fix. It is on point. However, there are some cosmetic changes needed.

I've checked for other occurrences of anti-patterns and did not find any.

Please revise

Looks good, thank you @elber.

Thank you for the contribution!

Yes, we should load the config as late as possible, but it seems the PR converts one call wrong.
Then, we should avoid loading the config multiple time in a single page load, thus I think we need to introduce some sort of getter to load the config and statically cache it in a local variable.

I've added a property and g(/s)etter method on BaseUrlProvided and make FrontendRedirectSubscriber use that instead.

re-rolled the PR to the latest 1.x version

NW for above comments (implement or tell me they're not useful)

Implemented code review recommendation. (I've missed that setting service exists already).

Thanks for your contribution, I made review for this MR, can you please check my feedback?

As I understand phpunit fails is not related to this changes, and we already have task to fix it. I belive this one 📌 Make the gitlab-ci pipeline pass Needs review .

@zniki.ru you are correct, this issue is not related to phpunit failures. Only 🐛 Fix PHPCS and maybe other errors Needs review is related.

(I started that issue while seeing some failures, and someone said "yes you should fix them", but I didn't know the history. So I opened 🐛 Fix PHPCS and maybe other errors Needs review without looking further... but as things grew, that issue has now turned into a duplicate of 📌 Make the gitlab-ci pipeline pass Needs review .)

Fix comments and order of params.

I don't think we should use property promotion since we don't have a dependency on php8 in the project's composer.json.

Needs work for last comment, but I'm fine with you merging this immediately after the change (provided the change is only removing that public getter method).

(Tested current code, to be sure of previous statement.)

merged & fixed

huh it was ride, thank you for staying along

Automatically closed - issue fixed for 2 weeks with no activity.