Duplicated test method name in in-line comment

hi please revise

Tagging as novice, for new user

Read the change a few times and think it reads fine. "an alias" may also work but think this works.

@ashley_herodev, thank you for working on a spelling issue!

I read the IS and see two instances of the word to change. I then read the MR and see only one change. This will need more work.

So when working on spelling issues there is some more steps to do as well. The misspelled word is in the core dictionary and we want to remove that. What we do is delete the misspelled word from the dictionary and then run the spell checker, yarn spellcheck:core to find all the instances of that word. Then fix each one until yarn spellcheck:core runs without error. There is more information and links to helpful pages to be found in the Meta issue for spelling, 📌 [Meta] Remove spelling errors from dictionary.txt and fix them Active .

It is also not practical to make an issue for each word. To make good use of reviewers and committers time the scope of this should expand to include other words prefixed with 'un' but not too many such that the change is too large. And the changes should be similar. For example this one is only found in a comment, so finding others that are also only changed in a comment would be a good way to scope this. There is information about patch size → that suggests a limit of 100 lines.

I am restoring the standard template so that the remaining tasks is available. Adding the tag for spelling errors. Also, tagging for a title update. I don't see a duplicated name.

I did some searching and these are likely candidate words that can be included in this change. These are words that should only be changed in comments. I am not suggesting that all these be done in this MR. The overall size of the change must be considered and the load on the reviewer who has to read each change in context.

unallowed
unassigning
unclickable
uncollapsible
ungenerated
uninstallations
unmanaged
unpermissioned
unrouted
unstripped
untabbable
untarring
untrustable
unvalidated
unwrapper

Updated comments for clarity and grammar conformance. Replaced ambiguous language and terms with more explicit phrases.

#7 @quietone mentioned updating the title

#8 @quietone also mentioned some words that could be target. Which were chosen? They should be included in the issue summary.

I updated the summary to represent the changes better. Whenever you have a minute, please review the MR. I appreciate your time.

So reading remaining tasks

Update the misused words from the comments, particularly "unpreloaded", "uninstallations", "unstripped", and "untranslatable".

Has that been done?

Updated the issue summary as quite a few words with the 'un' prefix have been fixed elsewhere. And updated the MR to get this back on track.

5 words much easier to review.

Re-read the replacements read fine to me.

Okay, this issue went in a direction that was not what I intended originally. It is actually making grammatically incorrect changes (e.g., treating "install" and "uninstall" as nouns, which they are not).

The reasoning behind this set of issues was that some "un-" words should be hyphenated, and others that were legitimately a part of Drupal terminology should be moved to the correct issues.

We should not be rewording sentences to try to remove the word "uninstallation" from the codebase. It is a completely legitimate word. Instead, that word should be moved to the Drupal dictionary. This is similarly true for "untranslatable", which is a Drupal concept used in property names and the like. "Unpublished" also falls in that category. I would make the case that "Unfieldable" does as well.

So, this issue is mixing up "undoable" -- which does indeed deserve hyphenating and rewording.

Let's get this rescoped -- add "unpublish", "uninstall", and their derivatives, as well as "unfieldable", to the Drupal dictionary in one issue. Fix the other two in another (can be this issue).

Thanks!

@xjm, Why the change from the Meta issue for some of these words? According to the history of the Meta you were involved in making the recommendations on the meta.

The recommendation in #19 say the following should be added to the Drupal dictionary.

• "unpublish"
• "uninstall", and their derivatives,
• "unfieldable",

The meta has this

• unfieldable -> un-fieldable
• uninstallation -> un-installation
• uninstallations -> TODO: Look up context

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I Have checked the merge conflict and re base this MR & fixed merge conflict.according to #20 so moving this back to NR.

Believe #20 needs an answer before this can move forward.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Re based & fixed conflicts , AS per #20 & #27 Moving this NR for answer.

Needs a rebase

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

Re based the MR, moving this for NR. Kindly review.

This one has bounced around for a while now, would the net improvement be worth getting in?

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.