[meta] Fix missing hyphens for prefixes - Words starting with "un"

Created on 18 February 2022, over 2 years ago
Updated 27 June 2024, 1 day ago

Problem/Motivation

Quoted from parent issue:

Discovered at #2972224: Add .cspell.json to automate spellchecking in Drupal core โ†’ , and pointed by @xjm in https://www.drupal.org/project/drupal/issues/3122088#comment-13628724 ๐Ÿ“Œ [Meta] Remove spelling errors from dictionary.txt and fix them Active

@xjm:

Should be hyphenated (un-assign, de-prioritize, re-render, etc.)

There's an interesting question of where to draw the line for these. Generally in English these prefixes are morphologically productive with a hyphen, and get de-hyphenated when the word is adopted into common usage. "Denormalize", "Unsanitized", "Uninstantiated" etc. are all obviously in common usage in programming. "Unsticky", "Unrevisionable", and the like are Drupal terminology, and I'm surprised that "unpublish" and friends aren't already in the main dictionary.

The parent issue tried to fix all words that should be hyphenated, but the patch for this was getting too big thus making it tricky to review. Also there were some debate about which words should be hyphenated, and which shouldn't. So they argued it would be better to separate the issue into 3 smaller ones (one each for words starting with 're', 'de' and 'un'). (see comment links bellow)

#3138768 #26.2 ๐Ÿ“Œ [Meta] Fix flagged spelling errors due to missing hyphens for prefixes Active @xjm talks about the presave word and suggests to divide the issue.
#3138768 #31 ๐Ÿ“Œ [Meta] Fix flagged spelling errors due to missing hyphens for prefixes Active @longwave agrees to divide the issue and says it's getting tricky to review.
#3138768 #36 ๐Ÿ“Œ [Meta] Fix flagged spelling errors due to missing hyphens for prefixes Active @davidhernandez questions about if some words should be hyphenated.
#3138768 #38 ๐Ÿ“Œ [Meta] Fix flagged spelling errors due to missing hyphens for prefixes Active @quietone agrees with @longwave about creating separated issues.

Proposed resolution

Check and decide as a group, with first-language speakers contributing, which of the following words are correct in Drupal and which should be hyphenated, then fix them as needed on the code.

  1. unban -> TODO: Look up context
  2. uncacheable -> un-cacheable
  3. uncategorized -> un-categorized (? โ€“ check if this is in the dictionary)
  4. ungroup -> un-group
  5. ungroupable -> un-groupable
  6. unindexed -> un-indexed
  7. unmanaged -> TODO: Look up context
  8. unminified -> un-minified (? โ€“ maybe de-minified)
  9. unmoderated -> un-moderated
  10. unpromote -> un-promote
  11. unpublish -> un-publish (? โ€“ check dictionary on this)
  12. unpublishing -> un-publishing (? - check dictionary on this)
  13. unrevisionable -> un-revisionable
  14. unrouted -> TODO: Look up context
  15. unserialized -> un-serialized
  16. unsets -> un-sets (? โ€“ check dictionary on this)
  17. unsetting -> un-setting (? โ€“ check dictionary on this)
  18. unsticky -> un-sticky
  19. untabbable -> TODO: Look up context
  • ๐Ÿ› Fix spelling of 5 'un' words in comments Needs review
    1. undoable -> TODO: Look up context
    2. unfieldable -> un-fieldable
    3. uninstallation -> un-installation
    4. uninstallations -> TODO: Look up context
    5. unpublishes -> un-publishes (? โ€“ check dictionary on this)
  • ๐Ÿ“Œ Hyphenate 4 words that start with 'un' Needs review
    1. unsanitized -> un-sanitized
    2. unserialization -> un-serialization
    3. unserializes -> un-serializes
    4. unserializing -> un-serializing
  • ๐Ÿ“Œ Fix spelling of some words with 'un' prefix RTBC
    1. unaliased
    2. unallowed
    3. unconfigured
    4. undelayed
    5. undraggable
    6. unextracted
    7. unflagged
    8. unhashed
    9. unhides
    10. unindented
    11. uninstantiatable
    12. uninstantiated
    13. unixepoch This is an SQLite function
    14. unixtimestamp
    15. unkeyed
    16. unmatch
    17. unpermissioned
    18. unpreloaded
    19. unrendered
    20. unshortened
    21. unsimplified
    22. untarring
    23. untrustable
  • ๐Ÿ“Œ Fix 12 'un' words RTBC
    1. unassigning -> un-assigning
    2. unassigns -> un-assigns
    3. unbans -> TODO: Look up context
    4. unbundleable -> un-bundleable
    5. unclickable -> TODO: Look up context
    6. uncollapsible -> TODO: Look up context
    7. ungenerated -> TODO: Look up context
    8. unparseable -> un-parseable
    9. unpromoted -> un-promoted
    10. unregisters -> un-registers
    11. unvalidated -> TODO: Look up context
    12. unwrapper -> TODO: Look up context

Remaining tasks

  1. First, probably reduce the list above (as a non-native English speaker I couldn't remove all the 'obviously unhyphenated' words before posting here).
  2. Decide as a group what to do with each word.
  3. Remove and fix the words as defined by the group.
  4. Review.
  5. Commit.

User interface changes

API changes

Data model changes

Release notes snippet

๐ŸŒฑ Plan
Status

Needs review

Version

11.0 ๐Ÿ”ฅ

Component
Documentationย  โ†’

Last updated about 8 hours ago

No maintainer
Created by

๐Ÿ‡ง๐Ÿ‡ทBrazil andregp

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024