- π³πΏNew Zealand quietone
Replaced the spreadsheet from #45 (now deleted) with a new one. Details in the Issue Summary.
- πΊπΈUnited States smustgrave
From π Fix spelling of function names in tests Needs review
Comment#20 from @xjm
This issue seems to be a mix of two scopes: Actual API methods which are cased incorrectly in the test code, and test methods being renamed. The scope is small enough that that is not necessarily a problem, but it does require the reviewer to context-switch between looking up actual APIs and just reviewing within the content of the test method. I'd recommend separating those two kinds of fixes when we get to non-test functions.
"Needs followup" isn't exactly the right tag for #19; what I mean by it here is "Needs update to parent meta IS and instructions so that subsequent and followup issues are scoped correctly."
- π³πΏNew Zealand quietone
Just updating the list of issues to do in the Issue Summary
- π¬π§United Kingdom joachim
I don't understand π Simple fixes for words with prefix of 'de' or 're' RTBC . Words like 'reclosed' are not spelling errors -- https://dictionary.cambridge.org/dictionary/english/reclose
- π³πΏNew Zealand quietone
Determining if a word is spelled incorrectly or not will always be a challenge. Languages change over time as words are added and meanings change. Drupal core uses American English so, which dictionary do we use? There are many on-line dictionaries and they do not always agree.
In the end, we are using cspell, and must defer to what they are using, which I think is hunspell. Words can be added upstream but I haven't explored that much after reading this issue.
In the case of 'reclosed', that was used only twice. I think it was better to convert that and have a smaller dictionary list. However, for other words like this with high usage we probably do want to file an issue upstream and/or add it to the drupal dictionary.
- π³πΏNew Zealand quietone
I made the followup asked for in #31 and earlier added some suggestions about scope. Therefore, removing the tag.
- πΊπΈUnited States neclimdul Houston, TX
re: π Simple fixes for words with prefix of 'de' or 're' RTBC
dequeue is the correct technical term for removing an item from a queue. I'm not sure if unqueue is actually a word but what I can find it has a different meaning.
reference:
- https://en.wikipedia.org/wiki/Queue_(abstract_data_type)
- https://computersciencewiki.org/index.php/Queue
- https://www.programiz.com/dsa/queue
- etc