Fix spelling of function names in tests

I haven't found any other misspelled function names in tests. So, making this available for review.

Surprised andif never failed with it being lowercase.

Reviewed rest of text changes, andif was the only one I needed to google.

I keep finding more, so I am setting this back to active while I do more searching.

@smustgrave, the lowercase of 'andif' works because function names are not cases sensitive in PHP.

Note: Function names are case-insensitive for the ASCII characters A to Z, though it is usually good form to call functions as they appear in their declaration.

On user defined functions

Though lowercase works for php function but according to Drupal standard we should follow camelCase for function name .

Will let @quietone put into review. Was previously RTBC and she was addressing more words.

Thanks.

It seems there is a commit that already changed the core/misc/cspell/dictionary.txt file, which is also changed by the MR provided here.

@apaderno, yes, every 'spelling' issue will change dictionary.txt and that is highly likely to mean that the other 'spelling' issues need to be rebased.

I haven't found any more function names in tests that need to be change, so I have rebased this and set to needs review.

issue summary items match the MR.

Text changes make sense.

Rebased and getting a random test failure in Drupal\FunctionalJavascriptTests\Core\Field\TimestampFormatterWithTimeDiffTest.

Leaving at RTBC

Another rebase. Pipeline was still failing, also.

This issue seems to be a mix of two scopes: Actual API methods which are cased incorrectly in the test code, and test methods being renamed. The scope is small enough that that is not necessarily a problem, but it does require the reviewer to context-switch between looking up actual APIs and just reviewing within the content of the test method.

"Needs followup" isn't exactly the right tag for #19; what I mean by it here is "Needs update to parent meta so that subsequent and followup issues are scoped correctly."

I reviewed the whole MR; everything looks fine aside from the out-of-scope change to TempStore.

Thanks, I have removed the changes from TempStore.

Didn't update the summary in the meta but did leave a comment and tag that it needs it though.

For this issue confirmed changed to tempstore have been reverted and tests are still green.

I think @smustgrave meant RTBC?

Getting the "case-insensitive Mac file problem" when applying the diff:

error: core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDateOnlyTest.php: already exists in working directory

I can't remember what the workaround is; I might have to remove the file rename from my patch and then do the move with git, I think.

Committing with the following process:

1. Manually remove the file rename from the diff.
2. Apply the modified diff (attached) locally.

3. [ayrton:maintainer | Fri 10:57:27] $ mv core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDateonlyTest.php core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDateOnlyTest.php
   

4. Commit.

Committed to 11.x, 10.2.x, and 10.1.x as a test-only change set. Thanks!

xjm → closed merge request !4941

Automatically closed - issue fixed for 2 weeks with no activity.