- Issue created by @bhumboldt
- First commit to issue fork.
- Issue was unassigned.
- Status changed to Needs review
5 months ago 8:53am 15 June 2024 - π³πΏNew Zealand quietone
Created an MR for what should be an easy set of words.
- π¬π§United Kingdom joachim
These seem like weird words to hyphenate.
unsanitary is a word without a hyphen, so it doesn't make sense for unsanitized to need one.
And the PHP function is called unserialize(), so again, it's weird to put a hyphen in text.
- Status changed to Needs work
5 months ago 11:34am 20 June 2024 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs review
5 months ago 12:31pm 20 June 2024 - π³πΏNew Zealand quietone
I think instead of figuring out why cspell has a word or not in a particular dictionary we should focus on what works for Drupal. Do we a) change the code/comments or b) add a given word to the drupal dictionary or c) make a PR to have it added to the a given dictionary.
Of those choices, what should happen to the 4 words in this issue?
- π¬π§United Kingdom joachim
I'd say b), and also c) so that in time we can remove the added words from b).
Changing correct spellings to satisfy the omissions in the dictionary is babysitting.
- πΊπΈUnited States smustgrave
So is consensus to add to drupal dictionary file?
- Status changed to Needs work
3 months ago 11:35pm 13 August 2024 - π³πΏNew Zealand quietone
Changing correct spellings to satisfy the omissions in the dictionary is babysitting.
From which dictionary are you referring to?
We may think that these four words are spelled correctly but they are not found in the American English dictionaries used in the Drupal Content style guide β .