- Issue created by @quietone
- Status changed to Needs review
11 months ago 11:45pm 9 January 2024 - π³πΏNew Zealand quietone
This is the first group of possibly hyphenated words that I have done, so setting this small set to Needs Review.
- πΊπΈUnited States smustgrave
So I believe unvalidated is a correct word https://www.yourdictionary.com/unvalidated
- π³πΏNew Zealand quietone
You may believe that but cspell does not! :-)
And is that source using US English or something else?
The worn 'unvalidate' is not in the en_us dictionary used by cspell and neither is it at https://www.thefreedictionary.com/unvalidate, https://www.collinsdictionary.com/spellcheck/english?q=unvalidate, https://www.merriam-webster.com/dictionary/unvalidate. And three of them are definitely using US English.
- π³πΏNew Zealand quietone
Ah, the answer is to use 'non validated' as is used elsewhere in core, for example \Drupal\Core\Form\FormValidator::handleErrorsWithLimitedValidation. I just didn't think this through when I made the MR.
- Status changed to RTBC
11 months ago 10:42am 10 January 2024 - πΊπΈUnited States smustgrave
Ah good find. That makes more sense and sounds right when said out loud. Rest of word changes seem good
- Status changed to Needs work
10 months ago 5:31pm 17 January 2024 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to RTBC
10 months ago 7:17am 18 January 2024 - π³πΏNew Zealand quietone
It was a straightforward rebase so I restoring RTBC.
- Status changed to Needs work
10 months ago 2:43pm 26 January 2024 - Status changed to Needs review
10 months ago 2:01am 27 January 2024 - Status changed to RTBC
10 months ago 12:35am 28 January 2024 - π¬π§United Kingdom longwave UK
Cherry-picks cleanly to 10.2.x so backported there to keep things in sync as this only changes words in comments and tests.
Committed and pushed 2624df1b1c to 11.x and eb70d19029 to 10.2.x. Thanks!
-
longwave β
committed eb70d190 on 10.2.x
Issue #3412959 by quietone, smustgrave, longwave: Fix 12 'un' words (...
-
longwave β
committed eb70d190 on 10.2.x
- Status changed to Fixed
10 months ago 11:49am 2 February 2024 -
longwave β
committed 2624df1b on 11.x
Issue #3412959 by quietone, smustgrave, longwave: Fix 12 'un' words
-
longwave β
committed 2624df1b on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.