Contrib.social

Fix Drupal 10 compatibility related errors

Open on Drupal.org →
Created on 15 February 2023, almost 2 years ago
Updated 19 February 2024, 10 months ago

Problem/Motivation

Since Drupal 9 is supported only until Nov'23 & there currently appears to be no Drupal 10 candidate for this module, what is the recommended upgrade path for someone starting via Drupal 10 core?

Steps to reproduce

Using composer to require commerce-marketplace on drupal 10 core fails as there is no listed install candidate.

Proposed resolution

I would be willing to build a Drupal 10 candidate or contribute to same if it is in the works.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇨🇦Canada ramriot

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ramriot
  • Assigned to roshni27
  • Comment over 1 year ago →
    🇮🇳India roshni27

    It is not compatible with Drupal 10. I am working on it.

  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India roshni27

    Relying on entity queries to check access by default on this warning maintainer will better know what to do.
    I have solved Drupal 10 compatibility issues. Please review the patch.

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇪🇪Estonia drugan

    As a minimum we need to fix the following errors:

    drugan@test-commerce-marketplace-web:/var/www/html$ vendor/bin/phpstan analyze -l 0 web/modules/contrib/commerce_marketplace/
 38/38 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------------------------------ 
  Line   src/Form/MarketplaceForm.php                                                                          
 ------ ------------------------------------------------------------------------------------------------------ 
  117    Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will  
         be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE  
         or FALSE to specify whether access should be checked.                                                 
         💡 See https://www.drupal.org/node/3201242                                                            
  131    Method Drupal\commerce_marketplace\Form\MarketplaceForm::save() should return int but return          
         statement is missing.                                                                                 
 ------ ------------------------------------------------------------------------------------------------------ 

 ------ -------------------------------------------------------------------------------------- 
  Line   src/Form/MarketplaceProductForm.php                                                   
 ------ -------------------------------------------------------------------------------------- 
  24     Access to an undefined property                                                       
         Drupal\commerce_marketplace\Form\MarketplaceProductForm::$entityManager.              
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
 ------ -------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------- 
  Line   src/Form/MarketplaceShippingMethodForm.php                                                           
 ------ ----------------------------------------------------------------------------------------------------- 
  22     Method Drupal\commerce_marketplace\Form\MarketplaceShippingMethodForm::save() should return int but  
         return statement is missing.                                                                         
 ------ ----------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------ 
  Line   src/MarketplaceAccessControlHandler.php                                                               
 ------ ------------------------------------------------------------------------------------------------------ 
  25     \Drupal calls should be avoided in classes, use dependency injection instead                          
  30     Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will  
         be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE  
         or FALSE to specify whether access should be checked.                                                 
         💡 See https://www.drupal.org/node/3201242                                                            
 ------ ------------------------------------------------------------------------------------------------------ 

 ------ ----------------------------------------------------------------------------------------------------- 
  Line   src/MarketplaceEntityTypeInfo.php                                                                    
 ------ ----------------------------------------------------------------------------------------------------- 
  43     Unsafe usage of new static().                                                                        
         💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static                    
  61     Method Drupal\commerce_marketplace\MarketplaceEntityTypeInfo::entityOperation() should return array  
         but return statement is missing.                                                                     
 ------ ----------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------- 
  Line   src/MarketplaceNodeTypeListBuilder.php                                                
 ------ -------------------------------------------------------------------------------------- 
  21     Access to an undefined property                                                       
         Drupal\commerce_marketplace\MarketplaceNodeTypeListBuilder::$entitiesKey.             
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
 ------ -------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------- 
  Line   src/MarketplaceOrderItemTypeListBuilder.php                                           
 ------ -------------------------------------------------------------------------------------- 
  20     Access to an undefined property                                                       
         Drupal\commerce_marketplace\MarketplaceOrderItemTypeListBuilder::$entitiesKey.        
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
 ------ -------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------- 
  Line   src/MarketplaceProductTypeListBuilder.php                                             
 ------ -------------------------------------------------------------------------------------- 
  20     Access to an undefined property                                                       
         Drupal\commerce_marketplace\MarketplaceProductTypeListBuilder::$entitiesKey.          
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
 ------ -------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------ 
  Line   src/MarketplaceProductVariationAccessControlHandler.php                       
 ------ ------------------------------------------------------------------------------ 
  24     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ -------------------------------------------------------------------------------------- 
  Line   src/MarketplaceProfileTypeListBuilder.php                                             
 ------ -------------------------------------------------------------------------------------- 
  20     Access to an undefined property                                                       
         Drupal\commerce_marketplace\MarketplaceProfileTypeListBuilder::$entitiesKey.          
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
 ------ -------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------ 
  Line   src/MarketplaceShippingMethodAccessControlHandler.php                         
 ------ ------------------------------------------------------------------------------ 
  48     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------------------ 
  Line   src/MarketplaceStorage.php                                                                            
 ------ ------------------------------------------------------------------------------------------------------ 
  101    Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will  
         be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE  
         or FALSE to specify whether access should be checked.                                                 
         💡 See https://www.drupal.org/node/3201242                                                            
  249    \Drupal calls should be avoided in classes, use dependency injection instead                          
 ------ ------------------------------------------------------------------------------------------------------ 

 ------ -------------------------------------------------------------------------------------- 
  Line   src/MarketplaceVariationTypeListBuilder.php                                           
 ------ -------------------------------------------------------------------------------------- 
  20     Access to an undefined property                                                       
         Drupal\commerce_marketplace\MarketplaceVariationTypeListBuilder::$entitiesKey.        
         💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property  
 ------ -------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Action/MarketplaceClearOwnerLimit.php                              
 ------ ------------------------------------------------------------------------------ 
  24     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Action/MarketplaceClearStoreTypeLimit.php                          
 ------ ------------------------------------------------------------------------------ 
  24     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Action/MarketplaceIncreaseOwnerLimitByOne.php                      
 ------ ------------------------------------------------------------------------------ 
  24     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Action/MarketplaceIncreaseStoreLimitByOne.php                      
 ------ ------------------------------------------------------------------------------ 
  24     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Action/MarketplaceMarkAsDefault.php                                
 ------ ------------------------------------------------------------------------------ 
  25     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Action/MarketplaceMarkAsOwnerDefault.php                           
 ------ ------------------------------------------------------------------------------ 
  23     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Action/MarketplaceSetOwnerLimitToOne.php                           
 ------ ------------------------------------------------------------------------------ 
  24     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Action/MarketplaceSetStoreLimitToOne.php                           
 ------ ------------------------------------------------------------------------------ 
  24     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Field/FieldFormatter/MarketplaceNameFormatter.php                  
 ------ ------------------------------------------------------------------------------ 
  38     \Drupal calls should be avoided in classes, use dependency injection instead  
  41     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Field/FieldFormatter/MarketplaceTypeLabelFormatter.php             
 ------ ------------------------------------------------------------------------------ 
  58     \Drupal calls should be avoided in classes, use dependency injection instead  
  82     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

                                                                                                               
 [ERROR] Found 29 errors
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India ashutosh ahirwal India

    I have updated patch with all the issue reported by phpcs too.
    Please review.

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇪🇪Estonia drugan

    @Ashutosh Ahirwal

    Please read my #4 comment. 📌 Fix Drupal 10 compatibility related errors Needs work

  • First commit to issue fork.
  • @sarwan_verma opened merge request.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India sarwan_verma

    Hi @ramriot
    #5 Patch is working fine, I have clone the module on my local & apply the given patch.
    Changes are reflecting the site. I was getting only 1 error & fixed the same.
    and created MR.

  • Comment about 1 year ago →
    System Message
  • @sarwan_verma opened merge request.
  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇪🇪Estonia drugan
  • Comment about 1 year ago →
    System Message
  • Comment about 1 year ago →
    🇮🇳India sarwan_verma

    I'm getting below error's on my local setup.
    i'm working on this to fixes.

    rajesh@rajesh-Latitude-3420:/var/www/html/phpcs$ ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml --ignore=*/vendor/*,*/node_modules/*,README.md,./components/fonts.css,./components/style.scss,./dist/style.css /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/

    FILE: /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/commerce_marketplace.install
    ------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------
    3 | ERROR | Missing short description in doc comment
    ------------------------------------------------------------------------------------------------------

    FILE: /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/src/MarketplaceStorage.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------------------------------------
    74 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------

    FILE: /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/src/Plugin/Field/FieldFormatter/MarketplaceLabelCompactFormatter.php
    ----------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 4 LINES
    ----------------------------------------------------------------------------------------------------------------------------------------------
    99 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    120 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    121 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    122 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    122 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    122 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    ----------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/src/Plugin/Field/FieldFormatter/MarketplaceTypeLabelFormatter.php
    -------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------------------
    63 | WARNING | Possible useless method overriding detected
    -------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/src/Plugin/Field/FieldFormatter/MarketplaceListCompactFormatter.php
    ---------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 3 LINES
    ---------------------------------------------------------------------------------------------------------------------------------------------
    101 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    122 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    123 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    123 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    123 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    ---------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/src/Plugin/Field/FieldFormatter/MarketplaceNameFormatter.php
    --------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------------------------------
    26 | WARNING | Possible useless method overriding detected
    --------------------------------------------------------------------------------------------------------------------------------------

    FILE: /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/src/Resolver/MarketplaceProductDefaultStoreResolver.php
    ---------------------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ---------------------------------------------------------------------------------------------------------------------------------
    32 | ERROR | Parameter $entity_type_manager is not described in comment
    37 | ERROR | Doc comment for parameter $entity_manager does not match actual variable name $entity_type_manager
    ---------------------------------------------------------------------------------------------------------------------------------

    FILE: /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/src/Controller/MarketplaceEntityListController.php
    ----------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------------------
    56 | ERROR | Parameter $args is not described in comment
    ----------------------------------------------------------------------------------------------------------------------------

    FILE: /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/src/Form/MarketplaceShippingMethodForm.php
    --------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------------
    8 | ERROR | Doc comment is empty
    --------------------------------------------------------------------------------------------------------------------

    FILE: /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/src/Form/MarketplaceForm.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    -----------------------------------------------------------------------------------------------------------------------------------------
    58 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    59 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------

    FILE: /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/src/Form/MarketplaceAddToCartForm.php
    ---------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------------
    31 | WARNING | Unused variable $purchased_entity.
    ---------------------------------------------------------------------------------------------------------------

    FILE: /home/rajesh/project/ddd10/web/modules/contrib/commerce_marketplace/src/Form/MarketplaceProductForm.php
    -------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------
    20 | WARNING | Line exceeds 80 characters; contains 82 characters
    -------------------------------------------------------------------------------------------------------------

    Time: 434ms; Memory: 14MB

    rajesh@rajesh-Latitude-3420:/var/www/html/phpcs$

  • Comment about 1 year ago →
    🇪🇪Estonia drugan

    @sarwan_verma

    This issue is not about coding standards. Instead, it deals with the Drupal 10 compatibility errors which you can find in the #4 comment 📌 Fix Drupal 10 compatibility related errors Needs work .

    As soon as we fix compatibility errors then we can start fixing coding standards errors.

  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India sarwan_verma

    I have followed steps #4 . i have fixed all the errors which i'm getting & few error i can't find.
    I'm attaching the patch, please review & let me know if skipped any steps to resolve.

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇪🇪Estonia drugan

    Please, see the bottom of the #4 comment:

    [ERROR] Found 29 errors

  • First commit to issue fork.
  • Merge request !4Issue #3341967: Fix Drupal 10 compatibility related errors → (Open) created by elber
  • Comment 11 months ago →
    🇮🇳India zkhan.aamir

    Hi,

    MR #19 applied successfully.

    Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib/commerce_marketplace (8.x-1.x)
$ curl https://git.drupalcode.org/project/commerce_marketplace/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 19069    0 19069    0     0  42440      0 --:--:-- --:--:-- --:--:-- 42469
patching file commerce_marketplace.info.yml
patching file commerce_marketplace.install
patching file commerce_marketplace.module
patching file config/install/views.view.commerce_marketplace_administer_products.yml
patching file config/install/views.view.commerce_marketplace_administer_shipping_methods.yml
patching file config/install/views.view.commerce_marketplace_administer_stores.yml
patching file config/install/views.view.commerce_marketplace_store_orders.yml
patching file src/Controller/MarketplaceEntityListController.php
patching file src/Form/MarketplaceForm.php
patching file src/Form/MarketplaceShippingMethodForm.php
patching file src/MarketplaceOrderItemTypeListBuilder.php
patching file src/MarketplaceProductTypeListBuilder.php
patching file src/MarketplaceProfileTypeListBuilder.php
patching file src/MarketplaceShippingMethodAccessControlHandler.php
patching file src/MarketplaceStorage.php
patching file src/MarketplaceVariationTypeListBuilder.php
patching file src/Plugin/Field/FieldFormatter/MarketplaceLabelCompactFormatter.php
patching file src/Plugin/Field/FieldFormatter/MarketplaceListCompactFormatter.php
patching file src/Plugin/Field/FieldFormatter/MarketplaceTypeLabelFormatter.php
patching file src/Plugin/views/argument_default/MarketplaceUser.php

    Still there are some errors and warning.

    Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,js,yml commerce_marketplace/

FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\commerce_marketplace\commerce_marketplace.install
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 3 | ERROR | Missing short description in doc comment
------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\commerce_marketplace\README.md
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------
  44 | WARNING | Line exceeds 80 characters; contains 81 characters
  73 | WARNING | Line exceeds 80 characters; contains 81 characters
 181 | WARNING | Line exceeds 80 characters; contains 81 characters
-----------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\commerce_marketplace\src\Controller\MarketplaceEntityListController.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
 56 | ERROR | Parameter $args is not described in comment
----------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\commerce_marketplace\src\Form\MarketplaceAddToCartForm.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
 31 | WARNING | Unused variable $purchased_entity.
---------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\commerce_marketplace\src\Form\MarketplaceProductForm.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 20 | WARNING | Line exceeds 80 characters; contains 82 characters
-------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\commerce_marketplace\src\Plugin\Field\FieldFormatter\MarketplaceNameFormatter.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
 26 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\commerce_marketplace\src\Plugin\Field\FieldFormatter\MarketplaceTypeLabelFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------
 63 | WARNING | Possible useless method overriding detected
-------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\commerce_marketplace\src\Resolver\MarketplaceProductDefaultStoreResolver.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
 32 | ERROR | Parameter $entity_type_manager is not described in comment
 37 | ERROR | Doc comment for parameter $entity_manager does not match actual variable name $entity_type_manager
---------------------------------------------------------------------------------------------------------------------------------------------

Time: 1.04 secs; Memory: 12MB
  • Comment 10 months ago →
    🇺🇸United States SocialNicheGuru

    please add 🐛 Replace entitymanager with entityTypeManager RTBC to the MR to fix errors 32 and 37 in #20.

    Patch 16 is needed to add the access check

  • Comment 10 months ago →
    🇺🇸United States SocialNicheGuru

    Please add the following patches to the MR to get commerce_marketplace ready:

    1. to fix errors 32 and 37 in #20 please add 🐛 Replace entitymanager with entityTypeManager RTBC
    2. to upgrade all access checks please add 🐛 For D10 version: Update accessCheck Needs review
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024