- Issue created by @urvashi_vora
- Status changed to Needs work
about 1 year ago 12:10pm 4 October 2023 - 🇮🇳India ashutosh ahirwal India
I reviewed the provided patch.
There are some remaining error too after patch get applied cleanly.
Need to fix them too.
Moving to Need Works.Used command:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/lplRemaining issues
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/lpl/lpl.module
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
68 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "logo_per_language_validate" but expected "lpl_logo_per_language_validate"
101 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "validate_path" but expected "lpl_validate_path"
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------Time: 106ms; Memory: 10MB
- Status changed to Needs review
about 1 year ago 12:23pm 4 October 2023 - 🇮🇳India mrinalini9 New Delhi
Updated patch #1 by addressing #2, please review it.
Thanks!
- Status changed to RTBC
about 1 year ago 12:37pm 4 October 2023 - 🇧🇷Brazil elber Brazil
Hi I reviewed the last patch
The module keeps working normally
PHPCS errors has been fixed
Moving to RTBC -
abu-zakham →
committed 2b7de88b on 1.0.x authored by
mrinalini9 →
Issue #3373816 by mrinalini9: Fix the issues reported by phpcs
-
abu-zakham →
committed 2b7de88b on 1.0.x authored by
mrinalini9 →
- Status changed to Fixed
about 1 year ago 9:35am 5 October 2023 - 🇯🇴Jordan abu-zakham
Thanks, I have change the validate function name to lpl_validate instead of lpl_logo_per_language_validate and removed unwanted language_entities variable.
- Status changed to Fixed
about 1 year ago 9:35am 5 October 2023