t() calls should be avoided in class

Patch created. Please review it

There are still procedural t() calls in src/Plugin/Field/FieldWidget/XnumberWidget.php and src/Tests/XnumberFieldTest.php. Please fix them!

created a new patch for changing all the t() calls. Please review

Thanks for your contribution!

Please ignore t() in the src/Tests/XnumberFieldTest.php file. Instead you can create new Drupal 10 compatible test files here:

📌 Automated Drupal 10 compatibility fixes Fixed

Also, please follow fork -> merge request workflow which is the new way of making changes in the code:

https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... →

MR !4 raised to avoid t() calls inside class. please review

Hi @annmarysruthy,

I reviewed MR 4.

Steps performed while reviewing:-
1. Taken clone of issue branch
2. Reviewed the changes as per Merge Request 4.
3. I still got the "t() calls should be avoided in classes" error for /src/Tests/XnumberFieldTest.php.
4. Attaching the screenshot for reference.

Test Result:- Needs Work.
Moving it to Needs Work.

I am working on it, assigning it to myself.

Thanks for the work.

PLease review the MR.

Hi,

After the 2.0.0-beta1 release 8.x version of the module will not get changes anymore except critical ones.

Please, fix merge issues and do not forget to follow Drupal git commit guidelines.

Hint: Just copy it from the prompt below.

drugan → closed merge request !4

As you see it is still unmergeable.

Please, properly merge upstream first.

Please, fix Drupal coding standards errors introduced by your changes.

Anjali Mehta → made their first commit to this issue’s fork.

Added patch to fix warnings and errors reported by phpcode sniffer

Changes in the README.md file are not related to this issue which says:

t() calls should be avoided in class

Please revise

The module has good test coverage, please run tests before asking for review.

Please revise.

Please address the comment above.

please revise

Please revise again

rebase completed

Thanks everyone!

Automatically closed - issue fixed for 2 weeks with no activity.