Automated Drupal 10 compatibility fixes

The dependency on readmehelp (which is not yet Drupal 10 ready) will be removed by 📌 Remove dependencies on readmehelp and help module Fixed .

Pending tasks:

PHPstan --level 0 fixes

Note: Using configuration file /var/www/html/phpstan.neon.
9/9 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ------------------------------------------------------------------------------------------
Line src/Tests/XnumberFieldTest.php
------ ------------------------------------------------------------------------------------------
150 Access to an undefined property Drupal\xnumber\Tests\XnumberFieldTest::$url.
489 Call to an undefined method Drupal\xnumber\Tests\XnumberFieldTest::drupalPostAjaxForm().
496 Call to an undefined method Drupal\xnumber\Tests\XnumberFieldTest::drupalPostAjaxForm().
515 Call to an undefined method Drupal\xnumber\Tests\XnumberFieldTest::drupalPostAjaxForm().
520 Call to an undefined method Drupal\xnumber\Tests\XnumberFieldTest::drupalPostAjaxForm().
756 Access to an undefined property Drupal\xnumber\Tests\XnumberFieldTest::$url.
------ ------------------------------------------------------------------------------------------

Resolve depending issues

• 📌 Remove dependencies on readmehelp and help module Fixed

Update core version requirement

Increase minimum core version requirement to ^9.3 || ^10 as 9.3 is the first version supporting PHP 8.1, the minimum for Drupal 10.

The Call to an undefined method Drupal\Tests\xnumber\Functional\XnumberFieldTest::drupalPostAjaxForm() occurrences require a major rewrite of the tests, see

• Instructions for converting a Simpletest web test →
  
  

  drupalPostAjaxForm() doesn't exist on BrowserTestBase and can usually be replaced with drupalPostForm() this does mean a loss of pseudo-JavaScript coverage, so ideally a follow up should be created to add proper JavaScript coverage using WebdriverTestBase

• drupalPostForm() is deprecated and will be removed in Drupal 10 →

In addition I found used but uninitialized variables in the tests, which also needs to be fixed.

@mvonfrie

Let's make it compatible with the ^9.5 || ^10 versions.

You can commit --amend and then push --force into your MR branch.

Hi @shivam_tiwari,

The readmehelp dependency is already fixed on the 2.0.x branch. Additionally, to make the module fully compatible with the core's ^10 version wee need to rewrite the XnumberFieldTest.php. See #17 comment.

Because we have the Extended number field types so at the very least we need guarantee the Drupal Core functionality for these types.

For the beginning you can just copy two files below into our Tests folder. Then replace 'integer', 'decimal', 'float' field types in the files for our 'xinteger', 'xdecimal' and 'xfloat'.

The same with the field widget type: 'number' -> 'xnumber'. After that just create a list of what we've extended in the core's functionality and add specific test methods for that in the files:

https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/fie...

https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/fie...

The test is failing:

drugan@my-xnumber-web:/var/www/html$ vendor/bin/phpunit -c web/core/ web/modules/contrib/xnumber/
PHPUnit 9.6.11 by Sebastian Bergmann and contributors.

Testing /var/www/html/web/modules/contrib/xnumber
EREEEE                                                              6 / 6 (100%)E

Time: 00:10.036, Memory: 4.00 MB

There were 6 errors:

1) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testNumberIntegerField
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:427
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:556
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/xnumber/tests/src/Functional/XnumberFieldTest.php:29
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

2) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testNumberDecimalField
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:427
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:556
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/xnumber/tests/src/Functional/XnumberFieldTest.php:29
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

3) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testNumberFloatField
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:427
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:556
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/xnumber/tests/src/Functional/XnumberFieldTest.php:29
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

4) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testNumberFormatter
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:427
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:556
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/xnumber/tests/src/Functional/XnumberFieldTest.php:29
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

5) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testCreateNumberFloatField
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:427
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:556
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/xnumber/tests/src/Functional/XnumberFieldTest.php:29
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

6) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testCreateNumberDecimalField
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:427
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:556
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/xnumber/tests/src/Functional/XnumberFieldTest.php:29
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

--

There was 1 risky test:

1) Drupal\Tests\xnumber\Functional\XnumberFieldTest::testNumberIntegerField
This test did not perform any assertions

/var/www/html/web/core/tests/Drupal/Tests/Listeners/DrupalListener.php:65
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:452
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/var/www/html/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:144
/var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:97

ERRORS!
Tests: 6, Assertions: 0, Errors: 6, Risky: 1.

I've ran functional and javascript test on 9.4 and 10.1.2 versions.

I am not sure if there is any sense to merge these changes into 8.x version of the module? If it's true please someone merge upstream and run both tests on the latest 8.x core version to verify that is working there too.

I am going to make 2.0.0-beta1 release tomorrow.

Done.

Thanks everyone!

drugan → closed merge request !6