- 🇦🇹Austria mvonfrie
Meanwhile as #2946807 is still in development, the hard dependency in xnumber and other modules could be changed into a soft dependency by applying the patch from @tim-diels and suggesting it in composer.json by adding:
"suggest": { "drupal/readmehelp": "Allows automatically to display module's README file on the admin/help/your_module page." }
This way it will be easier to upgrade the modules to Drupal 10 as well, because the readmehelp module can be upgraded seperately.
- Status changed to Needs review
almost 2 years ago 5:24pm 24 February 2023 - 🇪🇪Estonia drugan
Hi guys,
Please also check for relative links pointing to the module's help page on a site (
src/Plugin/Field/FieldType/XnumericItemBase.php
). You can grep it using the following pattern:\/admin\/help\/xnumber
The links can be replaced by absolute ones pointing to the module's
README.md
on the https://git.drupalcode.org site. For example:Top of the file: https://git.drupalcode.org/project/xnumber/-/blob/8.x-1.x/README.md
Hash link to a some specific section: https://git.drupalcode.org/project/xnumber/-/blob/8.x-1.x/README.md#fiel...
Also, please change the branch to merge into for the
2.0.x
one. You can do it on the MR overview page using "Edit" tab.We do not continue development on the
8.x-1.x
branch anymore except critical fixes. - Status changed to Needs work
almost 2 years ago 8:14am 27 February 2023 - 🇦🇹Austria mvonfrie
@drugan, shouldn't we better link directly to the 2.0.x branch (https://git.drupalcode.org/project/xnumber/-/blob/2.0.x/README.md) then?
- @mvonfrie opened merge request.
-
mvonfrie →
committed 4a856467 on 2.0.x authored by
tim-diels →
Issue #3133932 by tim-diels: Remove dependencies on readmehelp and help...
-
mvonfrie →
committed 4a856467 on 2.0.x authored by
tim-diels →
-
mvonfrie →
committed 84c9498c on 2.0.x
Issue #3133932 by mvonfrie: Add readmehelp as optional dependency (...
-
mvonfrie →
committed 84c9498c on 2.0.x
- Status changed to Fixed
almost 2 years ago 6:25pm 27 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.