- Issue created by @uttam
- ๐ฎ๐ณIndia Shreya_98
Shreya_th โ made their first commit to this issueโs fork.
- @shreya_th opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:35am 11 September 2023 - ๐ฎ๐ณIndia bebalachandra
Tested Patch #6 on drupal 10.1.
As stated in description error is reproducible using the steps below
1. Go to this path : admin/config/content/node-title-validation
2. Configure the module by filling up the required inputs
3. Save the module configurations
4. You will get an errorAttached Before patch screen recording and screenshots for reference.
After applying patch #6 error resolved successfully. I am able to configure the module and messenger is coming up when clicked on save button. MessengerInterface is implemented successfully.
We can move this to RTBC+1.
- Status changed to RTBC
over 1 year ago 10:27am 19 September 2023 I think the issue is fixed now...requesting maintainers to set the status to fixed
- Status changed to Needs review
over 1 year ago 3:57am 20 September 2023 - ๐ณ๐ดNorway gisle Norway
Nothing has been committed, so nothing is fixed.
We need more reviews. Best practice is to never set status RTBC for your own patch.
- ๐ฎ๐ณIndia bebalachandra
Reviewed MR!10 on drupal 10.1 on my local. this MR will resolve the issue reported here. Thanks @gisle for highlighting the MR which I have not considered while reviewing. compared both MR!10 and patch #6. patch #6 carries the same changes which are there in MR!10.
- ๐ณ๐ดNorway gisle Norway
bebalachandra, thank you for taking the extra time to review the MR. This is not the first time uttam has done somerhing like this. We should take care that users that duplicate work already done by others does not receive any issue credit.
- Status changed to Fixed
over 1 year ago 9:18am 20 September 2023 - Status changed to RTBC
over 1 year ago 9:20am 20 September 2023 @gisle I don't have that intention actually I am very new to this community,not familier much...I just provided the patch after reviewing the MR and the issue was created by me....I will take care of it in future
- Status changed to Closed: outdated
over 1 year ago 9:35am 20 September 2023 - Status changed to Needs review
over 1 year ago 9:44am 20 September 2023 - ๐ณ๐ดNorway gisle Norway
uttam, as a new user here, you need to more careful when working in the issue queues Take a few momements to read up on Issue Etiquette โ .
Your two latest three changes of issue Status after I reprimanded you (first to "Fixed", then to "Reviewed & tested by the community", and latest to "Closed (outdated)" clearly shows that you've absolutely no idea about how to go about these things. These are disruptive changes.
I am a site moderator here and I have started watching you. I have for instance noticed that you've committed a lot of empty commits MRs (I have deleted most of them). These are trash posts. You also may want to read up on our policy on trash posts: https://www.drupal.org/drupalorg/docs/maintenance/moderating-users#s-blo... โ If you do not stop misbehaving, you will be blocked from posting on this site.
- Status changed to RTBC
over 1 year ago 10:26am 20 September 2023 - ๐ง๐ทBrazil elber Brazil
Hi I reviewed the changes in the MR.
I followed the steps below:
1. Go to this path : admin/config/content/node-title-validation
2. Configure the module by filling up the required inputs
3. Save the module configurationsChanges in the MR applied cleanly
modue is working as expected ( we can set the config normally)
Moving to RTBC.