Drupal version: 10.3.2
Php version: 8.2
Module version: redirect 8.x-1.x-dev
I have tried to replicate the issue but not able to reproduce the same. I have enabled "Automatically create redirects when URL aliases are changed." in the redirect settings. Created a content with url alias /TEST and then updated the url to /TEst, after this the redirects from /TEST to /TEst and it's working properly without any redirect loop.
Drupal version : 11.0.1
PHP version : 8.3.6
Module version : 2.0.x-dev
I have tested the patch from the MR !14, it resolves the error which is occuring in config form (admin/config/alr-configuration).
Moving the issue to RTBC!
I have tested the MR !28 given by r@aveen_thakur51, it resolves the argument count error which was occuring while visting the form at "/admin/config/reading-time"
Moving this to RTBC!
Hello @jminarick, I have tested the patch from MR !8, the "Create new account" tab present in the login page is enabling/disabling as per the settings provided in the "/admin/config/people/hybrid_login" form.
@sourav_paul Hello I have resolved the fatal error and tested the same in d10 and d11, the circular redirects are successfully purging. Please review this once.
Moving this to Needs Review
Hello @Berdir, I hope you're doing well. This issue has remained unresolved for a few days, can this be fixed now?
Hello @kuzyawkk, I have applied the patch from MR !7, it's looking fine for me. Now we can configure the cancel button only to appear in node creation form and that will not appear in the content edit form.
Moving this issue to RTBC.
Thanks!
@sourav_paul Added the access check condition in the code, now the fatal error is not showing while merging terms.
@shelane Thanks for fixing the issue!
Hello,I have tested the MR 13 and haven't found any depreciated function using the upgrade status module. The MR is working fine in Drupal 11,I think it's now ready for Drupal 11 release, moving this ticket to RTBC.
Thank you
uttam → made their first commit to this issue’s fork.
uttam → made their first commit to this issue’s fork.
Hello everyone, I have created this Drupal Drush command which facilitates the management of circular redirects using Drush as mentioned in the issue. Firstly, It retrieves all redirect entities from the database using EntityTypeManagerInterface
, constructs a map linking source URLs to their corresponding destinations, identifies circular redirect relationships where a redirect points back to its own source. I have also logged each detected circular redirect using Psr\Log\LoggerInterface
and provides a user prompt to confirm the delete operation. Upon confirmation, it deletes all identified circular redirect records.
Drush command for the purging circular redirects: drush redirect:purge-circular-redirects
Please review this.
uttam → made their first commit to this issue’s fork.
Hello everyone,
I have cloned the branch 3250412-new-action-needed and tested the functionality. A new action, "Generate One Time Login Links," has been created for users. This action allows us to generate one-time login links for multiple users in bulk, as described in the issue. The functionality works fine for me!
Moving this to RTBC.
The changes I have made in the controller includes, edit and delete URLs are generated using Url::fromRoute()
and corresponding Link objects are created, and these links are included in an $actions
array which is then rendered and included in the table rows for display. additionally, I have also included injecting the database connection via dependency injection by using use Drupal\Core\Database\Connection
and Symfony\Component\DependencyInjection\ContainerInterfac
e, rather than directly using Database::getConnection()
Please review the MR.
uttam → made their first commit to this issue’s fork.
I updated the validateForm method by adding a check to ensure that the redirect_url starts with '/', '?', or '#'. If it doesn't, an error message is set for the corresponding form element, indicating that the redirect URL for the specified role must begin with one of these characters. The other existing code logic remain unchanged.
Please review this.
have applied patch #7, but the error persists: "InvalidArgumentException: The user-entered string 'node/2' must begin with a '/', '?', or '#'. in Drupal\Core\Url::fromUserInput() (line 216 of core/lib/Drupal/Core/Url.php)." I believe we need to add validation in RedirectUrlSettingsForm.php
. Moving this to NW and assigning it to myself.
Hello @samit.310@gmail.com,
I have reviewed the patch from the MR !18 again, now the configurable logout message is visible after disconnecting a particular session. This works fine now.
Thanks!
Moving this to RTBC
I've created a custom permission called 'Bypass entity view redirect' and implemented it in an event subscriber to check with $this->currentUser->hasPermission('bypass entity view redirect')
. If the user possesses this permission, the redirection logic is bypassed. I've also included the current user service in the event subscriber and updated the services.yml accordingly. This successfully bypasses redirection for all roles except administrators, who have this permission assigned by default
Please review this
uttam → made their first commit to this issue’s fork.
Hi @samit.310@gmail.com, applied the patch from the MR, the textarea for configurable logout message is visible at "/admin/config/people/session-limit", but when disconnencting a particular session from the session limit form (/session-limit), the configured logout message is not showing for this particular disconnect session.please check this once, thank you.
Hello @KuzyaWkk, I have tested the latest commit as given in #5 on local, it's working as expected now. Not getting the console error. Thanks!
Moving this to RTBC.
I have tested MR #2 and confirmed that the auto login functionality for users is working as described in the issue. Users can be auto-logged into their desired accounts as intended. However, I encountered a console error when selecting a user from the autocomplete form and saving the configuration for the first time. Despite the error, the configuration saves correctly on a subsequent attempt, and the auto login works as expected.
After investigating the issue, it appears that the problem is related to the ajaxCallback function in the form. By returning $form['container'] from the ajaxCallback function, we can resolve this issue. Here’s the updated function:
public function ajaxCallback(array &$form, FormStateInterface $form_state): array {
return $form['container'];
}
This change ensures that the correct part of the form is returned, preventing the console error and allowing the form to work correctly on the first save attempt.
I am attaching a screencast to demonstrate the issue and moving this to NW.
Tested the enable/disable feature provided in @KevinVb's MR. It works well for me. We can now enable or disable this functionality for menus, terms, and media as needed. Moving this to RTBC. Thanks!
The error is not showing after attaching the patch from the MR of @abhishek_gupta, LGTM
Moving it to RTBC
Yes @debra-v, Iater I have noticed that warning of undefined $row variable, which was resolved after attaching the patch from the MR of @abhisek_gupta1.
Moving this to RTBC
Thanks!
I was going through the same issue, I think the redirection for path aliases is not working with this module, so i guess when you are trying to redirect from an aliased path, let assume from /a to /b it will not work but if try to add the redirect with the node ids like from /node/1 to /node/2 the redirection will heppen and your unpublished content can be redirected to a published content as per your requirement.
But if you want to add the redirections from alias to alias then you can try the patch given in comment number
#142 →
of
this →
issue.
I think this will resolve the problem you are facing now Please let us know whether it's working for you or not.
Thanks
Drupal version: 10.2.7
PHP version: 8.1.28
Installed the module version 2.0.2, but not able to reproduce the error on my local and the logging functionality is also working fine.
@aaron.ferris Yes, later I have gone through that issue too, Thanks.
On visiting the route /admin/group/groupmenu, previously it was showing a Argument count error due to not passing any argument to the parent constructor of GroupMenuSettingsForm.php, after after the patch from this MR the error was resolved, Moving this to RTBC
Thanks!
hi @aaron.ferris,
I have tested the MR from here the fatal errors relarted to "Type of Drupal\groupmenu\Controller\GroupMenuController" are not showing now one module installations and while performing group related task, but on /admin/group/groupmenu route it's showing a Argument count error, is related to this issue or we need to create a separate issue for this and solve there.
Thanks!
Faced this problem while using views_ajax_history in a view of D11 setup, applied the MR patch from here that resolved the problem by replacing the array call.
Moving this to RTBC.
Hello all,
I have applied the MR from here and followed the mentioned steps of this issue, now it's look like the problem is fixed now, moving is to RTBC. I am attaching the screencast also.
Hi @maintainers,
Any updates on this. Can this is fixed now?
uttam → created an issue.
Tested the patch from this MR, when the checkbox is set by default i.e false user will be able to change the username and when the checkbox set as true i.e checked the username can not be edited.
Was going through this same problem, the module wasn't working with path aliases for the redirection. The patch
#142 →
works for me.
Thanks @Rajab Natshah
Hello @cweiske,
I have tested your MR from here and it's looks fine, rendering the html webform html correctly, moving this to RTBC.
Thank you
Hello all,
Couldn't reproduce the error, no entity query error are showing after installing the module and creating new webform, I think it was fixed in later commits as mentioned by @Nigel.
Thank you.
Hello @dabley I have tested your patch as mentioned by you in the issue #3311345 and that works fine for me, updated the status of that issue.
Thank you
I have tested the patch https://git.drupalcode.org/project/term_merge/-/merge_requests/7.diff and it's look good for me. Beside the term name term id's are added with a link reference to that particular term which will surely provide better user experience to select term from the checkbox if those terms has similar kind of name.
uttam → made their first commit to this issue’s fork.
Please review the Merge request.
This issue is in same state for last few months could anyone please changed the status and make this issue fixed(closed) if everything works well.
uttam → made their first commit to this issue’s fork.
@maintainers Can this issue be closed(fixed) now ?
please check
uttam → made their first commit to this issue’s fork.
uttam → made their first commit to this issue’s fork.
After uninstalling module the password is cleared from the smtp.settings configuration and we need to set the password again.
@vipin.mittal18 Thanks for merging the MR.
uttam → made their first commit to this issue’s fork.
uttam → made their first commit to this issue’s fork.
uttam → made their first commit to this issue’s fork.
uttam → made their first commit to this issue’s fork.
uttam → made their first commit to this issue’s fork.
uttam → created an issue.
Please review the MR
uttam → made their first commit to this issue’s fork.
The title already given in the field:contents column besides the entity column.
@maintainers Please check the MR i had raised for this issue for the feature request.
with the proposed resolution given in the issue the problem was fixed, the mail is sending to default address if no other email sending options are select and raised a merge request.
uttam → made their first commit to this issue’s fork.
uttam → made their first commit to this issue’s fork.
uttam → made their first commit to this issue’s fork.
uttam → created an issue.
There are some pipeline error occuring after create a new branch here can anyone please tell why it is showing.
I found some dependency related errors while testing in my local using phpcs where dependency was not injected.
uttam → made their first commit to this issue’s fork.
@dharmendra_saini trying to create the dynamic role based redirection from a separate branch, implemented the functionality but merge errors occurs due to conflict in the file. Could you please help me on this?
Hi @quyenla can this issue be fixed now or needs some work?
Yes I was going through the entityqueue module and i feel that it would be nice if there is a option to select the content types for subqueues too.