Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 5 February 2024, about 1 year ago

After setting the Gitlab CI configuration, I see a lot of issues reported by phpcs that need to be addressed:

$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/fluidui/

FILE: /home/daniel/websites/dls-redesign/web/modules/contrib/fluidui/infusion/ReleaseNotes.md
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------
  9 | WARNING | Line exceeds 80 characters; contains 100 characters
 29 | WARNING | Line exceeds 80 characters; contains 214 characters
 37 | WARNING | Line exceeds 80 characters; contains 154 characters
 47 | WARNING | Line exceeds 80 characters; contains 88 characters
---------------------------------------------------------------------------------------------


FILE: /home/daniel/websites/dls-redesign/web/modules/contrib/fluidui/src/Form/FluidConfigForm.php
-----------------------------------------------------------------------------------------------------
FOUND 29 ERRORS AFFECTING 27 LINES
-----------------------------------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
  2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
  2 | ERROR | [x] Whitespace found at end of line
  3 | ERROR | [x] Whitespace found at end of line
  4 | ERROR | [x] Whitespace found at end of line
  5 | ERROR | [x] Whitespace found at end of line
  7 | ERROR | [x] There must be one blank line after the namespace declaration
 11 | ERROR | [x] Missing class doc comment
 12 | ERROR | [x] Whitespace found at end of line
 13 | ERROR | [x] Whitespace found at end of line
 14 | ERROR | [x] Whitespace found at end of line
 15 | ERROR | [x] Expected 1 blank line before function; 0 found
 15 | ERROR | [x] Expected 1 space before opening brace; found 0
 21 | ERROR | [x] Whitespace found at end of line
 22 | ERROR | [x] Whitespace found at end of line
 23 | ERROR | [x] Whitespace found at end of line
 24 | ERROR | [x] Expected 1 space before opening brace; found 0
 28 | ERROR | [x] Whitespace found at end of line
 29 | ERROR | [x] Whitespace found at end of line
 30 | ERROR | [x] Whitespace found at end of line
 31 | ERROR | [x] Expected 1 space before opening brace; found 0
 41 | ERROR | [x] Short array syntax must be used to define arrays
 45 | ERROR | [x] Whitespace found at end of line
 51 | ERROR | [x] Whitespace found at end of line
 52 | ERROR | [x] Whitespace found at end of line
 53 | ERROR | [x] Whitespace found at end of line
 54 | ERROR | [x] Expected 1 space before opening brace; found 0
 64 | ERROR | [x] Expected 1 blank line after function; 0 found
 65 | ERROR | [x] The closing brace for the class must have an empty line before it
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 29 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------


FILE: /home/daniel/websites/dls-redesign/web/modules/contrib/fluidui/fluidui.links.menu.yml
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: /home/daniel/websites/dls-redesign/web/modules/contrib/fluidui/fluidui.module
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 32 ERRORS AFFECTING 21 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
  23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  25 | ERROR | [x] No space found before comment text; expected "// the url blacklist takes precedence" but found "//the url blacklist takes
     |       |     precedence"
  25 | ERROR | [x] Inline comments must start with a capital letter
  25 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  26 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
  31 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
  32 | ERROR | [x] No space found before comment text; expected "// display the widget on all pages." but found "//display the widget on all
     |       |     pages."
  32 | ERROR | [x] Inline comments must start with a capital letter
  35 | ERROR | [x] Whitespace found at end of line
  36 | ERROR | [x] Expected newline after closing brace
  37 | ERROR | [x] No space found before comment text; expected "// don't display the widget on the admin pages." but found "//don't display
     |       |     the widget on the admin pages."
  41 | ERROR | [x] Whitespace found at end of line
  48 | ERROR | [x] No space found before comment text; expected "// use latest version from /libraries/infusion" but found "//use latest
     |       |     version from /libraries/infusion"
  48 | ERROR | [x] Inline comments must start with a capital letter
  48 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  50 | ERROR | [x] Expected newline after closing brace
  51 | ERROR | [x] No space found before comment text; expected "// use module version" but found "//use module version"
  51 | ERROR | [x] Inline comments must start with a capital letter
  51 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 100 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 102 | ERROR | [x] No space found before comment text; expected "// the url blacklist takes precedence" but found "//the url blacklist takes
     |       |     precedence"
 102 | ERROR | [x] Inline comments must start with a capital letter
 102 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 103 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
 109 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
 113 | ERROR | [x] Expected newline after closing brace
 114 | ERROR | [x] No space found before comment text; expected "// Don't display the widget on the admin pages." but found "//Don't display
     |       |     the widget on the admin pages."
 139 | ERROR | [x] No space found before comment text; expected "// verify if /libraries/infusion exists" but found "//verify if
     |       |     /libraries/infusion exists"
 139 | ERROR | [x] Inline comments must start with a capital letter
 139 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 154 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 32 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/daniel/websites/dls-redesign/web/modules/contrib/fluidui/fluidui.routing.yml
----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------
 9 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------

Time: 2.01 secs; Memory: 30MB

FILE: /home/daniel/websites/dls-redesign/web/modules/contrib/fluidui/infusion/src/components/textfieldControl/css/TextfieldSlider.css
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 34 ERRORS AFFECTING 34 LINES
-------------------------------------------------------------------------------------------------------------------------------------
   2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
   3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
   4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 107 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 111 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 34 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/daniel/websites/dls-redesign/web/modules/contrib/fluidui/infusion/src/components/switch/css/Switch.css
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------


FILE: /home/daniel/websites/dls-redesign/web/modules/contrib/fluidui/infusion/src/components/tableOfContents/css/TableOfContents.css
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------

There's a bunch of issues reported in the included css files, which I'll probably drop from the project

📌 Task
Status

Active

Version

2.0

Component

Code

Created by

🇨🇦Canada danrod Ottawa

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @danrod
  • Assigned to pray_12
  • Comment about 1 year ago →
    🇮🇳India pray_12
  • Issue was unassigned.
  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India pray_12

    Hi,
    I have addressed some of the errors, but there are still a few remaining that need to be fixed.

    FILE: /fluidui/infusion/ReleaseNotes.md
--------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------
  9 | WARNING | Line exceeds 80 characters; contains 100 characters
 29 | WARNING | Line exceeds 80 characters; contains 214 characters
 37 | WARNING | Line exceeds 80 characters; contains 154 characters
 47 | WARNING | Line exceeds 80 characters; contains 88 characters
--------------------------------------------------------------------------------------------


FILE: /fluidui/infusion/README.md
--------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 49 WARNINGS AFFECTING 49 LINES
--------------------------------------------------------------------------------------
   4 | WARNING | Line exceeds 80 characters; contains 114 characters
   8 | WARNING | Line exceeds 80 characters; contains 83 characters
  22 | WARNING | Line exceeds 80 characters; contains 214 characters
  29 | WARNING | Line exceeds 80 characters; contains 84 characters
  33 | WARNING | Line exceeds 80 characters; contains 114 characters
  36 | WARNING | Line exceeds 80 characters; contains 99 characters
  45 | WARNING | Line exceeds 80 characters; contains 120 characters
  52 | WARNING | Line exceeds 80 characters; contains 117 characters
  53 | WARNING | Line exceeds 80 characters; contains 111 characters
  62 | WARNING | Line exceeds 80 characters; contains 120 characters
  67 | WARNING | Line exceeds 80 characters; contains 87 characters
  68 | WARNING | Line exceeds 80 characters; contains 134 characters
  69 | WARNING | Line exceeds 80 characters; contains 124 characters
  73 | WARNING | Line exceeds 80 characters; contains 82 characters
  75 | WARNING | Line exceeds 80 characters; contains 130 characters
  82 | WARNING | Line exceeds 80 characters; contains 100 characters
  92 | WARNING | Line exceeds 80 characters; contains 118 characters
  93 | WARNING | Line exceeds 80 characters; contains 84 characters
 101 | WARNING | Line exceeds 80 characters; contains 120 characters
 115 | WARNING | Line exceeds 80 characters; contains 111 characters
 154 | WARNING | Line exceeds 80 characters; contains 119 characters
 155 | WARNING | Line exceeds 80 characters; contains 118 characters
 202 | WARNING | Line exceeds 80 characters; contains 113 characters
 207 | WARNING | Line exceeds 80 characters; contains 99 characters
 209 | WARNING | Line exceeds 80 characters; contains 88 characters
 211 | WARNING | Line exceeds 80 characters; contains 123 characters
 212 | WARNING | Line exceeds 80 characters; contains 118 characters
 214 | WARNING | Line exceeds 80 characters; contains 118 characters
 217 | WARNING | Line exceeds 80 characters; contains 91 characters
 219 | WARNING | Line exceeds 80 characters; contains 145 characters
 220 | WARNING | Line exceeds 80 characters; contains 182 characters
 222 | WARNING | Line exceeds 80 characters; contains 117 characters
 223 | WARNING | Line exceeds 80 characters; contains 118 characters
 228 | WARNING | Line exceeds 80 characters; contains 118 characters
 231 | WARNING | Line exceeds 80 characters; contains 86 characters
 243 | WARNING | Line exceeds 80 characters; contains 120 characters
 245 | WARNING | Line exceeds 80 characters; contains 118 characters
 248 | WARNING | Line exceeds 80 characters; contains 117 characters
 249 | WARNING | Line exceeds 80 characters; contains 113 characters
 254 | WARNING | Line exceeds 80 characters; contains 113 characters
 255 | WARNING | Line exceeds 80 characters; contains 117 characters
 256 | WARNING | Line exceeds 80 characters; contains 116 characters
 257 | WARNING | Line exceeds 80 characters; contains 87 characters
 260 | WARNING | Line exceeds 80 characters; contains 109 characters
 261 | WARNING | Line exceeds 80 characters; contains 112 characters
 262 | WARNING | Line exceeds 80 characters; contains 119 characters
 268 | WARNING | Line exceeds 80 characters; contains 116 characters
 271 | WARNING | Line exceeds 80 characters; contains 113 characters
 278 | WARNING | Line exceeds 80 characters; contains 116 characters
--------------------------------------------------------------------------------------


FILE:/fluidui/README.md
-----------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
-----------------------------------------------------------------------------
 56 | WARNING | Line exceeds 80 characters; contains 98 characters
 58 | WARNING | Line exceeds 80 characters; contains 99 characters
 60 | WARNING | Line exceeds 80 characters; contains 90 characters
 70 | WARNING | Line exceeds 80 characters; contains 89 characters
 71 | WARNING | Line exceeds 80 characters; contains 97 characters
 85 | WARNING | Line exceeds 80 characters; contains 83 characters
 87 | WARNING | Line exceeds 80 characters; contains 108 characters
-----------------------------------------------------------------------------


FILE: /fluidui/fluidui.routing.yml
------------------------------------------------------------------------------------------------------------------------------------------------------------FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------ 7 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user can change something - rather
   |         | than "access administration pages" which is about viewing but not changing configurations.
------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: +/fluidui/fluidui.module
------------------------------------------------------------------------------------------------------------------------------------------------------------FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------ 66 | ERROR | The $_COOKIE super global must not be accessed directly; inject the request_stack service and use
    |       | $stack->getCurrentRequest()->cookies->get('fluid-ui-settings') instead
 67 | ERROR | The $_COOKIE super global must not be accessed directly; inject the request_stack service and use
    |       | $stack->getCurrentRequest()->cookies->get('fluid-ui-settings') instead
------------------------------------------------------------------------------------------------------------------------------------------------------------
  • First commit to issue fork.
  • Merge request !73419340-resolving-phpcs-errors: Resolved the phpcs errors. → (Closed) created by uttam
  • Comment about 1 year ago →
    🇮🇳India anjali mehta

    Anjali Mehta → made their first commit to this issue’s fork.

  • Assigned to nitin_lama
  • Comment about 1 year ago →
    🇮🇳India nitin_lama India
  • Comment about 1 year ago →
    🇮🇳India nitin_lama India

    Fixed remaining issues. Please review.

  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India nitin_lama India
  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇵🇭Philippines clarkssquared

    Hi

    I applied the updated MR !7 and there are still many PHPCS issues that the PHPCS flagged.

    ➜  fluidui git:(2.0.x) curl https://git.drupalcode.org/project/fluidui/-/merge_requests/7.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  496k    0  496k    0     0   458k      0 --:--:--  0:00:01 --:--:--  461k
patching file README.md
patching file fluidui.install
patching file fluidui.links.menu.yml
patching file fluidui.module
patching file fluidui.routing.yml
patching file 'infusion/README.md'
patching file 'infusion/ReleaseNotes.md'
patching file 'infusion/src/components/tableOfContents/css/TableOfContents.css'
patching file 'infusion/src/components/textfieldControl/css/TextfieldSlider.css'
patching file 'infusion/src/components/textfieldControl/css/TextfieldStepper.css'
patching file 'infusion/src/framework/core/css/fluid.css'
patching file 'infusion/src/framework/core/css/fluidDebugging.css'
patching file 'infusion/src/framework/enhancement/css/ProgressiveEnhancement.css'
patching file 'infusion/src/lib/jquery/ui/css/default-theme/jquery-ui.css'
patching file 'infusion/src/lib/jquery/ui/css/fl-theme-bw/bw.css'
patching file 'infusion/src/lib/jquery/ui/css/fl-theme-by/by.css'
patching file 'infusion/src/lib/jquery/ui/css/fl-theme-dglg/dglg.css'
patching file 'infusion/src/lib/jquery/ui/css/fl-theme-lgdg/lgdg.css'
patching file 'infusion/src/lib/jquery/ui/css/fl-theme-wb/wb.css'
patching file 'infusion/src/lib/jquery/ui/css/fl-theme-yb/yb.css'
patching file 'src/Form/FluidConfigForm.php'
➜  fluidui git:(2.0.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml fluidui

FILE: ...ubing/Projects/d9/d9-local/web/modules/contrib/fluidui/fluidui.routing.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | WARNING | The administration page callback should probably use "administer
   |         | site configuration" - which implies the user can change
   |         | something - rather than "access administration pages" which is
   |         | about viewing but not changing configurations.
--------------------------------------------------------------------------------


FILE: ...uidui/infusion/src/framework/preferences/css/SeparatedPanelPrefsEditor.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------


FILE: ...luidui/infusion/src/framework/preferences/css/FullNoPreviewPrefsEditor.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------


FILE: ...contrib/fluidui/infusion/src/framework/preferences/css/FullPrefsEditor.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------


FILE: ...odules/contrib/fluidui/infusion/src/framework/preferences/css/Enactors.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------


FILE: .../fluidui/infusion/src/framework/preferences/css/FullPreviewPrefsEditor.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------


FILE: ...les/contrib/fluidui/infusion/src/framework/preferences/css/PrefsEditor.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------


FILE: .../infusion/src/framework/preferences/css/SeparatedPanelPrefsEditorFrame.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------


FILE: .../fluidui/infusion/src/framework/enhancement/css/ProgressiveEnhancement.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | Class definition is empty
--------------------------------------------------------------------------------


FILE: ...modules/contrib/fluidui/infusion/src/framework/core/css/fluidDebugging.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 70 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------


FILE: ...ocal/web/modules/contrib/fluidui/infusion/src/framework/core/css/fluid.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 21 | ERROR | More than 2 empty lines are not allowed
--------------------------------------------------------------------------------


FILE: .../web/modules/contrib/fluidui/infusion/src/components/switch/css/Switch.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------

Time: 1.35 secs; Memory: 26MB

➜  contrib git:(master) ✗
  • Comment about 1 year ago →
    🇮🇳India zkhan.aamir
  • First commit to issue fork.
  • First commit to issue fork.
  • Comment about 1 year ago →
    🇮🇳India zkhan.aamir

    Issue summary updated.

  • Comment 2 months ago →
    🇨🇦Canada danrod Ottawa

    I'll have to change the .gitlab-ci.yml to ignore the local infusion library for the tests. I will look into this today.

  • Comment 2 months ago →
    🇨🇦Canada danrod Ottawa

    I'll be reviewing this today and I am having a hard time merging the latest 2.0.x with these branches.

  • Comment 2 months ago →
    🇨🇦Canada danrod Ottawa
  • Comment 2 months ago →
    🇨🇦Canada danrod Ottawa

    I will have to close these MR's but no worries, I will still give the credits. I just need to clean up this issue a bit.

  • Comment 2 months ago →
    System Message
  • Merge request !12Issue # 3419340: Fix issues reported by PHPCS → (Merged) created by danrod
  • Pipeline finished with Failed
    2 months ago
    #428642
  • Comment 2 months ago →
    🇨🇦Canada danrod Ottawa

    I fixed the issues reported by Gitlab CI for the branch 2.0.x, we will have to do the same for the branch 3.0.x, but given the huge differences between two branches, I'll have to open a new issue page for the 3.0.x.

    https://git.drupalcode.org/project/fluidui/-/merge_requests/12

    Thanks a lot to everyone involved !

  • Comment 2 months ago →
    🇨🇦Canada danrod Ottawa
  • Comment 2 months ago →
    🇨🇦Canada danrod Ottawa
  • Comment 2 months ago →
    🇨🇦Canada danrod Ottawa
  • Comment about 2 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024