- Issue created by @danrod
- Assigned to pray_12
- Issue was unassigned.
- Status changed to Needs work
10 months ago 5:16am 6 February 2024 - 🇮🇳India pray_12
Hi,
I have addressed some of the errors, but there are still a few remaining that need to be fixed.FILE: /fluidui/infusion/ReleaseNotes.md -------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------------------- 9 | WARNING | Line exceeds 80 characters; contains 100 characters 29 | WARNING | Line exceeds 80 characters; contains 214 characters 37 | WARNING | Line exceeds 80 characters; contains 154 characters 47 | WARNING | Line exceeds 80 characters; contains 88 characters -------------------------------------------------------------------------------------------- FILE: /fluidui/infusion/README.md -------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 49 WARNINGS AFFECTING 49 LINES -------------------------------------------------------------------------------------- 4 | WARNING | Line exceeds 80 characters; contains 114 characters 8 | WARNING | Line exceeds 80 characters; contains 83 characters 22 | WARNING | Line exceeds 80 characters; contains 214 characters 29 | WARNING | Line exceeds 80 characters; contains 84 characters 33 | WARNING | Line exceeds 80 characters; contains 114 characters 36 | WARNING | Line exceeds 80 characters; contains 99 characters 45 | WARNING | Line exceeds 80 characters; contains 120 characters 52 | WARNING | Line exceeds 80 characters; contains 117 characters 53 | WARNING | Line exceeds 80 characters; contains 111 characters 62 | WARNING | Line exceeds 80 characters; contains 120 characters 67 | WARNING | Line exceeds 80 characters; contains 87 characters 68 | WARNING | Line exceeds 80 characters; contains 134 characters 69 | WARNING | Line exceeds 80 characters; contains 124 characters 73 | WARNING | Line exceeds 80 characters; contains 82 characters 75 | WARNING | Line exceeds 80 characters; contains 130 characters 82 | WARNING | Line exceeds 80 characters; contains 100 characters 92 | WARNING | Line exceeds 80 characters; contains 118 characters 93 | WARNING | Line exceeds 80 characters; contains 84 characters 101 | WARNING | Line exceeds 80 characters; contains 120 characters 115 | WARNING | Line exceeds 80 characters; contains 111 characters 154 | WARNING | Line exceeds 80 characters; contains 119 characters 155 | WARNING | Line exceeds 80 characters; contains 118 characters 202 | WARNING | Line exceeds 80 characters; contains 113 characters 207 | WARNING | Line exceeds 80 characters; contains 99 characters 209 | WARNING | Line exceeds 80 characters; contains 88 characters 211 | WARNING | Line exceeds 80 characters; contains 123 characters 212 | WARNING | Line exceeds 80 characters; contains 118 characters 214 | WARNING | Line exceeds 80 characters; contains 118 characters 217 | WARNING | Line exceeds 80 characters; contains 91 characters 219 | WARNING | Line exceeds 80 characters; contains 145 characters 220 | WARNING | Line exceeds 80 characters; contains 182 characters 222 | WARNING | Line exceeds 80 characters; contains 117 characters 223 | WARNING | Line exceeds 80 characters; contains 118 characters 228 | WARNING | Line exceeds 80 characters; contains 118 characters 231 | WARNING | Line exceeds 80 characters; contains 86 characters 243 | WARNING | Line exceeds 80 characters; contains 120 characters 245 | WARNING | Line exceeds 80 characters; contains 118 characters 248 | WARNING | Line exceeds 80 characters; contains 117 characters 249 | WARNING | Line exceeds 80 characters; contains 113 characters 254 | WARNING | Line exceeds 80 characters; contains 113 characters 255 | WARNING | Line exceeds 80 characters; contains 117 characters 256 | WARNING | Line exceeds 80 characters; contains 116 characters 257 | WARNING | Line exceeds 80 characters; contains 87 characters 260 | WARNING | Line exceeds 80 characters; contains 109 characters 261 | WARNING | Line exceeds 80 characters; contains 112 characters 262 | WARNING | Line exceeds 80 characters; contains 119 characters 268 | WARNING | Line exceeds 80 characters; contains 116 characters 271 | WARNING | Line exceeds 80 characters; contains 113 characters 278 | WARNING | Line exceeds 80 characters; contains 116 characters -------------------------------------------------------------------------------------- FILE:/fluidui/README.md ----------------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES ----------------------------------------------------------------------------- 56 | WARNING | Line exceeds 80 characters; contains 98 characters 58 | WARNING | Line exceeds 80 characters; contains 99 characters 60 | WARNING | Line exceeds 80 characters; contains 90 characters 70 | WARNING | Line exceeds 80 characters; contains 89 characters 71 | WARNING | Line exceeds 80 characters; contains 97 characters 85 | WARNING | Line exceeds 80 characters; contains 83 characters 87 | WARNING | Line exceeds 80 characters; contains 108 characters ----------------------------------------------------------------------------- FILE: /fluidui/fluidui.routing.yml ------------------------------------------------------------------------------------------------------------------------------------------------------------FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------ 7 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user can change something - rather | | than "access administration pages" which is about viewing but not changing configurations. ------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: +/fluidui/fluidui.module ------------------------------------------------------------------------------------------------------------------------------------------------------------FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------ 66 | ERROR | The $_COOKIE super global must not be accessed directly; inject the request_stack service and use | | $stack->getCurrentRequest()->cookies->get('fluid-ui-settings') instead 67 | ERROR | The $_COOKIE super global must not be accessed directly; inject the request_stack service and use | | $stack->getCurrentRequest()->cookies->get('fluid-ui-settings') instead ------------------------------------------------------------------------------------------------------------------------------------------------------------ - First commit to issue fork.
- Merge request !73419340-resolving-phpcs-errors: Resolved the phpcs errors. → (Open) created by uttam
- 🇮🇳India Anjali Mehta
Anjali Mehta → made their first commit to this issue’s fork.
- Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
10 months ago 11:00am 6 February 2024 - Status changed to Needs work
10 months ago 8:29am 7 February 2024 - 🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !7 and there are still many PHPCS issues that the PHPCS flagged.
➜ fluidui git:(2.0.x) curl https://git.drupalcode.org/project/fluidui/-/merge_requests/7.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 496k 0 496k 0 0 458k 0 --:--:-- 0:00:01 --:--:-- 461k patching file README.md patching file fluidui.install patching file fluidui.links.menu.yml patching file fluidui.module patching file fluidui.routing.yml patching file 'infusion/README.md' patching file 'infusion/ReleaseNotes.md' patching file 'infusion/src/components/tableOfContents/css/TableOfContents.css' patching file 'infusion/src/components/textfieldControl/css/TextfieldSlider.css' patching file 'infusion/src/components/textfieldControl/css/TextfieldStepper.css' patching file 'infusion/src/framework/core/css/fluid.css' patching file 'infusion/src/framework/core/css/fluidDebugging.css' patching file 'infusion/src/framework/enhancement/css/ProgressiveEnhancement.css' patching file 'infusion/src/lib/jquery/ui/css/default-theme/jquery-ui.css' patching file 'infusion/src/lib/jquery/ui/css/fl-theme-bw/bw.css' patching file 'infusion/src/lib/jquery/ui/css/fl-theme-by/by.css' patching file 'infusion/src/lib/jquery/ui/css/fl-theme-dglg/dglg.css' patching file 'infusion/src/lib/jquery/ui/css/fl-theme-lgdg/lgdg.css' patching file 'infusion/src/lib/jquery/ui/css/fl-theme-wb/wb.css' patching file 'infusion/src/lib/jquery/ui/css/fl-theme-yb/yb.css' patching file 'src/Form/FluidConfigForm.php' ➜ fluidui git:(2.0.x) ✗ .. ➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml fluidui FILE: ...ubing/Projects/d9/d9-local/web/modules/contrib/fluidui/fluidui.routing.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 7 | WARNING | The administration page callback should probably use "administer | | site configuration" - which implies the user can change | | something - rather than "access administration pages" which is | | about viewing but not changing configurations. -------------------------------------------------------------------------------- FILE: ...uidui/infusion/src/framework/preferences/css/SeparatedPanelPrefsEditor.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- FILE: ...luidui/infusion/src/framework/preferences/css/FullNoPreviewPrefsEditor.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- FILE: ...contrib/fluidui/infusion/src/framework/preferences/css/FullPrefsEditor.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- FILE: ...odules/contrib/fluidui/infusion/src/framework/preferences/css/Enactors.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- FILE: .../fluidui/infusion/src/framework/preferences/css/FullPreviewPrefsEditor.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- FILE: ...les/contrib/fluidui/infusion/src/framework/preferences/css/PrefsEditor.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- FILE: .../infusion/src/framework/preferences/css/SeparatedPanelPrefsEditorFrame.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- FILE: .../fluidui/infusion/src/framework/enhancement/css/ProgressiveEnhancement.css -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | Class definition is empty -------------------------------------------------------------------------------- FILE: ...modules/contrib/fluidui/infusion/src/framework/core/css/fluidDebugging.css -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 70 | ERROR | Style definitions must end with a semicolon -------------------------------------------------------------------------------- FILE: ...ocal/web/modules/contrib/fluidui/infusion/src/framework/core/css/fluid.css -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 21 | ERROR | More than 2 empty lines are not allowed -------------------------------------------------------------------------------- FILE: .../web/modules/contrib/fluidui/infusion/src/components/switch/css/Switch.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- Time: 1.35 secs; Memory: 26MB ➜ contrib git:(master) ✗ - First commit to issue fork.
- First commit to issue fork.