UpdateUsernameAction::access() Implicitly marking parameter $account as nullable is deprecated

Created on 6 February 2025, about 2 months ago

Problem/Motivation

Using the latest dev on PHP 8.4, I'm getting this deprecation warning:

PHP Deprecated:  Drupal\email_registration\Plugin\Action\UpdateUsernameAction::access(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/email_registration/src/Plugin/Action/UpdateUsernameAction.php on line 68
🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇯🇵Japan ptmkenny

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ptmkenny
  • 🇯🇵Japan ptmkenny

    ptmkenny changed the visibility of the branch fix_php8.4_deprecation to hidden.

  • 🇯🇵Japan ptmkenny

    For some reason it's not letting me create an MR off the branch at the moment, but I'm setting this to "Needs review" because the change is fixed in the php84deprecation branch.

  • Pipeline finished with Failed
    about 2 months ago
    Total: 207s
    #416357
  • Merge request !533504702: Fixes the depreciation error. → (Open) created by uttam
  • Pipeline finished with Failed
    about 2 months ago
    Total: 539s
    #416488
  • I have tried to raise the MR for in my case also the pipeline is failed and the below are the failed jobs:

    composer (max PHP version)
          .git/**/*: excluded 75 files                       
    Uploading artifacts as "archive" to coordinator... 201 Created  id=4263642 responseStatus=201 Created token=glcbt-64
    Uploading artifacts...
    build.env: found 1 matching artifact files and directories 
    Uploading artifacts as "dotenv" to coordinator... 201 Created  id=4263642 responseStatus=201 Created token=glcbt-64
    
    Cleaning up project directory and file based variables
    
    ERROR: Job failed: command terminated with exit code 1
    
    
        
    composer
     .git/**/*: excluded 75 files                       
    Uploading artifacts as "archive" to coordinator... 201 Created  id=4263534 responseStatus=201 Created token=glcbt-64
    Uploading artifacts...
    build.env: found 1 matching artifact files and directories 
    Uploading artifacts as "dotenv" to coordinator... 201 Created  id=4263534 responseStatus=201 Created token=glcbt-64
    
    Cleaning up project directory and file based variables
    
    ERROR: Job failed: command terminated with exit code 1
    
    
        
    composer (next minor)
      .git/**/*: excluded 75 files                       
    Uploading artifacts as "archive" to coordinator... 201 Created  id=4263533 responseStatus=201 Created token=glcbt-64
    Uploading artifacts...
    build.env: found 1 matching artifact files and directories 
    Uploading artifacts as "dotenv" to coordinator... 201 Created  id=4263533 responseStatus=201 Created token=glcbt-64
    
    Cleaning up project directory and file based variables
    
    ERROR: Job failed: command terminated with exit code 1
    
    
        
    composer (previous minor)
          .git/**/*: excluded 75 files                       
    Uploading artifacts as "archive" to coordinator... 201 Created  id=4263523 responseStatus=201 Created token=glcbt-64
    Uploading artifacts...
    build.env: found 1 matching artifact files and directories 
    Uploading artifacts as "dotenv" to coordinator... 201 Created  id=4263523 responseStatus=201 Created token=glcbt-64
    
    Cleaning up project directory and file based variables
    
    ERROR: Job failed: command terminated with exit code 1
  • 🇯🇵Japan ptmkenny

    @uttam You can confirm that the tests are already broken on the module page: https://www.drupal.org/project/email_registration . So that's why you're seeing that error.

  • 🇯🇵Japan ptmkenny

    ptmkenny changed the visibility of the branch 3504702-depreciationerror to hidden.

  • 🇦🇺Australia acbramley

    CI is being fixed in 🐛 Fix CI on 2.x HEAD Active there are a few other implicit nullables to fix here

  • Pipeline finished with Failed
    about 2 months ago
    Total: 148s
    #428159
  • 🇩🇪Germany Grevil

    Yep, that should be all, thanks again! LGTM! 🎉

  • 🇩🇪Germany Grevil

    All green. Merging.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024