t() calls should be avoided in classes

Patch successfully applied and updated text
#title , #description
RTBC+1

Patch #3 looks good.
I applied it to 📌 Integration with Gitlab CI Needs review and no CS violation with "t() calls should be avoided in classes" left in the code base.
Can we merge changes from this issue?

I will move changes for t() from 📌 Integration with Gitlab CI Needs review to this issue.

I created MR. Please make a review. Update IS.

As follow-up to 📌 Integration with Gitlab CI Needs review it looks ready

@Berdir I bet it needs your final merge

Would be good to get this merged so gitlab CI can go green :)

Tests are failing

So the failure is because the allowed_values settings have completely changed. They are no longer added via a textarea but a tuple of key/value pairs with individual text fields.

I can't see any other tests that use $this->fieldUIAddNewField for a field like this. I'm not sure it's even possible.

In that case, we should probably just do a FieldStorageConfig::create and friends to bypass the new UI.

@acbramley I have raised the MR with proper phpcs testing. please review.

acbramley → changed the visibility of the branch 3127124-t-fn-replace to hidden.

@deepak5423 did you not see the existing MR? Please close yours. Back to NW to address #15

deepak5423 → closed merge request !14

@acbramley I have closed the MR-14. Back to NW to address #15

Thanks a lot for your feedback.

MR is ready for review.
I also remove TranslatableMarkup from tests, because I found recently using it at assert is bad practice.
Should we move it to different issue?

IS updated on latest HEAD.

IS updated, update command and results path.