Integration with Gitlab CI

Unit tests falling because of using Classy theme. I create follow up issue 📌 Tests should not rely on Classy Needs work to fix it.
I include some small changes to phpcs, that was create by phpcbf.
MR is ready for review.

As suggested by @andypost I will continue working on PHPUnit fix in this issue.

I was able to fix tests for D9.5, D10.1. And I looking for help.
In order module to work with D10.2 need more changes in the code, and in tests.
Allowed values form is broken in D10.2 because of 📌 List key|label entry field is textarea, which doesn't give guidance towards the expected input Fixed .

Example for new allowed values tests.

    $edit = [
      'field_storage[subform][settings][allowed_values][table][0][item][key]' => 0,
      'field_storage[subform][settings][allowed_values][table][0][item][label]' => 'Zero',
      'field_storage[subform][settings][allowed_values][table][1][item][key]' => 1,
      'field_storage[subform][settings][allowed_values][table][1][item][label]' => 'One',
    ];

And I don't know how to implement different test for different core, maybe new minor version need.

> Is it better to move it to separate topic? This MR already has a lot of changes.

Yes, definitely. FWIW, I would consider to convert the field creation to use the API, that hasn't changed between versions. Otherwise you need to add version_compare() logic to do it differently on versions bigger than 10.2

I don't really agree with andypost on merging the two issues, was IMHO a good call to split and testing on D9 and D10 can still be done with manual tests. Test fixes and coding standard improvements should also not be mixed.

Added some comments.

I find it reasonable to combine issues because fixing CI means to fix tests.

But it's ok to fix'em aside

Thanks for feedback. I left some comments.

> Test fixes and coding standard improvements should also not be mixed.

I revert commit with changes made by phpcbf, and I work on fixing phpcs can be proceed in 📌 Fix the issues reported by phpcs Needs review .
Do we want to remove changes made to tests and reopen 📌 Tests should not rely on Classy Needs work for further work?

I will create 2 follow up issues to fix PHPstan, and changes for OptionsEmailItem::extractAllowedValues. I checked opened issues and was not able anything related for it.

Issue to support changes in allowed values 🐛 Fix allowed values for field type "Options email" (contact_storage_options_email) in Drupal 10.2 Active included fixing.
This will include fix for ContactStorageTest::testContactStorage() in D10.2+.

Create another issue 📌 Fix PHPStan errors Active .

Let's combine in this task:

• 1. Gitlab CI intergration.
• 2. Fix PHPUnit tests.
• 2.1 Fix failed tests.
• 2.2 Replace "classy" theme with "stark".

Because we already start conversation about code changes.
I made some changes, please make a review.

As commented, I'd prefer to not add the baseline file for now. If there are things we don't want to fix we can do that, but doing it now just means extra work in the follow-up to remove it again.

The t() changes are not required to make the tests pass, but I'm OK with keeping them. In the future, try to do only do required changes for a specific task, it will make it easier to review and in turn more likely to get committed.

Thanks for the feedback, I am doing my best to improve my contribution experience, and every feedback is very valuable for me.
I removed all the changes not related to current issue.

> The t() changes are not required to make the tests pass, but I'm OK with keeping them.

There is an issue 🐛 t() calls should be avoided in classes RTBC , I will move t() changes into it.
I am not sure where to put changes about "Misordered 'assertEquals()' arguments". Is it better to create new issue, or put it to 📌 Fix the issues reported by phpcs Needs review ?

@Berdir, do you want to fix PHPStan violations in this issue, or it can be done in follow up issue 📌 Fix PHPStan errors Active ?

We can fix them in the follow-up you created.

Thanks for reducing the scope, merged this.

A bit unsure if we really need to still test Drupal 9 as it is technically now EOL, but if DA wants to stop supporting D9 tests they can update that in the template :)

> I am not sure where to put changes about "Misordered 'assertEquals()' arguments". Is it better to create new issue, or put it to #3355042: Fix the issues reported by phpcs?

Lets do a separate issue. if we do everything phpcs in one issue it's going to get very big.

@Berdir thank you, I've assigned to you the-t-conversion as it looks hot and ready 🐛 t() calls should be avoided in classes RTBC

Should we start 2.x branch for 11.x compatibility or dropping of 9.1 support smells new major

Automatically closed - issue fixed for 2 weeks with no activity.