Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 19 April 2023, almost 2 years ago

Problem/Motivation

FILE: /contact_storage/contact_storage.install
-------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
 8 | WARNING | [x] Unused use statement
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: /contact_storage/src/Form/ContactFormCloneForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 141 | ERROR | The array declaration extends to column 134 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /contact_storage/src/ContactMessageViewBuilder.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
 23 | WARNING | [x] '@todo  Remove this when providing a template in' should match the format '@todo Fix problem X here.'
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------


FILE: /contact_storage/src/Plugin/Validation/Constraint/ConstactStorageMaximumSubmissionsConstraintValidator.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------
 17 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /contact_storage/src/Routing/RouteSubscriber.php
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
 7 | ERROR | [x] When importing a class with "use", do not include a leading \
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------


FILE: /contact_storage/tests/src/Functional/ContactStorageTest.php
---------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------
  54 | ERROR | [x] Missing function doc comment
 404 | ERROR | [x] Missing function doc comment
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------


FILE: /contact_storage/tests/src/Functional/ContactStoragePersonalTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 54 | ERROR | [x] Missing function doc comment
 58 | ERROR | [ ] The array declaration extends to column 149 (the limit is 80). The array content should be split up over multiple lines
 62 | ERROR | [ ] The array declaration extends to column 98 (the limit is 80). The array content should be split up over multiple lines
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /contact_storage/tests/src/Functional/ContactStorageTestBase.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 29 | ERROR | Type hint "array" missing for $third_party_settings
-------------------------------------------------------------------------------------------------------------------


FILE: /contact_storage/contact_storage.module
-------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 3 WARNINGS AFFECTING 9 LINES
-------------------------------------------------------------------------------------------------------------------------
  17 | WARNING | [x] Unused use statement
 144 | ERROR   | [ ] Parameter tags must be grouped together in a doc comment
 147 | ERROR   | [ ] Type hint "array" missing for $form
 162 | ERROR   | [ ] Parameter tags must be grouped together in a doc comment
 165 | ERROR   | [ ] Type hint "array" missing for $form
 204 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
 341 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
 477 | ERROR   | [ ] Type hint "array" missing for $variables
 500 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml contact_storage

Proposed resolution

Fix the errors and warnings.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

1.3

Component

Code

Created by

🇮🇳India Binoli Lalani Gujarat

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Binoli Lalani
  • First commit to issue fork.
  • Merge request !4Issue #3355042: Fix the issues reported by phpcs → (Open) created by Binoli Lalani
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update almost 2 years ago
    8 pass
  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • Comment almost 2 years ago →
    🇮🇳India Binoli Lalani Gujarat

    Hello,

    I have created MR to fix PHPCS errors and warnings.

    Please review.

    Thank you!

  • Comment almost 2 years ago →
    🇮🇳India dineshkumarbollu

    Hi

    MR!4 has still some issues.

    vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/contact_storage-3355042/

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/src/Form/ContactStorageSettingsForm.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    -----------------------------------------------------------------------------------------------------------------------------------------
    38 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    39 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/src/Form/ContactFormDisableForm.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    -----------------------------------------------------------------------------------------------------------------------------------------
    49 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    50 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/src/EventSubscriber/ContactStorageSettingsFormSave.php
    -------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------
    22 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
    -------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/src/ContactFormViewBuilder.php
    ------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------------------------------------
    104 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    ------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/tests/src/Functional/ContactStorageTestBase.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    -----------------------------------------------------------------------------------------------------------------------------------------
    43 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    68 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    72 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/tests/src/Functional/BulkFormTest.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------------------------------------
    78 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/tests/src/Functional/ContactStorageTest.php
    ------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 23 WARNINGS AFFECTING 23 LINES
    ------------------------------------------------------------------------------------------------------------------------------------------
    104 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    129 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    175 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    182 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    188 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    192 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    193 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    194 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    209 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    218 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    241 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    271 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    283 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    308 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    322 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    331 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    423 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    426 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    454 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    468 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    485 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    496 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    515 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    ------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/tests/src/Functional/ContactViewBuilderTest.php
    ------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------------------------------------
    130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    ------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/tests/src/Functional/ContactStoragePersonalTest.php
    ------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ------------------------------------------------------------------------------------------------------------------------------------------
    101 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    140 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    ------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/contact_storage.module
    -----------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    -----------------------------------------------------------------------------------------------
    419 | WARNING | Unused variable $delta.
    432 | WARNING | Unused variable $reply.

  • Status changed to Needs work almost 2 years ago
  • Comment almost 2 years ago →
    🇮🇳India dineshkumarbollu
  • Status changed to Needs review almost 2 years ago
  • Comment almost 2 years ago →
    🇮🇳India Binoli Lalani Gujarat

    Hello @dineshkumarbollu,

    Thank you for reviewing the MR. Which issues are you facing? Can you please elaborate more? because It seems all errors and warnings have been addressed in my local.

    Thank you!

  • Comment almost 2 years ago →
    🇮🇳India dineshkumarbollu

    After I checkout into "3355042-fix-the-issues" branch in my local i getting errors.

    vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/contact_storage-3355042/

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/src/Form/ContactStorageSettingsForm.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    -----------------------------------------------------------------------------------------------------------------------------------------
    38 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    39 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/src/Form/ContactFormDisableForm.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    -----------------------------------------------------------------------------------------------------------------------------------------
    49 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    50 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/src/EventSubscriber/ContactStorageSettingsFormSave.php
    -------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------
    22 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
    -------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/src/ContactFormViewBuilder.php
    ------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------------------------------------------------
    104 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    ------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /var/www/html/drupalvb/web/modules/contrib/contact_storage-3355042/tests/src/Functional/ContactStorageTestBase.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    -----------------------------------------------------------------------------------------------------------------------------------------
    43 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    68 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    72 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update almost 2 years ago
    2 pass, 6 fail
  • Comment almost 2 years ago →
    🇮🇳India chanderbhushan

    Hi, I have applied patch for fix issues.

  • Comment almost 2 years ago →
    System Message

    The last submitted patch, 9: phpcs-3355042-9.patch, failed testing. View results →

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update almost 2 years ago
    2 pass, 6 fail
  • Comment almost 2 years ago →
    🇮🇳India chanderbhushan

    Fixed test fail issues

  • Comment almost 2 years ago →
    System Message

    The last submitted patch, 11: phpcs-3355042-10.patch, failed testing. View results →
    - codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update almost 2 years ago
    10 fail
  • Comment almost 2 years ago →
    🇮🇳India ashutosh ahirwal India

    Providing patch with fixes.

  • Comment almost 2 years ago →
    System Message

    The last submitted patch, 13: phpcs-issue-fixes-3355042-13.patch, failed testing. View results →

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update almost 2 years ago
    8 pass
  • Comment almost 2 years ago →
    🇮🇳India Binoli Lalani Gujarat

    Hello,

    There is already created issue 🐛 t() calls should be avoided in classes RTBC for t() calls so I think we need to reopen that issue.

    I have fixed other warnings in MR.

    Thank you!

  • Comment almost 2 years ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Comment over 1 year ago →
    🇷🇺Russia zniki.ru

    zniki.ru → made their first commit to this issue’s fork.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update over 1 year ago
    8 pass
  • Pipeline finished with Success
    over 1 year ago
    Total: 316s
    #54413
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇷🇺Russia zniki.ru

    Thanks a lot for your contribution.
    Please check my comments.
    And right now we have phpcs report in the pipeline, as you can see there are 5 more errors, that can be fixed with phpcbf.

  • Assigned to nitin_lama
  • Comment over 1 year ago →
    🇮🇳India nitin_lama India
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update over 1 year ago
    8 pass
  • Comment over 1 year ago →
    🇮🇳India nitin_lama India

    Please review. Thanks.

  • Issue was unassigned.
  • Comment over 1 year ago →
    🇮🇳India nitin_lama India
  • Pipeline finished with Success
    over 1 year ago
    Total: 252s
    #54668
  • Comment over 1 year ago →
    shruu_rao

    Shruthi rao → made their first commit to this issue’s fork.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update over 1 year ago
    8 pass
  • Pipeline finished with Success
    over 1 year ago
    Total: 317s
    #57369
  • Comment over 1 year ago →
    🇷🇺Russia zniki.ru

    @Shruthi rao thanks for your changes.

    As mentioned at #15 there is an issue 🐛 t() calls should be avoided in classes RTBC , let's not make changes to t() functions in this issue.

    I suggest to revert commit 30d4afc

    Please check MR discussion, there are several open threads waiting for changes.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update about 1 year ago
    8 pass
  • Comment about 1 year ago →
    shruu_rao

    Hi @Nikolay Shapovalov, as per your suggestion i have reverted the commit 30d4afc.
    Thank you

  • Comment 11 months ago →
    🇮🇳India dev16.addweb

    Fixed the problem with even unused variables.

  • Status changed to Needs review 11 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 11 months ago
    10 fail
  • Comment 11 months ago →
    🇮🇳India dev16.addweb
  • Comment 11 months ago →
    System Message

    The last submitted patch, 25: contact_storage-3355042-25.patch, failed testing. View results →

  • Comment 4 months ago →
    🇷🇺Russia zniki.ru

    @silvi.addweb please use MR approach instead of patch. [#3344225]

  • Comment 4 months ago →
    🇷🇺Russia zniki.ru

    Added related issue.

  • Comment 4 months ago →
    🇮🇳India kulpratap2002
  • Pipeline finished with Failed
    4 months ago
    Total: 218s
    #365115
  • Comment 4 months ago →
    🇮🇳India kulpratap2002
  • Pipeline finished with Failed
    4 months ago
    Total: 282s
    #365120
  • Comment 4 months ago →
    🇷🇺Russia zniki.ru

    Tests fails.

  • Pipeline finished with Success
    4 months ago
    Total: 213s
    #366469
  • Pipeline finished with Success
    4 months ago
    Total: 156s
    #366475
  • Comment 4 months ago →
    🇮🇳India kulpratap2002

    Now I’ve fixed the PHPCS issues, and all tests have passed successfully. @nikolay shapovalov Please review.

  • Comment 4 months ago →
    🇮🇳India kulpratap2002
  • Comment 4 months ago →
    a.aaronjake

    Hi @kul.pratap,

    I have checked the pipeline and re-ran the phpcs job, confirmed it succeeded.

    Will now move this to RTBC.

    Thanks,
    Jake

  • Comment 4 months ago →
    🇷🇺Russia zniki.ru

    Thanks for update, please check my feedback.

  • Comment 4 months ago →
    🇷🇺Russia zniki.ru

    As mentioned by @Berdir at https://www.drupal.org/project/entity_reference_revisions/issues/3128194... 📌 Fix the issues reported by phpcs Needs review
    He prefer to use same rules as we have at Drupal core, so let's fix only there.

    IS updated, added list of violations.

  • Pipeline finished with Failed
    4 months ago
    #367894
  • Pipeline finished with Failed
    4 months ago
    #367895
  • Pipeline finished with Success
    4 months ago
    Total: 226s
    #367897
  • Comment 4 months ago →
    🇷🇺Russia zniki.ru
  • Comment 4 months ago →
    🇮🇳India kulpratap2002

    @nikolay shapovalov if i revert the changes you had mentioned in the MR, then it leads to fail the phpcs tests.

  • Comment 4 months ago →
    🇷🇺Russia zniki.ru

    @kul.pratap it's okay to keep some code style issues, and change them latter in follow up issue.

  • Pipeline finished with Success
    3 months ago
    Total: 256s
    #377781
  • Pipeline finished with Success
    3 months ago
    Total: 176s
    #377789
  • Comment 3 months ago →
    🇮🇳India kulpratap2002

    "@nikolay shapovalov, I have resolved all the issues, and the pipeline has successfully passed.
    Kindly review it.
    Thank you!"

  • Comment 3 months ago →
    🇮🇳India kulpratap2002
  • Status changed to Needs review 29 days ago
  • First commit to issue fork.
  • Pipeline finished with Success
    29 days ago
    Total: 347s
    #443392
  • Comment 29 days ago →
    🇦🇹Austria klausi 🇦🇹 Vienna

    I fixed the comments in the pull request, please review.

    Uploading stable patch file for composer patches.

  • Comment 27 days ago →
    🇺🇦Ukraine andriy khomych

    Thanks Klausi.
    Looks good to me and solves this issue.
    However, we have failed pipelines (one is PHPCS more issues, and another is PHPStan more issues).
    I think they can be done in follow-ups.
    It has been moved to RTBC.

  • Comment 27 days ago →
    🇦🇹Austria klausi 🇦🇹 Vienna

    Thanks - I think we should only do the PHPCS fixes here, to not make the merge request even bigger with out of scope changes.

    PHPStan: 📌 Fix the issues reported by phpcs Needs review

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024