Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 16 April 2020, about 4 years ago
Updated 24 May 2024, about 1 month ago

Running 

phpcs --standard=Drupal,DrupalPractice --extensions=php,inc,module,install,info,test,profile,theme modules/custom/entity_reference_revisions/ -s

shows the following warnings/errors, which should be fixed.

Result:


FILE: entity_reference_revisions.views.inc
------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 7 LINES
------------------------------------------------------------------------------------------------------------
 27 | ERROR | [x] Short array syntax must be used to define arrays
    |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 31 | ERROR | [x] Short array syntax must be used to define arrays
    |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 35 | ERROR | [x] Expected 1 space after "=>"; 2 found (Squiz.WhiteSpace.OperatorSpacing.SpacingAfter)
 35 | ERROR | [x] Short array syntax must be used to define arrays
    |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 50 | ERROR | [x] Short array syntax must be used to define arrays
    |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 52 | ERROR | [x] Short array syntax must be used to define arrays
    |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 62 | ERROR | [x] Short array syntax must be used to define arrays
    |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 63 | ERROR | [x] Short array syntax must be used to define arrays
    |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: ...erence_revisions/tests/modules/entity_host_relationship_test/src/Entity/EntityTestHostRelationship.php
------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------
  8 | WARNING | [x] Unused use statement (Drupal.Classes.UnusedUseStatement.UnusedUse)
 50 | ERROR   | [x] Expected 1 blank line after function; 0 found
    |         |     (Squiz.WhiteSpace.FunctionSpacing.AfterLast)
 51 | ERROR   | [x] The closing brace for the class must have an empty line before it
    |         |     (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: tests/src/Functional/EntityReferenceRevisionsNormalizerTest.php
------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 8 LINES
------------------------------------------------------------------------------------------------------------
  24 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  51 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  52 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  62 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  75 | ERROR | [ ] The array declaration extends to column 233 (the limit is 120). The array content should
     |       |     be split up over multiple lines (Drupal.Arrays.Array.LongLineDeclaration)
  75 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  75 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  80 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  92 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 106 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: tests/src/Functional/EntityReferenceRevisionsOrphanRemovalTest.php
------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------
  35 | WARNING | [x] A comma should follow the last multiline array item. Found:
     |         |     'entity_composite_relationship_test' (Drupal.Arrays.Array.CommaLastItem)
 124 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
     |         |     (DrupalPractice.Objects.GlobalFunction.GlobalFunction)
 163 | WARNING | [x] A comma should follow the last multiline array item. Found:
     |         |     'entity_test_composite' (Drupal.Arrays.Array.CommaLastItem)
 371 | ERROR   | [x] Expected 1 blank line after function; 0 found
     |         |     (Squiz.WhiteSpace.FunctionSpacing.AfterLast)
 372 | ERROR   | [x] The closing brace for the class must have an empty line before it
     |         |     (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: tests/src/Functional/EntityReferenceRevisionsAdminTest.php
------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AND 1 WARNING AFFECTING 9 LINES
------------------------------------------------------------------------------------------------------------
  23 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  42 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  43 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  46 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  97 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 123 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 148 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 158 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 188 | WARNING | [x] A comma should follow the last multiline array item. Found: $i
     |         |     (Drupal.Arrays.Array.CommaLastItem)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: tests/src/Functional/EntityReferenceRevisionsAutocompleteTest.php
------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 15 LINES
------------------------------------------------------------------------------------------------------------
  25 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  44 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  56 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  75 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  83 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  84 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  90 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 100 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 121 | ERROR | [ ] Missing parameter type (Drupal.Commenting.FunctionComment.MissingParamType)
 123 | ERROR | [ ] Missing parameter type (Drupal.Commenting.FunctionComment.MissingParamType)
 129 | ERROR | [x] Visibility must be declared on method "drupalGetBlockByInfo"
     |       |     (Drupal.Scope.MethodScope.Missing)
 133 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 142 | ERROR | [ ] Missing parameter type (Drupal.Commenting.FunctionComment.MissingParamType)
 146 | ERROR | [x] Visibility must be declared on method "createBlockContentType"
     |       |     (Drupal.Scope.MethodScope.Missing)
 149 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: tests/src/Kernel/EntityReferenceRevisionsSaveTest.php
------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AND 3 WARNINGS AFFECTING 15 LINES
------------------------------------------------------------------------------------------------------------
  24 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  57 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  61 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  62 | WARNING | [x] A comma should follow the last multiline array item. Found:
     |         |     'entity_test_composite' (Drupal.Arrays.Array.CommaLastItem)
  66 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  74 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  92 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or
     |         |     closing parentheses (Drupal.Commenting.InlineComment.InvalidEndChar)
 146 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 150 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 151 | WARNING | [x] A comma should follow the last multiline array item. Found:
     |         |     'entity_test_composite' (Drupal.Arrays.Array.CommaLastItem)
 155 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 163 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 187 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 271 | ERROR   | [x] Doc comment short description must end with a full stop
     |         |     (Drupal.Commenting.DocComment.ShortFullStop)
 302 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
     |         |     (Drupal.Arrays.Array.CommaLastItem)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: tests/src/Kernel/EntityReferenceRevisionsCompositeTranslationTest.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------
  38 | WARNING | [x] A comma should follow the last multiline array item. Found: 'content_translation'
     |         |     (Drupal.Arrays.Array.CommaLastItem)
  53 | ERROR   | [x] Additional blank lines found at end of doc comment
     |         |     (Drupal.Commenting.DocComment.SpacingAfter)
  78 | WARNING | [x] A comma should follow the last multiline array item. Found:
     |         |     'entity_test_composite' (Drupal.Arrays.Array.CommaLastItem)
 110 | WARNING | [x] A comma should follow the last multiline array item. Found:
     |         |     'entity_test_composite' (Drupal.Arrays.Array.CommaLastItem)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: tests/src/Kernel/EntityReferenceRevisionsCompositeTest.php
------------------------------------------------------------------------------------------------------------
FOUND 26 ERRORS AND 2 WARNINGS AFFECTING 28 LINES
------------------------------------------------------------------------------------------------------------
  30 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  35 | WARNING | [x] A comma should follow the last multiline array item. Found: 'language'
     |         |     (Drupal.Arrays.Array.CommaLastItem)
  50 | ERROR   | [x] Additional blank lines found at end of doc comment
     |         |     (Drupal.Commenting.DocComment.SpacingAfter)
  73 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  77 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  78 | WARNING | [x] A comma should follow the last multiline array item. Found:
     |         |     'entity_test_composite' (Drupal.Arrays.Array.CommaLastItem)
  82 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 102 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 119 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 168 | ERROR   | [x] Expected one space after the comma, 0 found (Drupal.WhiteSpace.Comma.NoSpace)
 259 | ERROR   | [x] Visibility must be declared on method
     |         |     "testCompositeRelationshipWithTranslationNonTranslatableField"
     |         |     (Drupal.Scope.MethodScope.Missing)
 264 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 270 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
     |         |     (Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines)
 273 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 313 | ERROR   | [x] Visibility must be declared on method
     |         |     "testCompositeRelationshipWithTranslationTranslatableField"
     |         |     (Drupal.Scope.MethodScope.Missing)
 321 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 329 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 361 | ERROR   | [x] Visibility must be declared on method "testCompositeRelationshipWithRevisions"
     |         |     (Drupal.Scope.MethodScope.Missing)
 364 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 371 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 377 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
     |         |     (Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines)
 412 | ERROR   | [x] Visibility must be declared on method "testCompositeRelationshipDefaultRevision"
     |         |     (Drupal.Scope.MethodScope.Missing)
 460 | ERROR   | [x] Visibility must be declared on method
     |         |     "testCompositeRelationshipDuplicatedRevisions" (Drupal.Scope.MethodScope.Missing)
 521 | ERROR   | [x] list(...) is forbidden, use [...] instead.
     |         |     (SlevomatCodingStandard.PHP.ShortList.LongListUsed)
 545 | ERROR   | [x] list(...) is forbidden, use [...] instead.
     |         |     (SlevomatCodingStandard.PHP.ShortList.LongListUsed)
 573 | ERROR   | [x] list(...) is forbidden, use [...] instead.
     |         |     (SlevomatCodingStandard.PHP.ShortList.LongListUsed)
 623 | ERROR   | [x] list(...) is forbidden, use [...] instead.
     |         |     (SlevomatCodingStandard.PHP.ShortList.LongListUsed)
 671 | ERROR   | [x] list(...) is forbidden, use [...] instead.
     |         |     (SlevomatCodingStandard.PHP.ShortList.LongListUsed)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 28 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: tests/src/Kernel/Plugin/Derivative/EntityReferenceRevisionsDeriverTest.php
------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------
  7 | WARNING | [x] Unused use statement (Drupal.Classes.UnusedUseStatement.UnusedUse)
 36 | ERROR   | [x] Data types in @var tags need to be fully namespaced
    |         |     (Drupal.Commenting.DataTypeNamespace.DataTypeNamespace)
 41 | ERROR   | [x] Expected 1 blank line after function; 3 found
    |         |     (Squiz.WhiteSpace.FunctionSpacing.AfterLast)
 44 | ERROR   | [ ] More than 2 empty lines are not allowed (Drupal.WhiteSpace.EmptyLines.EmptyLines)
 45 | ERROR   | [x] The closing brace for the class must have an empty line before it
    |         |     (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: ...ence_revisions/tests/src/Kernel/Plugin/migrate/destination/EntityReferenceRevisionsDestinationTest.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------
 317 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
     |         |     (Drupal.Arrays.Array.CommaLastItem)
 351 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
     |         |     (Drupal.Arrays.Array.CommaLastItem)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: tests/src/Kernel/EntityReferenceRevisionsFormatterTest.php
------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------
  61 | WARNING | [x] A comma should follow the last multiline array item. Found:
     |         |     'entity_test_composite' (Drupal.Arrays.Array.CommaLastItem)
  90 | ERROR   | [x] Missing function doc comment (Drupal.Commenting.FunctionComment.Missing)
 112 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or
     |         |     closing parentheses (Drupal.Commenting.InlineComment.InvalidEndChar)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: tests/src/Kernel/EntityReferenceRevisionsCompositeTranslatableFieldTest.php
------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 9 LINES
------------------------------------------------------------------------------------------------------------
  30 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  36 | WARNING | [x] A comma should follow the last multiline array item. Found: 'content_translation'
     |         |     (Drupal.Arrays.Array.CommaLastItem)
  51 | ERROR   | [x] Additional blank lines found at end of doc comment
     |         |     (Drupal.Commenting.DocComment.SpacingAfter)
  70 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  74 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  75 | WARNING | [x] A comma should follow the last multiline array item. Found:
     |         |     'entity_test_composite' (Drupal.Arrays.Array.CommaLastItem)
  79 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 139 | ERROR   | [ ] The array declaration extends to column 125 (the limit is 120). The array content
     |         |     should be split up over multiple lines (Drupal.Arrays.Array.LongLineDeclaration)
 182 | ERROR   | [ ] The array declaration extends to column 125 (the limit is 120). The array content
     |         |     should be split up over multiple lines (Drupal.Arrays.Array.LongLineDeclaration)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: entity_reference_revisions.module
------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 3 WARNINGS AFFECTING 9 LINES
------------------------------------------------------------------------------------------------------------
  18 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is
     |         |     Drupal\field\Entity\FieldConfig.
     |         |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
  30 | ERROR   | [ ] The array declaration extends to column 611 (the limit is 120). The array content
     |         |     should be split up over multiple lines (Drupal.Arrays.Array.LongLineDeclaration)
  97 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a
     |         |     separate paragraph (Drupal.Commenting.DocComment.ShortSingleLine)
 108 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a
     |         |     separate paragraph (Drupal.Commenting.DocComment.ShortSingleLine)
 129 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a
     |         |     separate paragraph (Drupal.Commenting.DocComment.ShortSingleLine)
 167 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
     |         |     (Drupal.Files.LineLength.TooLong)
 222 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
     |         |     (Drupal.Files.LineLength.TooLong)
 246 | ERROR   | [x] Expected 1 blank line after function; 2 found
     |         |     (Squiz.WhiteSpace.FunctionSpacing.After)
 367 | WARNING | [ ] Unused variable $revision_id.
     |         |     (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Normalizer/EntityReferenceRevisionItemNormalizer.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 34 | ERROR | [x] Short array syntax must be used to define arrays
    |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Form/OrphanedCompositeEntitiesDeleteForm.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 16 | WARNING | The class short comment should describe what the class does and not simply repeat the class
    |         | name (Drupal.Commenting.ClassComment.Short)
------------------------------------------------------------------------------------------------------------


FILE: src/EntityReferenceRevisionsFieldItemList.php
------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES
------------------------------------------------------------------------------------------------------------
  7 | WARNING | [x] Unused use statement (Drupal.Classes.UnusedUseStatement.UnusedUse)
  9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is
    |         |     Drupal\Core\Field\FieldDefinitionInterface.
    |         |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
 39 | ERROR   | [x] Short array syntax must be used to define arrays
    |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 55 | ERROR   | [x] Short array syntax must be used to define arrays
    |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 84 | ERROR   | [x] Short array syntax must be used to define arrays
    |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 89 | ERROR   | [x] Short array syntax must be used to define arrays
    |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 90 | ERROR   | [x] Expected 1 space after FOREACH keyword; 0 found
    |         |     (Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword)
 98 | ERROR   | [x] Short array syntax must be used to define arrays
    |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Plugin/Derivative/MigrateEntityReferenceRevisions.php
------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------
  9 | ERROR   | [x] Doc comment short description must end with a full stop
    |         |     (Drupal.Commenting.DocComment.ShortFullStop)
 10 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the
    |         |     class name (Drupal.Commenting.ClassComment.Short)
 11 | ERROR   | [x] Expected 1 space before opening brace; found 2
    |         |     (Drupal.Classes.ClassDeclaration.SpaceBeforeBrace)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Plugin/DataType/EntityReferenceRevisions.php
------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------
  39 | ERROR | [x] Expected "int|string" but found "integer|string" for @var tag in member variable
     |       |     comment (Drupal.Commenting.VariableComment.IncorrectVarType)
  41 | ERROR | [ ] Class property $revision_id should use lowerCamel naming without underscores
     |       |     (Drupal.NamingConventions.ValidVariableName.LowerCamelName)
  46 | ERROR | [x] Expected "int|string" but found "integer|string" for @var tag in member variable
     |       |     comment (Drupal.Commenting.VariableComment.IncorrectVarType)
 127 | ERROR | [x] Expected 1 blank line after function; 0 found
     |       |     (Squiz.WhiteSpace.FunctionSpacing.AfterLast)
 128 | ERROR | [x] The closing brace for the class must have an empty line before it
     |       |     (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Plugin/DataType/EntityRevisionsAdapter.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
   |       |     Drupal\Core\Entity\Plugin\DataType\EntityAdapter.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Plugin/migrate/destination/EntityReferenceRevisions.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 83 | WARNING | [x] 'TODO: Improve after https://www.drupal.org/node/2783715 is finished.' should match the
    |         |     format '@todo Fix problem X here.' (Drupal.Commenting.TodoComment.TodoFormat)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Plugin/Field/FieldWidget/EntityReferenceRevisionsAutocompleteWidget.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 28 | ERROR | [x] Expected 1 space after IF keyword; 0 found
    |       |     (Drupal.ControlStructures.ControlSignature.SpaceAfterKeyword)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Plugin/Field/FieldType/EntityReferenceRevisionsItem.php
------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 7 WARNINGS AFFECTING 16 LINES
------------------------------------------------------------------------------------------------------------
  49 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  56 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  73 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  90 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
     |         |     (Drupal.Arrays.Array.CommaLastItem)
  91 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
     |         |     (Drupal.Arrays.Array.CommaLastItem)
  98 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
     |         |     (Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines)
 120 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 148 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 153 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 226 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 232 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 268 | WARNING | [x] There must be no blank line following an inline comment
     |         |     (Drupal.Commenting.InlineComment.SpacingAfter)
 268 | WARNING | [ ] There must be no blank line following an inline comment
     |         |     (DrupalPractice.Commenting.CommentEmptyLine.SpacingAfter)
 459 | WARNING | [x] A comma should follow the last multiline array item. Found: )
     |         |     (Drupal.Arrays.Array.CommaLastItem)
 506 | WARNING | [ ] Unused variable $label_key.
     |         |     (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)
 508 | WARNING | [x] '@TODO set the length somehow less arbitrary.' should match the format '@todo Fix
     |         |     problem X here.' (Drupal.Commenting.TodoComment.TodoFormat)
 527 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or
     |         |     closing parentheses (Drupal.Commenting.InlineComment.InvalidEndChar)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Plugin/Field/FieldFormatter/EntityReferenceRevisionsEntityFormatter.php
------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 8 LINES
------------------------------------------------------------------------------------------------------------
  58 | ERROR | [x] Data types in @param tags need to be fully namespaced
     |       |     (Drupal.Commenting.DataTypeNamespace.DataTypeNamespace)
  90 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 100 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 115 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 119 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 119 | ERROR | [x] Use null coalesce operator instead of ternary operator.
     |       |     (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
 129 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 136 | ERROR | [ ] The array declaration extends to column 232 (the limit is 120). The array content should
     |       |     be split up over multiple lines (Drupal.Arrays.Array.LongLineDeclaration)
 136 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 146 | ERROR | [x] Short array syntax must be used to define arrays
     |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Plugin/views/style/EntityReferenceRevisions.php
------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AND 1 WARNING AFFECTING 9 LINES
------------------------------------------------------------------------------------------------------------
  27 | ERROR   | [ ] Missing @var tag in member variable comment
     |         |     (Drupal.Commenting.VariableComment.MissingVar)
  32 | ERROR   | [ ] Missing @var tag in member variable comment
     |         |     (Drupal.Commenting.VariableComment.MissingVar)
  37 | ERROR   | [ ] Missing @var tag in member variable comment
     |         |     (Drupal.Commenting.VariableComment.MissingVar)
  45 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  57 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  69 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
     |         |     (Drupal.Files.LineLength.TooLong)
  85 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 102 | ERROR   | [x] Expected 1 blank line after function; 0 found
     |         |     (Squiz.WhiteSpace.FunctionSpacing.AfterLast)
 103 | ERROR   | [x] The closing brace for the class must have an empty line before it
     |         |     (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Plugin/views/display/EntityReferenceRevisions.php
------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 4 WARNINGS AFFECTING 13 LINES
------------------------------------------------------------------------------------------------------------
  31 | ERROR   | [ ] Missing @var tag in member variable comment
     |         |     (Drupal.Commenting.VariableComment.MissingVar)
  36 | ERROR   | [ ] Missing @var tag in member variable comment
     |         |     (Drupal.Commenting.VariableComment.MissingVar)
  40 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
     |         |     (Drupal.Files.LineLength.TooLong)
  41 | ERROR   | [ ] Missing @var tag in member variable comment
     |         |     (Drupal.Commenting.VariableComment.MissingVar)
  45 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
     |         |     (Drupal.Files.LineLength.TooLong)
  52 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  54 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
  68 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
     |         |     (Drupal.Files.LineLength.TooLong)
 103 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
     |         |     (Drupal.Files.LineLength.TooLong)
 164 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 171 | ERROR   | [ ] The array declaration extends to column 267 (the limit is 120). The array content
     |         |     should be split up over multiple lines (Drupal.Arrays.Array.LongLineDeclaration)
 171 | ERROR   | [x] Short array syntax must be used to define arrays
     |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 176 | ERROR   | [x] Expected 1 blank line after function; 0 found
     |         |     (Squiz.WhiteSpace.FunctionSpacing.AfterLast)
 177 | ERROR   | [x] The closing brace for the class must have an empty line before it
     |         |     (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Plugin/views/row/EntityReferenceRevisions.php
------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------
 29 | ERROR | [x] Short array syntax must be used to define arrays
    |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 41 | ERROR | [x] There should be no white space before a closing ")"
    |       |     (Drupal.WhiteSpace.CloseBracketSpacing.ClosingWhitespace)
 56 | ERROR | [x] Expected 1 blank line after function; 0 found
    |       |     (Squiz.WhiteSpace.FunctionSpacing.AfterLast)
 57 | ERROR | [x] The closing brace for the class must have an empty line before it
    |       |     (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Plugin/diff/Field/EntityReferenceRevisionsFieldDiffBuilder.php
------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------
  6 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is
    |         |     Drupal\Core\Field\FieldItemListInterface.
    |         |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
 26 | ERROR   | [x] Short array syntax must be used to define arrays
    |         |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 29 | WARNING | [ ] Unused variable $field_key.
    |         |     (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)
 33 | WARNING | [ ] Unused variable $field_id.
    |         |     (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/EntityNeedsSaveTrait.php
------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------
  3 | ERROR | [x] There must be one blank line after the namespace declaration
    |       |     (PSR2.Namespaces.NamespaceDeclaration.BlankLineAfter)
 38 | ERROR | [x] Expected 1 blank line after function; 0 found
    |       |     (Squiz.WhiteSpace.FunctionSpacing.AfterLast)
 39 | ERROR | [x] The closing brace for the trait must have an empty line before it
    |       |     (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/TypedData/EntityRevisionDataDefinition.php
------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------
 27 | ERROR | [x] Short array syntax must be used to define arrays
    |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 49 | ERROR | [x] Expected 1 blank line after function; 0 found
    |       |     (Squiz.WhiteSpace.FunctionSpacing.AfterLast)
 50 | ERROR | [x] The closing brace for the class must have an empty line before it
    |       |     (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/EntityReferenceRevisionsServiceProvider.php
------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------
 26 | ERROR | [x] Short array syntax must be used to define arrays
    |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
 34 | ERROR | [x] Short array syntax must be used to define arrays
    |       |     (Drupal.Arrays.DisallowLongArraySyntax.Found)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/EntityNeedsSaveInterface.php
------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------
 17 | ERROR | [x] Whitespace found at end of line (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 24 | ERROR | [ ] Description for the @return value is missing
    |       |     (Drupal.Commenting.FunctionComment.MissingReturnComment)
 26 | ERROR | [x] Expected 1 blank line after function; 0 found
    |       |     (Squiz.WhiteSpace.FunctionSpacing.AfterLast)
 26 | ERROR | [x] Whitespace found at end of line (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 27 | ERROR | [x] The closing brace for the interface must have an empty line before it
    |       |     (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/Commands/EntityReferenceRevisionsCommands.php
------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------
  7 | WARNING | [x] Unused use statement (Drupal.Classes.UnusedUseStatement.UnusedUse)
 25 | ERROR   | [ ] Missing parameter comment (Drupal.Commenting.FunctionComment.MissingParamComment)
 34 | ERROR   | [ ] Missing parameter type (Drupal.Commenting.FunctionComment.MissingParamType)
 37 | ERROR   | [x] Separate the @param and @usage sections by a blank line.
    |         |     (Drupal.Commenting.DocComment.TagGroupSpacing)
 48 | ERROR   | [ ] Missing short description in doc comment
    |         |     (Drupal.Commenting.DocComment.MissingShort)
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------


FILE: src/EntityReferenceRevisionsOrphanPurger.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 218 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
     |         | (DrupalPractice.Objects.GlobalFunction.GlobalFunction)
------------------------------------------------------------------------------------------------------------
📌 Task
Status

RTBC

Version

1.0

Component

Code

Created by

🇮🇳India Suresh Prabhu Parkala Bangalore

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇩🇪Germany sleitner
  • Comment over 1 year ago →
    🇩🇪Germany sleitner
  • Comment over 1 year ago →
    🇩🇪Germany sleitner

    Reroll for current branch with hal as dependency

  • Status changed to Needs work 12 months ago
  • Comment 12 months ago →
    🇵🇭Philippines roberttabigue

    Hi,

    I reviewed the changes and confirmed the Patch was applied cleanly.

    Checking patch composer.json...
Checking patch entity_reference_revisions.info.yml...
Checking patch entity_reference_revisions.views.inc...
Checking patch src/Commands/EntityReferenceRevisionsCommands.php...
Checking patch src/EntityNeedsSaveInterface.php...
Checking patch src/EntityNeedsSaveTrait.php...
Checking patch src/EntityReferenceRevisionsFieldItemList.php...
Checking patch src/EntityReferenceRevisionsOrphanPurger.php...
Checking patch src/EntityReferenceRevisionsServiceProvider.php...
Checking patch src/Form/OrphanedCompositeEntitiesDeleteForm.php...
Checking patch src/Normalizer/EntityReferenceRevisionItemNormalizer.php...
Checking patch src/Plugin/DataType/EntityReferenceRevisions.php...
Checking patch src/Plugin/Derivative/MigrateEntityReferenceRevisions.php...
Checking patch src/Plugin/Field/FieldFormatter/EntityReferenceRevisionsEntityFormatter.php...
Checking patch src/Plugin/Field/FieldType/EntityReferenceRevisionsItem.php...
Checking patch src/Plugin/Field/FieldWidget/EntityReferenceRevisionsAutocompleteWidget.php...
Checking patch src/Plugin/diff/Field/EntityReferenceRevisionsFieldDiffBuilder.php...
Checking patch src/Plugin/migrate/destination/EntityReferenceRevisions.php...
Checking patch src/Plugin/views/display/EntityReferenceRevisions.php...
Checking patch src/Plugin/views/row/EntityReferenceRevisions.php...
Checking patch src/Plugin/views/style/EntityReferenceRevisions.php...
Checking patch src/TypedData/EntityRevisionDataDefinition.php...
Checking patch tests/modules/entity_host_relationship_test/src/Entity/EntityTestHostRelationship.php...
Checking patch tests/src/Functional/EntityReferenceRevisionsAdminTest.php...
Checking patch tests/src/Functional/EntityReferenceRevisionsAutocompleteTest.php...
Checking patch tests/src/Functional/EntityReferenceRevisionsNormalizerTest.php...
Checking patch tests/src/Functional/EntityReferenceRevisionsOrphanRemovalTest.php...
Checking patch tests/src/Kernel/EntityReferenceRevisionsCompositeTest.php...
Checking patch tests/src/Kernel/EntityReferenceRevisionsCompositeTranslatableFieldTest.php...
Checking patch tests/src/Kernel/EntityReferenceRevisionsCompositeTranslationTest.php...
Checking patch tests/src/Kernel/EntityReferenceRevisionsFormatterTest.php...
Checking patch tests/src/Kernel/EntityReferenceRevisionsSaveTest.php...
Checking patch tests/src/Kernel/Plugin/Derivative/EntityReferenceRevisionsDeriverTest.php...
Checking patch tests/src/Kernel/Plugin/migrate/destination/EntityReferenceRevisionsDestinationTest.php...
Applied patch composer.json cleanly.
Applied patch entity_reference_revisions.info.yml cleanly.
Applied patch entity_reference_revisions.views.inc cleanly.
Applied patch src/Commands/EntityReferenceRevisionsCommands.php cleanly.
Applied patch src/EntityNeedsSaveInterface.php cleanly.
Applied patch src/EntityNeedsSaveTrait.php cleanly.
Applied patch src/EntityReferenceRevisionsFieldItemList.php cleanly.
Applied patch src/EntityReferenceRevisionsOrphanPurger.php cleanly.
Applied patch src/EntityReferenceRevisionsServiceProvider.php cleanly.
Applied patch src/Form/OrphanedCompositeEntitiesDeleteForm.php cleanly.
Applied patch src/Normalizer/EntityReferenceRevisionItemNormalizer.php cleanly.
Applied patch src/Plugin/DataType/EntityReferenceRevisions.php cleanly.
Applied patch src/Plugin/Derivative/MigrateEntityReferenceRevisions.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/EntityReferenceRevisionsEntityFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldType/EntityReferenceRevisionsItem.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/EntityReferenceRevisionsAutocompleteWidget.php cleanly.
Applied patch src/Plugin/diff/Field/EntityReferenceRevisionsFieldDiffBuilder.php cleanly.
Applied patch src/Plugin/migrate/destination/EntityReferenceRevisions.php cleanly.
Applied patch src/Plugin/views/display/EntityReferenceRevisions.php cleanly.
Applied patch src/Plugin/views/row/EntityReferenceRevisions.php cleanly.
Applied patch src/Plugin/views/style/EntityReferenceRevisions.php cleanly.
Applied patch src/TypedData/EntityRevisionDataDefinition.php cleanly.
Applied patch tests/modules/entity_host_relationship_test/src/Entity/EntityTestHostRelationship.php cleanly.
Applied patch tests/src/Functional/EntityReferenceRevisionsAdminTest.php cleanly.
Applied patch tests/src/Functional/EntityReferenceRevisionsAutocompleteTest.php cleanly.
Applied patch tests/src/Functional/EntityReferenceRevisionsNormalizerTest.php cleanly.
Applied patch tests/src/Functional/EntityReferenceRevisionsOrphanRemovalTest.php cleanly.
Applied patch tests/src/Kernel/EntityReferenceRevisionsCompositeTest.php cleanly.
Applied patch tests/src/Kernel/EntityReferenceRevisionsCompositeTranslatableFieldTest.php cleanly.
Applied patch tests/src/Kernel/EntityReferenceRevisionsCompositeTranslationTest.php cleanly.
Applied patch tests/src/Kernel/EntityReferenceRevisionsFormatterTest.php cleanly.
Applied patch tests/src/Kernel/EntityReferenceRevisionsSaveTest.php cleanly.
Applied patch tests/src/Kernel/Plugin/Derivative/EntityReferenceRevisionsDeriverTest.php cleanly.
Applied patch tests/src/Kernel/Plugin/migrate/destination/EntityReferenceRevisionsDestinationTest.php cleanly.

    However, I'm still seeing PHPCS errors.

    I ran this command:
    phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig entity_reference_revisions/

    Applied to Entity Reference Revisions module with 8.x-1.x-dev version (Branch: (8.x-1.x)) and with the Drupal core version of 9.5.x.

    Please see the attached file "phpcsafterthepatch.png" for your reference.

    I'm moving this to Needs work.

    Thank you!

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 12 months ago
    Patch Failed to Apply
  • Comment 12 months ago →
    🇮🇳India sakthi_dev

    Please review.

  • Comment 12 months ago →
    🇮🇳India sakthi_dev

    Please fix remaining issues.

  • Comment 6 months ago →
    🇮🇳India zkhan.aamir
  • Comment 6 months ago →
    🇮🇳India nitin_lama

    Neither Patch #8 nor patch #11 applies to 8.x-1.x.

  • Comment 6 months ago →
    🇷🇺Russia zniki.ru

    Nikolay Shapovalov → made their first commit to this issue’s fork.

  • Assigned to zniki.ru
  • Comment 6 months ago →
    🇷🇺Russia zniki.ru
  • Comment 6 months ago →
    🇷🇺Russia zniki.ru
  • Merge request !36Resolve #3128194 "Fix the issues reported by phpcs" → (Open) created by zniki.ru
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 6 months ago
    38 pass, 2 fail
  • Issue was unassigned.
  • Comment 6 months ago →
    🇷🇺Russia zniki.ru

    I create MR from patch #8, add some changes from my side.
    Some issues still need to be fixed.

  • Comment 6 months ago →
    🇷🇺Russia zniki.ru
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 6 months ago
    39 pass
  • Comment 6 months ago →
    🇷🇺Russia zniki.ru
  • Assigned to nitin_lama
  • Comment 6 months ago →
    🇮🇳India nitin_lama
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 6 months ago
    PHPLint Failed
  • Comment 6 months ago →
    🇮🇳India nitin_lama

    Updating IS for the remaining issues.

  • Issue was unassigned.
  • Comment 6 months ago →
    🇮🇳India nitin_lama
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 6 months ago
    39 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 6 months ago
    39 pass
  • Status changed to Needs review 6 months ago
  • Comment 6 months ago →
    🇷🇺Russia zniki.ru

    Ready for review.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 6 months ago
    39 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 6 months ago
    39 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 6 months ago
    39 pass
  • First commit to issue fork.
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 5 months ago
    Not currently mergeable.
  • Comment 5 months ago →
    🇷🇺Russia zniki.ru

    @Yashaswi18 thanks for you commit, but changes you suggested is not been reported by phpcs.
    You can see list of violations in the Issue Summary.
    I am going to revert commit 918f306df.

  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 5 months ago
    Not currently mergeable.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 5 months ago
    40 pass
  • Comment 5 months ago →
    🇷🇺Russia zniki.ru

    Update IS on latest 8.x-1.x branch.
    Update MR.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 5 months ago
    40 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 5 months ago
    40 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 5 months ago
    40 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 5 months ago
    40 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 5 months ago
    40 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 5 months ago
    40 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
    last update 5 months ago
    40 pass
  • Comment 5 months ago →
    🇷🇺Russia zniki.ru

    I removed from MR changes that is not related to provided IS violations list.
    Hope nothing left.
    MR is pretty big, but changes is not difficult.

  • Comment about 1 month ago →
    🇫🇷France DYdave

    The changes from MR!36 seem to be fixing all phpcs issues and getting the job to pass ✅

    Could this be reviewed and merged by a maintainer please?

    Feel free to let us know if you would see anything else missing or any other task to be done in this ticket, we would be very happy to help.

    Thanks in advance!

  • Comment about 1 month ago →
    🇵🇭Philippines roberttabigue

    Hi @Dydave,

    I have applied the latest MR !36 to the Entity Reference Revisions module against 8.x-1.x-dev on Drupal 10 and confirmed that all PHPCS errors have been fixed.

    I ran this command on the module:
    phpcs --standard=Drupal,DrupalPractice --extensions=php,inc,module,install,info,test,profile,theme entity_reference_revisions

    Please see the attached files for reference.

    I'm moving this now to RTBC.

    Thank you!

  • Status changed to RTBC about 1 month ago
  • Comment about 1 month ago →
    🇵🇭Philippines roberttabigue
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024