🇮🇳India @Binoli Lalani

Hello,

I created MR for #17 patch as we are creating MR as per the standard process. Also, I have fixed PHPCS issues for patch code.

Please review.

Thank you!

binoli lalani → made their first commit to this issue’s fork.

binoli lalani → made their first commit to this issue’s fork.

Hello,

I raised MR !10343 against 11.x branch. Please review.

Thank You!

binoli lalani → made their first commit to this issue’s fork.

binoli lalani → made their first commit to this issue’s fork.

Hello,

Last 10301 MR had 1000+ changes. I think it was not rebased with the latest code changes of 11.x so I have created new 10323 MR with latest 11.x branch changes and hidden previous MR.

Please review.
Thank you!

binoli lalani → changed the visibility of the branch 3489161--warning-undefined to hidden.

binoli lalani → made their first commit to this issue’s fork.

binoli lalani → made their first commit to this issue’s fork.

Hello,

I created MR as part of new process of contribution.

Please review.

Thanks!

binoli lalani → changed the visibility of the branch 3344910-ajax-error-on to active.

binoli lalani → changed the visibility of the branch 3344910-ajax-error-on to hidden.

binoli lalani → made their first commit to this issue’s fork.

Hello,

Thank you for reviewing the code. I pushed the code for comment on MR. Please review.

Thank you!

Hello,

I have created MR and did some code changes to fix the warning and testcase errors. Please review.

Thank you!

binoli lalani → made their first commit to this issue’s fork.

binoli lalani → changed the visibility of the branch 3475161-trim-passing-null to hidden.

Hello,

I have created MR as we are using generating MR approach instead of creating a patch.

Thank you!

binoli lalani → made their first commit to this issue’s fork.

binoli lalani → changed the visibility of the branch 3074435-blocks-added-by to active.

binoli lalani → changed the visibility of the branch 3074435-blocks-added-by to hidden.

Hello,

I was facing the same issue after applying the patch as per https://www.drupal.org/project/layout_builder_st/issues/3441591#comment-... 🐛 "Non-reusable blocks must set an access dependency for access control." Needs review comment so I committed the code in 11 MR. Please review.

Thank you!

binoli lalani → made their first commit to this issue’s fork.

binoli lalani → made their first commit to this issue’s fork.

Hello,

I merged latest code changes from base branch into fork's branch and rerun the pipeline. Testcases are passed. Please review.

Thank You!

binoli lalani → made their first commit to this issue’s fork.

Kristen Pol → credited Binoli Lalani → .

Binoli Lalani → made their first commit to this issue’s fork.

Binoli Lalani → made their first commit to this issue’s fork.

Binoli Lalani → made their first commit to this issue’s fork.

Binoli Lalani → changed the visibility of the branch 3420865-Olivero-table-head to hidden.

Hello,

I resolved the conflicts of 6566 MR and hide 7718 MR.

Please review.

Thank you!

Binoli Lalani → made their first commit to this issue’s fork.

Binoli Lalani → made their first commit to this issue’s fork.

Hello,

I have converted the patch into MR. Please review.

Thank you!

Binoli Lalani → made their first commit to this issue’s fork.

Hello @smustgrave,

Thank you for reviewing the code. I have added test coverage for the warning. Please review.

Thank you!

Hello,

I have added test coverage for this PHP deprecation error along with this error fix. Please review.

Thank you!

Binoli Lalani → made their first commit to this issue’s fork.

Hello,

I can reproduce the error in drupal 11.x and raised MR against 11.x branch. Please review.

Thank you!

Binoli Lalani → made their first commit to this issue’s fork.

Binoli Lalani → made their first commit to this issue’s fork.

Hello,

I have reverted UrlGenerator code. Please review.

Thank you!

Hello,

Thank you for reviewing the code. I have updated the code as per the comment on MR. Please review.

Thank you!

Binoli Lalani → made their first commit to this issue’s fork.

Hello,

I rebased the branch to check the testcases actual errors. Now testcases are passed with the latest code merge. Please review the MR.

Thank you!

Binoli Lalani → made their first commit to this issue’s fork.

Binoli Lalani → made their first commit to this issue’s fork.

Hello @catch,

Thank you for reviewing the MR. I have created another MR against 10.3.x branch and added deprecation.
Pipeline is failed due to phpstan error in system.module. I verified that it is not related to this code change. It is already there in the latest code.

Please review the MR and let me know if any changes needed.

Thank you!

Binoli Lalani → made their first commit to this issue’s fork.

Hello,

I have tried to resolve the conflicts of 5384 MR but It has unwanted code changes so I hide that MR and created a new MR. Please review it.

Thank You!

Binoli Lalani → changed the visibility of the branch 3303557-deprecate-and-remove to hidden.

Binoli Lalani → made their first commit to this issue’s fork.

Hello,

I converted patch to MR. Please review the MR.

Thank you!

Binoli Lalani → made their first commit to this issue’s fork.

Hello,

Thank you for reviewing the MR.

I added a deprecated tag in the interface and found 2 issues where an interface is deprecated and it's removed from the class where it implements.

Reference issues: https://www.drupal.org/project/drupal/issues/3354584 📌 Deprecate TrustedCallbackInterface in favour of TrustedCallback attribute Needs work , https://www.drupal.org/project/drupal/issues/2266817 📌 Deprecate empty AccessInterface and remove usages Needs work

I updated the code in the MR. Please review.

Thanks!

Hello,

I fixed the Phpunit testcases error. Please review the MR.

Thanks!

Binoli Lalani → made their first commit to this issue’s fork.

Hello,

I updated the permission description as per Proposed resolution and fixed unit testcase errors. Please review latest commit.

Thank you

Binoli Lalani → made their first commit to this issue’s fork.

Hello,

I am attaching 2 patches as code is not latest either in git or download module with composer.

1. 3366988-2-composer.patch patch is for downloading module by composer
2. 3366988-2-composer.patch patch is for cloning module with git

Please review.

Binoli Lalani → created an issue.

Hello,

I have fixed PHPCS errors and warnings. Please review MR.

Thank you!

Binoli Lalani → created an issue.

Hello @jeremylichtman,

Thank you for providing this opportunity.

Yes, I would like to take the maintainer role for this project.

Thank you!

Hello,

I have created MR and changed array() to [].

Please review.

Thank you!

Binoli Lalani → made their first commit to this issue’s fork.

Hello,

Thank you for testing this issue and confirming that it is fixed with the MR. Moving this to RTBC.

Thank you!

Hello,

I fixed error. Please review MR.

Thank you!

Binoli Lalani → created an issue.

Hello,

I fixed the error. Please review MR.

Thank you!

Binoli Lalani → created an issue.

Hello,

There is already created issue 🐛 t() calls should be avoided in classes RTBC for t() calls so I think we need to reopen that issue.

I have fixed other warnings in MR.

Thank you!

Hello @clarkssquared,

Thank you for testing the code and verifying it.
Actually, when we clone the module, it is not showing the warnings which are showing in "3354803-after.png".
I think "project", "datestamp" and "version" have been automatically added when we installing module by composer.

I think we are goog with the current code.

Please share your view on this.

Thank you!

Hello @dineshkumarbollu,

Thank you for reviewing the MR. Which issues are you facing? Can you please elaborate more? because It seems all errors and warnings have been addressed in my local.

Thank you!

Hello,

I have fixed PHPCS errors. Please review MR.

Thank you!

Binoli Lalani → created an issue.

Hello,

I have created MR to fix PHPCS errors and warnings.

Please review.

Thank you!

Binoli Lalani → created an issue.

Hello,

I fixed PHPCS errors and warnings. Please review MR.

Thank you!

Binoli Lalani → created an issue.

Hello,

I fixed PHPCS warnings and errors. Please review MR.

Thank you!

Binoli Lalani → created an issue.

Hello,

I have fixed PHPCS errors and warnings. Please review MR.

Thank you!

Binoli Lalani → created an issue.

Hello @sayco,

Thank you for reviewing the code. I have changed the description as suggested. Please review.

Thank you!

Hello,

I fixed PHPCS warnings and errors. Please review MR.

Thank you!

Binoli Lalani → created an issue.

Hello @sayco,

Thank you for reviewing the code. I have committed code to add NULL instead of FALSE. Please review.

Thank you!

Hello,

I have fixed the error and created MR. Please review.

Thank you!

Binoli Lalani → created an issue.

Hello,

Please review MR.

Thank you!

Binoli Lalani → created an issue.