Deprecate StorageComparerInterface

Ah excellent! We discussed this on slack the other day and concluded that it should never have been an interface.

Hello,
I will work on this one!

Binoli Lalani → made their first commit to this issue’s fork.

Hello,

I fixed the Phpunit testcases error. Please review the MR.

Thanks!

I think that this is not correct.
Because with this MR the comparer doesn't implement the interface this will break custom or contrib code which typehints the interface but then passes in a normal comparer. Also this MR does not add the deprecated tag on the interface.

I don't know of the top of my head what other interfaces have been deprecated but looking for one and following the example would be good.

Hello,

Thank you for reviewing the MR.

I added a deprecated tag in the interface and found 2 issues where an interface is deprecated and it's removed from the class where it implements.

Reference issues: https://www.drupal.org/project/drupal/issues/3354584 📌 Deprecate TrustedCallbackInterface in favour of TrustedCallback attribute Needs work , https://www.drupal.org/project/drupal/issues/2266817 📌 Deprecate empty AccessInterface and remove usages Needs work

I updated the code in the MR. Please review.

Thanks!

Will need a change record and that's what deprecation link should point to

Probably need a deprecation test too

May want to see if we are good to deprecate though.