Fix the issues reported by phpcs

FILE: /maxlength/tests/src/FunctionalJavascript/MaxLengthJavascriptTest.php --------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------- 80 | WARNING | Line exceeds 80 characters; contains 88 characters --------------------------------------------------------------------------------------------------------------- FILE: /maxlength/tests/src/FunctionalJavascript/MaxLengthCkeditorTest.php --------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES --------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 138 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters 242 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters 396 | ERROR | [ ] Protected method name "MaxLengthCkeditorTest::getCKEditor4" is not in lowerCamel format ---------------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @Binoli Lalani
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
5 pass
@binoli-lalani opened merge request.
Issue was unassigned.
Status changed to Needs review over 1 year ago6:12am 21 April 2023
Comment over 1 year ago →
🇮🇳India Binoli Lalani Gujarat
Hello,

I have fixed PHPCS errors and warnings. Please review MR.

Thank you!
Assigned to sourabhjain
Comment over 1 year ago →
🇮🇳India sourabhjain
Let me review it.
Issue was unassigned.
Status changed to RTBC over 1 year ago7:15am 21 April 2023
Comment over 1 year ago →
🇮🇳India sourabhjain
I have reviewed the changes and its looks fine to me. Attaching Screenshots for reference.
Moving to RTBC.
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Assigned to joevagyok
Comment over 1 year ago →
🇺🇸United States hipp2bsquare Temple, New Hampshire
I've confirmed the patch resolves the coding standards issues reported in phpcs, and visually reviewed the changes as well. This seems good to me, but cedewey and I would like for joevagyok to give it a final review prior to merging as the testing expert among the maintainers.
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
5 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
5 pass
Comment over 1 year ago →
System Message

joevagyok → committed 91d0d710 on 2.1.x authored by Binoli Lalani →
Issue #3355530 by Binoli Lalani: Fix the issues reported by phpcs
Comment over 1 year ago →
🇧🇪Belgium joevagyok
Status changed to Fixed over 1 year ago5:15pm 18 July 2023
Comment over 1 year ago →
🇧🇪Belgium joevagyok
Thank you for the work on this!
Issue was unassigned.
Comment over 1 year ago →
🇧🇪Belgium joevagyok
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Comments & Activities