Nevermind, I'm discovering this rector patch also has issues. I recommend just using stefanbutura's patch on the other issue, as mentioned in my prior comment.
How odd -- I'm noticing that the rector bot created two different "Automated Drupal 10 compatibility fixes" issues. The work in my MR combines the latest rector patch with stefanbutura's work on the *other* Automated Drupal 10 compatibility fixes 📌 Automated Drupal 10 compatibility fixes RTBC issue.
I made some additional fixes required for this to work with D10. See MR !6.
hipp2bsquare → made their first commit to this issue’s fork.
cedewey → credited hipp2bsquare → .
cedewey → credited hipp2bsquare → .
We have been unable to reproduce this, testing in Drupal 9.5.10, with either the Claro or Seven admin themes enabled. See screenshot.
We need more specific steps on how to recreate this.
I've confirmed the patch resolves the coding standards issues reported in phpcs, and visually reviewed the changes as well. This seems good to me, but cedewey and I would like for joevagyok to give it a final review prior to merging as the testing expert among the maintainers.
Please review MR !6, which supports custom user form modes on RoleAssign 2.0.x.
It identifies user form modes by checking the base form id. If the base form is the user form, then the form id is added to the $user_forms array:
if (($form_state->getBuildInfo()['base_form_id']) == 'user_form') {
$user_forms[] = $form_id;
}
I then made the user forms code the default case on the switch() statement.
I'm going to make a new version of this patch for the 2.0.x branch.
Tested the patch generated from stefanbutura's MR 5 and it's working well.
This looks good. Merging in recent master branch changes and then will commit this to the project. Thank you!
hipp2bsquare → made their first commit to this issue’s fork.
Great, this all looks good. Thank you!
hipp2bsquare → made their first commit to this issue’s fork.
Please review Merge Request 8 -- as per the
Filter API documentation →
, I change the filter type to TYPE_TRANSFORM_IRREVERSIBLE.
This change allowed the module to work as expected on an existing implementation and a fresh install. CKE4 compatibility still needs to be tested.
hipp2bsquare → made their first commit to this issue’s fork.
Excellent! I've tested fisherman90's merge request and it's working great on both CKE5 and 4. I believe all our test coverage is CKE-version agnostic, but I will confirm with the other maintainers.
For me this issue was fixed by uninstalling and re-installing the linkit module.
Thanks for doing this, essential work for a full 2.0 release!
hipp2bsquare → made their first commit to this issue’s fork.
Looks good. Committing to the project.
hipp2bsquare → made their first commit to this issue’s fork.
This looks great. Tested and works as expected.
hipp2bsquare → made their first commit to this issue’s fork.