Counter element position is incorrect when BigPipe is enabled

Created on 5 June 2023, over 1 year ago
Updated 21 June 2024, 5 months ago

Problem/Motivation

Counter element is displayed on top of CKEditor5 element

Steps to reproduce

  1. Enable BigPipe module
  2. Configure maxlength settings for Text (formatted, long) type field
  3. Keep field description empty

Proposed resolution

The counter element should go after CKEditor5 element

🐛 Bug report
Status

Needs review

Version

2.1

Component

Code

Created by

🇮🇳India gaurav_manerkar Vasco Da Gama, Goa

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @gaurav_manerkar
  • 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    5 pass
  • Status changed to Postponed: needs info over 1 year ago
  • 🇺🇸United States cedewey Denver, CO

    Hi Gaurav,

    Thank you for reporting this and submitting a merge request to fix it.

    I can't reproduce this issue on my end. I'm running Drupal 10.0.9. The counter is appearing below the text field as expected in both Chrome and Firefox on Linux.

    Can you share any more details that can help me reproduce this?

  • 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa

    Hi Clayton,
    I am facing the problem on Drupal 9.5 for the Text (formatted, long) type field.

  • 🇩🇪Germany broon Potsdam

    I can confirm the behaviour on Drupal 9.5.9 with MaxLength 2.1.1.

    Counter information is *below* the text field for plain textfields and textareas, but *above* for formatted long text (CKE 5).

    MR#35 from comment #3 is fixing the issue for me.

  • Status changed to Needs review over 1 year ago
  • 🇺🇸United States cedewey Denver, CO
  • Status changed to Postponed: needs info over 1 year ago
  • 🇺🇸United States hipp2bsquare Temple, New Hampshire

    We have been unable to reproduce this, testing in Drupal 9.5.10, with either the Claro or Seven admin themes enabled. See screenshot.

    We need more specific steps on how to recreate this.

  • 🇺🇸United States tjhellmann Indianapolis, IN

    I ran into this issue today only when BigPipe module was enabled. With BigPipe turned on some of the textarea fields would have the counter above the ckeditor. With BigPipe uninstalled, all the counters displayed in the correct position. The change in #3 is fixing the issue. Works now with BigPipe installed or not.

  • Status changed to Needs review over 1 year ago
  • 🇺🇸United States cedewey Denver, CO

    Thanks for adding this info. I'll make time soon to try and recreate this issue and if I can, test out the patch as well.

  • 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa

    Is there any update? Do we need to provide support to D9?

  • 🇺🇸United States cedewey Denver, CO

    Thanks for checking in on this Gaurav. Since my company is standardized on Pantheon, which doesn't support BigPipe I can't review whether the patch does indeed fix the issue. Can you test this with BigPipe installed and confirm whether or not it still fixes the issue?

  • 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa

    @cedewey
    Yes, it works fine with BigPipe installed. No issue on D9 or D10.

  • 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa

    Please review my MR and test on D9 as well as D10.

Production build 0.71.5 2024