Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 19 April 2023, over 1 year ago

Problem/Motivation

FILE: /broken_link/broken_link.install
-----------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
-----------------------------------------------------------------------------------------------------------------------------
  88 | ERROR | [x] Doc comment short description must end with a full stop
  94 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  96 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
 108 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
 121 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 122 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found

Steps to reproduce

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml broken_link

Proposed resolution

Fix the errors.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

RTBC

Version

3.2

Component

Code

Created by

🇮🇳India Binoli Lalani Gujarat

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Binoli Lalani
  • @binoli-lalani opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India Binoli Lalani Gujarat

    Hello,

    I have fixed PHPCS errors. Please review MR.

    Thank you!

  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India omkar_yewale Mumbai

    Hi @Binoli Lalani,

    I have reviewed !6 MR and all mentioned issues/warnings have been addressed.
    Moving RTBC.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024