- Issue created by @joachim
- Status changed to RTBC
about 1 year ago 9:37am 6 March 2024 - Status changed to Needs work
about 1 year ago 9:44am 6 March 2024 The Needs Review Queue Bot โ tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request โ . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Merge request !6949EntityListBuilder::buildRow() return docs change โ (Open) created by dineshkumarbollu
- ๐ฎ๐ณIndia Binoli Lalani Gujarat
Binoli Lalani โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 1 year ago 10:29am 12 April 2024 - ๐ฎ๐ณIndia Binoli Lalani Gujarat
Hello,
I rebased the branch to check the testcases actual errors. Now testcases are passed with the latest code merge. Please review the MR.
Thank you!
- Status changed to RTBC
about 1 year ago 4:55pm 12 April 2024 - ๐บ๐ธUnited States smustgrave
Previously was RTBC before bot. Conversion to MR seems fine.
- Status changed to Needs work
about 1 year ago 6:25am 14 April 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
but actually, it's not necessarily a render array. The result is put into the table render element's #rows property, and that can take a row array where each cell is a string, or an array with a 'data' key.
So this is still an array - either a render array or an array of strings... so changing this to mixed is misleading at the comment change is also wrong as we're not returning a string here.
- ๐ฌ๐งUnited Kingdom joachim
> This can either be a string representing a cell
This is wrong too.